From nobody Mon Sep 16 18:55:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1674811641; cv=none; d=zohomail.com; s=zohoarc; b=JVAsv4mRRQm6+8LY5YP1VaI4SuOJCAD7lL5YS0mKQ9+Oruw7B9NO0Nxnixlgb6HBcBXRYw1rUfnG0ORb8aqKe2IdRAUduT3SwRiYbW5tZ8IcE+gy0u59yF679R4GQmiYC8DOU2lAiQ7QOhzLlUO9CleSS5PkFse3QXVlpqNs9YU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674811641; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RWs5T2MrrRY6W+OS7Yp18fRBs/HKQQpzVDohCrPXXyQ=; b=EZI0MD4tVBDgHXy0MUssGsVzLhx9RVgQ/Nge3u6K45HG4ntU5/XmM4OgcuuKKjIxN36vJuKfrU7B7G4J/LD2OnR5C55JBkJI8B9NU4MIpwHjYlDT2iXh54WxA9CvRDl0w5hLe6tBm4pXU0tv3139Z3GXrFHWL9g/Qv+ytnUi5VY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1674811641093856.5304156637291; Fri, 27 Jan 2023 01:27:21 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-403-nOj_qYPkP7uCxx6zwIKr2Q-1; Fri, 27 Jan 2023 04:27:16 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EAD2B830F85; Fri, 27 Jan 2023 09:27:13 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id D3DD31121318; Fri, 27 Jan 2023 09:27:13 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9D2B419451EC; Fri, 27 Jan 2023 09:27:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E21B819465B8 for ; Fri, 27 Jan 2023 09:27:02 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id D748D1400AFC; Fri, 27 Jan 2023 09:27:02 +0000 (UTC) Received: from ridgehead.home.lan (ovpn-193-168.brq.redhat.com [10.40.193.168]) by smtp.corp.redhat.com (Postfix) with ESMTP id 563FF14171BE; Fri, 27 Jan 2023 09:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674811640; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=RWs5T2MrrRY6W+OS7Yp18fRBs/HKQQpzVDohCrPXXyQ=; b=gvvGWmFBNLWkMICovamBascbUEs1bsuHwjMahfT0pw1IxTcBVCeWmQzGdn5m1x3Mm+3VeS aoxs2iNb8NokNAlS06HzY5g62WjwlrgmENwkShxf+XOkGWO3s+NlOQiWY9tZ/LZe8g8trL OLqXO6WJLO/mt98V5LP5SFHyb5wGUCY= X-MC-Unique: nOj_qYPkP7uCxx6zwIKr2Q-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Erik Skultety To: libvir-list@redhat.com Subject: [libvirt PATCH v2 6/8] ci: integration.sh: Add/Rewrite/Reformat commentaries Date: Fri, 27 Jan 2023 10:26:54 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Skultety Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1674811641810100002 Content-Type: text/plain; charset="utf-8"; x-default="true" Because of the nature of writing inline shell commands to YAML, most of the commentaries where inlined with the command not to hinder YAML readability any further. Since we moved the logic to a standalone script, we can now do whatever formatting & readability adjustments we want. Signed-off-by: Erik Skultety --- ci/integration.sh | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/ci/integration.sh b/ci/integration.sh index 160aecf00d..cbf2b0f1b4 100644 --- a/ci/integration.sh +++ b/ci/integration.sh @@ -3,10 +3,15 @@ # Avocado >98.0 fails with the nwfilter TCK tests, so stick with 98.0 for = now sudo pip3 install --prefix=3D/usr avocado-framework=3D=3D98.0 =20 -sudo sh -c "echo DefaultLimitCORE=3Dinfinity >> /etc/systemd/system.conf" = # Explicitly allow storing cores globally -sudo systemctl daemon-reexec # need to reexec systemd after changing config +# Explicitly allow storing cores globally +sudo sh -c "echo DefaultLimitCORE=3Dinfinity >> /etc/systemd/system.conf" + +# Need to reexec systemd after changing config +sudo systemctl daemon-reexec + +# Source the os-release file to query the vendor-provided variables +source /etc/os-release =20 -source /etc/os-release # in order to query the vendor-provided variables if test "$ID" =3D "centos" && test "$VERSION_ID" -eq 8 then DAEMONS=3D"libvirtd virtlockd virtlogd" @@ -23,6 +28,7 @@ do sudo systemctl restart ${daemon}.socket done =20 +# Make sure the default network is started on all platforms sudo virsh net-start default &>/dev/null || true =20 cd "$SCRATCH_DIR" --=20 2.39.1