From nobody Mon Feb 9 09:08:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1636986179; cv=none; d=zohomail.com; s=zohoarc; b=R0JFJWCjEBqDsAKMp0YHawLoLKsDbdPvf9M4+fkLcjFo+3iW6KTYFMH2+W5dAptLnGVGcfLcMAIO5CftYVdOPARSRXSTapqAiPiKl17XNOuYaLZ2O8ckYRT2pSSjLeeSO7mLNU587CxfYRX5lakO7+mM//6mreSGRf1Ci4rF7SA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636986179; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fdg4e10Kb3vdsy+6v4+kylj2gyjZMEuG1bmjtACq2yM=; b=gK4tRsqmeDDYmNgA8S2GjuiNdU8AP8mj11L3vCSxUqH16HOLowW/DAEPVKL0R+cwxYde/K50xOyrJPUVmlwbjrhaLdWz+CzJ4BoJz3jPh44wsazJlmf7sjQOjQtdHqyGdSYI1KQDB+aCkq4I/Z6mJMhJlDc5Y088s1CggmznaQ4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1636986179562433.4452659264492; Mon, 15 Nov 2021 06:22:59 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-258-tUNUaEGVPDOTKbxJvM8zPw-1; Mon, 15 Nov 2021 09:22:54 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 11B061015DBF; Mon, 15 Nov 2021 14:22:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF51B196E6; Mon, 15 Nov 2021 14:22:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AFB164EA39; Mon, 15 Nov 2021 14:22:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AFEMRlx009723 for ; Mon, 15 Nov 2021 09:22:27 -0500 Received: by smtp.corp.redhat.com (Postfix) id 14276509FF; Mon, 15 Nov 2021 14:22:27 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 735A97A8E2 for ; Mon, 15 Nov 2021 14:22:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636986178; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=fdg4e10Kb3vdsy+6v4+kylj2gyjZMEuG1bmjtACq2yM=; b=g04dNKox2NpnFnAxgqj00Z4O2Nwp30VLUvHSSQ248nXuH8LhhQYcUljY3GdJWKC3D69DR/ wsqVWdlNFjk+UIMkU9yYArbjQAddrRP+/GijDlL2CRkVErmAPRgmSQtVoK1YicKYNlBbAJ FOY5OgyL81A3BL6+Eq+Ih02OwBCj+Wk= X-MC-Unique: tUNUaEGVPDOTKbxJvM8zPw-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 07/18] qemu: monitor: Replace virJSONValueObjectCreate by virJSONValueObjectAdd Date: Mon, 15 Nov 2021 15:22:06 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1636986262939100001 Content-Type: text/plain; charset="utf-8" virJSONValueObjectAdd now works identically to virJSONValueObjectCreate when used with a NULL argument. Replace all callers. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 398bef2e96..ac988e063b 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -2880,10 +2880,10 @@ qemuMonitorCreateObjectProps(virJSONValue **propsre= t, int rc; va_list args; - if (virJSONValueObjectCreate(&props, - "s:qom-type", type, - "s:id", alias, - NULL) < 0) + if (virJSONValueObjectAdd(&props, + "s:qom-type", type, + "s:id", alias, + NULL) < 0) return -1; @@ -2961,11 +2961,11 @@ qemuMonitorAddObject(qemuMonitor *mon, *props =3D NULL; } - if (virJSONValueObjectCreate(&pr, - "s:qom-type", type, - "s:id", id, - "A:props", props, - NULL) < 0) + if (virJSONValueObjectAdd(&pr, + "s:qom-type", type, + "s:id", id, + "A:props", props, + NULL) < 0) return -1; } --=20 2.31.1