From nobody Tue Jan 21 03:59:10 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 173652200231089.07445574005214; Fri, 10 Jan 2025 07:13:22 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id BC4E3161F; Fri, 10 Jan 2025 10:13:21 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 9CC6C1641; Fri, 10 Jan 2025 10:13:07 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 442C7161B; Fri, 10 Jan 2025 10:13:05 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id BE4701619 for ; Fri, 10 Jan 2025 10:13:04 -0500 (EST) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-UGEfOp4rMwy6cKTIudE9NA-1; Fri, 10 Jan 2025 10:13:03 -0500 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4361d4e8359so17260875e9.3 for ; Fri, 10 Jan 2025 07:13:03 -0800 (PST) Received: from wheatley.localdomain (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9e37d69sm54464045e9.30.2025.01.10.07.13.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 07:13:01 -0800 (PST) Received: from wheatley.brq.redhat.com (wheatley.k8r.cz [127.0.0.1]) by wheatley.localdomain (Postfix) with ESMTP id B349E7C9F2CE for ; Fri, 10 Jan 2025 16:13:00 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736521984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NuL8SDyjeXk0lRk7a8uqRcYJNgMXRNEfRsGRlxbc408=; b=ilgqQ1KF7jKvwmXintR36IfIBtY70E7Stnlr/vX7xp7Z87sTf13PaRxHV/b8g5qdPDlVum t7pkx1+ZA9QHP01tpX7X7C+8dmacbP+vu4hMvX4W7trYNSerTuRSy/3FWuf83n98GKlCRv jLQxwEccaO7ano51XainFgl1z4Dihd8= X-MC-Unique: UGEfOp4rMwy6cKTIudE9NA-1 X-Mimecast-MFC-AGG-ID: UGEfOp4rMwy6cKTIudE9NA X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736521982; x=1737126782; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NuL8SDyjeXk0lRk7a8uqRcYJNgMXRNEfRsGRlxbc408=; b=RLXhFmOOlfDn4rOsRiVeCl1N8D1G6eswzRIPIchweMmiY30aK7I35GgWg4Xf0d/j/P 5FnUmw+nbpeaoXn5EoLhO8pmgWQ5OwbJ7HG0WqwlYDQrLj/EYqc8SMS4eGoNzD8EecfJ GoqgegyE6r9WuwuiA/VNzPcdhHLDGVTpQe/GvgwWMk5CrM1+HzlJL8XXfBIOh/jkGZzh eteHWyZCZWzjvv5Uu3qa+IZlEqXGNCwixJ78iy171VE8bMwkzFIjuasOhV0c1SAAxu++ 5y+B5ALloAjX3bNp3p9KO/MHCzBnaZWKC/OoVTSRDvOenYtG9Qx3LW3+hqKBzMDB5VGR Abqw== X-Gm-Message-State: AOJu0Yy6bJuN+wkTz3qS0KE7vODmsWj33XCOVL3XWPljCmMP2tqQPbEU E8kpAsXtDP63Nw0Ix7qQxTsQU4fIYxG9ZfIQVii5+lccXzRnMM/NrFqkxIE7ZWkFNnaTzfauSmU ZDOfpI3RJZvcYXpu91QIS2bYnr2ooHRfQZw0LIsiWk/0A8UuA/s9LGIR4YdiJuuES+9No1+dGhQ HbofrS7lu+xfSE1RiPuNjiOWUENNWR6rAR3/i6KJA= X-Gm-Gg: ASbGncs7MYwIrY0ykMBCTLMQ28WAt7MbQKlGeloETZJHNsnoKR6xWqdUVTwt0ViDgvr AldtPr6YxkwvaW/1gvv4+IB4C/12eH+zsfDjG+qcc6eWaX+biSnpK6+hrMDPwYy2dv1/OpQDLuj v3X7oa5no6i3qboGC9Fzl2rfcKdtEcm1N7oFRDfrl7gI7poKE6EcNPqlityepXr04TmKgh95FpZ qjZnS4y7Y4vp9j+GuMY5O6WL3BvyztPQUgJflV0qhKFV9SEAOl0WT/bXP62+x3FppLFx3aXg9ym BLuXXGHjgM+c0JHS X-Received: by 2002:a05:600c:5ca:b0:436:ed38:5c7f with SMTP id 5b1f17b1804b1-436ed385da5mr55016935e9.12.1736521981973; Fri, 10 Jan 2025 07:13:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IHYPF56DrZF6/OF5IZp23/qD/w/gUq1SCwdijmRTmydbtQkLWtiyVTL3WyyDuIHH6an802t0Q== X-Received: by 2002:a05:600c:5ca:b0:436:ed38:5c7f with SMTP id 5b1f17b1804b1-436ed385da5mr55016605e9.12.1736521981492; Fri, 10 Jan 2025 07:13:01 -0800 (PST) From: Martin Kletzander To: devel@lists.libvirt.org Subject: [PATCH] conf: Do not parse hyperv features with passthrough mode Date: Fri, 10 Jan 2025 16:12:57 +0100 Message-ID: X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RO069CTPR0We3eJIgHe87Fl8azXzYHFvYi8ZnjaNjn4_1736521982 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: DHDSQGFN4ND5KEZ5S6DB7GYIOXVWUQTK X-Message-ID-Hash: DHDSQGFN4ND5KEZ5S6DB7GYIOXVWUQTK X-MailFrom: mkletzan@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1736522003704019000 Content-Type: text/plain; charset="utf-8"; x-default="true" The schema does not allow that anyway and we then format them all back which leads to libvirt producing an invalid XML. Resolves: https://issues.redhat.com/browse/RHEL-70656 Signed-off-by: Martin Kletzander Reviewed-by: Michal Privoznik --- src/conf/domain_conf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e658b68c48b6..3f88a77a8fea 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -16643,6 +16643,9 @@ virDomainFeaturesHyperVDefParse(virDomainDef *def, =20 def->features[VIR_DOMAIN_FEATURE_HYPERV] =3D mode; =20 + if (mode =3D=3D VIR_DOMAIN_HYPERV_MODE_PASSTHROUGH) + return 0; + node =3D xmlFirstElementChild(node); while (node !=3D NULL) { int feature; --=20 2.47.1