From nobody Mon Apr 29 03:32:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1547564924664308.82650656436374; Tue, 15 Jan 2019 07:08:44 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C99317F41D; Tue, 15 Jan 2019 15:08:41 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4DD4B1048107; Tue, 15 Jan 2019 15:08:41 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6AA401803391; Tue, 15 Jan 2019 15:08:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x0FF8ds7027801 for ; Tue, 15 Jan 2019 10:08:39 -0500 Received: by smtp.corp.redhat.com (Postfix) id 93C2E18EFB; Tue, 15 Jan 2019 15:08:39 +0000 (UTC) Received: from beluga.usersys.redhat.com (unknown [10.43.2.166]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C1995C7B7; Tue, 15 Jan 2019 15:08:32 +0000 (UTC) From: Erik Skultety To: libvir-list@redhat.com Date: Tue, 15 Jan 2019 16:08:24 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Erik Skultety Subject: [libvirt] [PATCH] util: audit: Fix the error code when kernel lacks audit support X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 15 Jan 2019 15:08:42 +0000 (UTC) Content-Type: text/plain; charset="utf-8" When commit 4199c2f221c tweaked the error path of virAuditOpen it used VIR_FROM_THIS as the error code to virReportError. https://bugzilla.redhat.com/show_bug.cgi?id=3D1596119 Signed-off-by: Erik Skultety Reviewed-by: Marc Hartmayer --- src/util/viraudit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/viraudit.c b/src/util/viraudit.c index a02e5b36fd..d04343a542 100644 --- a/src/util/viraudit.c +++ b/src/util/viraudit.c @@ -66,7 +66,8 @@ int virAuditOpen(unsigned int audit_level ATTRIBUTE_UNUSE= D) if (audit_level < 2) VIR_INFO("Audit is not supported by the kernel"); else - virReportError(VIR_FROM_THIS, "%s", _("Audit is not suppor= ted by the kernel")); + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Audit is not supported by the kernel")); } else { virReportSystemError(errno, "%s", _("Unable to initialize audi= t layer")); } --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list