From nobody Tue May 7 18:39:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562946759; cv=none; d=zoho.com; s=zohoarc; b=UBxfv3tfOtecSnwvbzqyZjatQA9xSIXFdq1ps9XVsix9VdxQKxeVq7AnKPsAxu6GJOS2rwiEq+Z+Wj26IoKivsaxF/4W0YNi4qih5sMWCZplMZK8TaCHGCg3nPVEDiTNeJ/jJvRSauESRlkph5hMyEB4rSGSZDOy7sf5V0xageA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562946759; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=zNyrkZTRQd4mZ7NQiuGJUsRZrwsVJnKZ7XPyAZ5DSxg=; b=CBUp6OGJNtXlDIuVlHCeQ4O3JkrQcIMjf5+MiK9VAW0h6dtEh8Z45QCV8Xv87jyq4A3jX2N5qpZ5YCvm+ugeN65GvS8LUb0K0e55OyOfNKTNAbs58uoryuvQG1D49jAiI2KsCsi5m7v1SVXdhVilo2GHpK6CzRJOzkZU0hDin2U= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1562946759602103.48746937619251; Fri, 12 Jul 2019 08:52:39 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7FD056698C; Fri, 12 Jul 2019 15:52:37 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D35F60142; Fri, 12 Jul 2019 15:52:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DD1551833002; Fri, 12 Jul 2019 15:52:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6CFqUMC011653 for ; Fri, 12 Jul 2019 11:52:30 -0400 Received: by smtp.corp.redhat.com (Postfix) id C33CA5DE73; Fri, 12 Jul 2019 15:52:30 +0000 (UTC) Received: from lpt.brq.redhat.com (unknown [10.43.2.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4AC2B5DE78 for ; Fri, 12 Jul 2019 15:52:27 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Fri, 12 Jul 2019 17:53:06 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] storage: rbd: do not attempt to dereference a non-pointer X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 12 Jul 2019 15:52:38 +0000 (UTC) My commit 9b7c4048fa0559fd81d57b7f7d13b1dccd6a99b2 was too blind and my librbd was not new enough to actually compile this part. Signed-off-by: J=C3=A1n Tomko --- Pushed under the 'build breaker fix' rule whilst violating the 'do not push patches on a Friday afternoon' rule. src/storage/storage_backend_rbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backen= d_rbd.c index 1cb447c55a..f3104ba310 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -637,7 +637,7 @@ virStorageBackendRBDGetVolNames(virStorageBackendRBDSta= tePtr ptr) nnames =3D nimages; =20 for (i =3D 0; i < nimages; i++) - VIR_STEAL_PTR(names[i], images[i]->name); + VIR_STEAL_PTR(names[i], images[i].name); =20 return names; =20 --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list