From nobody Tue Jun 9 21:02:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1777359007; cv=none; d=zohomail.com; s=zohoarc; b=IYuHhlevRIZLPoo96pLpZ+benGdalXL1HXx2AqsPs/8/aCChwTVOrQAfU+fmDJQm0HrWEJJvUqivHFPDWrNQPnhBrEizlv/xLAjIAkcbZCMlnfczDbFlJw0CBfiy4kWBmod/q1oXotYE+EqT1dNVbQ1gUrSVD1g+VEQV7RCe1ks= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777359007; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=skukaKLQumaAHWenvMw6HcdPMvJ5bxwyKH29IDLnJ+E=; b=cFRanZ5QPbECAxJTjBirRnwvo/uHsYuleS0QUrpteILUJ6RSpFHF6j6G3vR6vI+HVkEOs9J3Nb3V2H5K3uzVIMSQGS+T+rpnunT83XMVVfDPIifX+95qBBeVYlgGtO+wOIUHMkvtp2GEPYh4B+f/d7fhuWhDwWFy5PwWkIdbflY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 177735900778547.08278275723819; Mon, 27 Apr 2026 23:50:07 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 3DC303F349; Tue, 28 Apr 2026 02:50:05 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 5CC0841917; Tue, 28 Apr 2026 02:49:16 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id D778C3F2F2; Tue, 28 Apr 2026 02:49:07 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B4E5D3F2D9 for ; Tue, 28 Apr 2026 02:49:04 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-EpCBg6JmMgu5sZZwdiJfRw-1; Tue, 28 Apr 2026 02:49:02 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7B1A51800352 for ; Tue, 28 Apr 2026 06:49:01 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.17]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AAA1F180047F for ; Tue, 28 Apr 2026 06:49:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777358943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=skukaKLQumaAHWenvMw6HcdPMvJ5bxwyKH29IDLnJ+E=; b=Pm+Qf1Q0oMW5uqGq3dLE51dMOg0VhSez+GCsPj1LkWV9fatue13fi9uWnyAB5yr1+4J4SB MJ5YlS3x+JnYIOnME+G8JH/uQJJMUy8p+v1F5TBKspvhuDvcs4oQFeXVdgx3uAKMObMMCg 4wu6WjTXWYiYXRwLXjj9oTNiMBTYHeE= X-MC-Unique: EpCBg6JmMgu5sZZwdiJfRw-1 X-Mimecast-MFC-AGG-ID: EpCBg6JmMgu5sZZwdiJfRw_1777358941 To: devel@lists.libvirt.org Subject: [PATCH] virNetDevOpenvswitchInterfaceStats: Add 'ifname' to error messages Date: Tue, 28 Apr 2026 08:48:59 +0200 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pYONj7bXQdoeKMj_avJe5F_a1LAfQbtmv4f7istgoiE_1777358941 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7OB4SBJXFHLZZPGA6AXW6644R542627H X-Message-ID-Hash: 7OB4SBJXFHLZZPGA6AXW6644R542627H X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1777359010706154100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa Report the interface name which caused the error. Resolves: https://redhat.atlassian.net/browse/RHEL-170993 Signed-off-by: Peter Krempa Reviewed-by: Martin Kletzander --- src/util/virnetdevopenvswitch.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitc= h.c index 868d6d26ba..d6457f35a0 100644 --- a/src/util/virnetdevopenvswitch.c +++ b/src/util/virnetdevopenvswitch.c @@ -403,8 +403,8 @@ virNetDevOpenvswitchInterfaceStats(const char *ifname, STREQ_NULLABLE(output, "")) { /* no ovs-vsctl or interface 'ifname' doesn't exists in ovs */ virReportError(VIR_ERR_INTERNAL_ERROR, - _("Interface not found: %1$s"), - NULLSTR(errbuf)); + _("Interface '%1$s' not found: %2$s"), + ifname, NULLSTR(errbuf)); return -1; } @@ -419,8 +419,9 @@ virNetDevOpenvswitchInterfaceStats(const char *ifname, stats->tx_packets =3D=3D -1 && stats->tx_errs =3D=3D -1 && stats->tx_drop =3D=3D -1) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Interface doesn't have any statistics")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Interface '%1$s' doesn't have any statistics"), + ifname); return -1; } --=20 2.53.0