From nobody Wed Dec 17 08:56:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1744032358; cv=none; d=zohomail.com; s=zohoarc; b=U/6QWE8FT1x6Wcx9d7YJf++PHJiVQblXEoJsQWO7idZwkyJIz7YCZkHj4uY4OgXloOOmIGZdbClOBnT/+JqHLqesifLK0oN2W/7ZlA9GDM1moLvLP6cAqc2hOdbMalOykcLJr+cio/Ab4sz5jilKR2WtJwEXOufm+4csdjjpNvQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1744032358; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=u2SX+dqBN4a8hKutMPBokWngEUkoaIF3NKx0+ridO48=; b=SEqg4TQl3rtzCDXUTsfKd4sRsK2cf0H+lmEucSHezv1/WFlo+XNLoLpk/RQ2SbPBFabhBMDkqDM/BcCysq2qMJQYYyF8maNTKK7/EswPz3l9CVGaNyAm5fYCIiOPCJDTzAJKMa/F4yjjmkmyJR99z86w76FzqhHgCSHYL8dLScA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1744032358079156.00548566980888; Mon, 7 Apr 2025 06:25:58 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 1EC6415CC; Mon, 7 Apr 2025 09:25:57 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id C402F15DC; Mon, 7 Apr 2025 09:24:36 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 5BB5211C8; Mon, 7 Apr 2025 09:24:28 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E2EDF11D5 for ; Mon, 7 Apr 2025 09:24:27 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-356-d50cFJ7sPb2PSG1Yx_uZAw-1; Mon, 07 Apr 2025 09:24:26 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 653E119560BB for ; Mon, 7 Apr 2025 13:24:25 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.22.8]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5F00F1955BC0; Mon, 7 Apr 2025 13:24:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744032267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0KjhfDUSg1JvJ+c36/suJ68TQHEda7OfOiGL53TPSb0=; b=AZ0NIGb8IgrQfFb59lIEbErTf9V8Dov2+75VJRJwnJt8zzIsUgcH/we6GEXdJ5ltbYk2Me d55zSzHoswwyNTNmfbAv0uKGgTCvsvf1C9Xn6lCLovF+izR1Fbywd10A6WcNhj8VsBg1Nd FTx73nMccsfXi95dSNnTxmXyHJAhiso= X-MC-Unique: d50cFJ7sPb2PSG1Yx_uZAw-1 X-Mimecast-MFC-AGG-ID: d50cFJ7sPb2PSG1Yx_uZAw_1744032265 To: devel@lists.libvirt.org Subject: [PATCH 3/5] libvirt-host: Clarify/fix description of the CPU frequency field Date: Mon, 7 Apr 2025 15:24:15 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5F7pjJYVPSzp5-3A7aZ7zt3RlNCsXChFgnVkoHDueMo_1744032265 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ZNSYX5KUQIGXQ47MVAW2VQGIPVID4BVN X-Message-ID-Hash: ZNSYX5KUQIGXQ47MVAW2VQGIPVID4BVN X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Peter Krempa X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1744032359499019100 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The 'virNodeInfo' field for CPU frequency is named 'mhz'. The docs were mentioning 'mHZ', which is neither the field name nor proper spelling of the unit. Reword the paragraph to mention "CPU frequency" instead and explicitly name the field in virNodeInfo struct. Signed-off-by: Peter Krempa --- src/libvirt-host.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libvirt-host.c b/src/libvirt-host.c index 51a1200c44..9845549e36 100644 --- a/src/libvirt-host.c +++ b/src/libvirt-host.c @@ -410,9 +410,9 @@ virConnectGetMaxVcpus(virConnectPtr conn, * Use of this API is strongly discouraged as the information provided * is not guaranteed to be accurate on all hardware platforms. * - * The mHZ value merely reflects the speed that the first CPU in the - * machine is currently running at. This speed may vary across CPUs - * and changes continually as the host OS throttles. + * The CPU frequency value (field 'mhz' in virNodeInfo) merely reflects the + * speed that the first CPU in the machine is currently running at. This s= peed + * may vary across CPUs and changes continually as the host OS throttles. * * The nodes/sockets/cores/threads data is potentially inaccurate as * it assumes a symmetric installation. If one NUMA node has more @@ -420,7 +420,7 @@ virConnectGetMaxVcpus(virConnectPtr conn, * wrong. It is also not able to report about CPU dies. * * Applications are recommended to use the virConnectGetCapabilities() - * call instead, which provides all the information except CPU mHZ, + * call instead, which provides all the information except CPU frequency, * in a more accurate representation. * * Returns 0 in case of success and -1 in case of failure. --=20 2.49.0