From nobody Mon Feb 9 12:29:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1628075033; cv=none; d=zohomail.com; s=zohoarc; b=MvmDD1CYCqMQ02v13xC+J29NjxX2nS0WMI90wt613TS3c/T2mQwX+rwgSFynaxWR4PRGBa602XKgnsuk5xeJKTAL3SHOH/xE/cIxGmtWzn2tEn1JsX2ZhGiUimLvZiCvLWOnP3z+SLPPV1zm5vimjeMT0+w7XdFrPs+AtOM6T8A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628075033; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FnMW2ZrFMrF4jhpvC2tQBIJNB2DjYWl8dSZkWhDS8VY=; b=UP9A8yLn9un9Ct5LFwEolvV7hloZYKw9QDmCBpAgFDOUX5sVtHcLyV5fuvmZ3RzyCT4LVZP875BsMcGMZl3LAGcV3j+GElwFMjr7PIwqg7Ya711qHCGZbQOnvFghQk7PV0GbiRshPGWsuVdYn/bveJFRVDU5zbxoa3DJCPkK9ag= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1628075033232403.3228523493333; Wed, 4 Aug 2021 04:03:53 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-518-MBNE9bX9OGmrU-NQx1T1QQ-1; Wed, 04 Aug 2021 07:03:50 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BEE2910066E5; Wed, 4 Aug 2021 11:03:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9C93160BF4; Wed, 4 Aug 2021 11:03:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6B2D54A71A; Wed, 4 Aug 2021 11:03:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 174B33lr014281 for ; Wed, 4 Aug 2021 07:03:03 -0400 Received: by smtp.corp.redhat.com (Postfix) id B999629671; Wed, 4 Aug 2021 11:03:03 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 10D9717B73 for ; Wed, 4 Aug 2021 11:03:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628075032; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=FnMW2ZrFMrF4jhpvC2tQBIJNB2DjYWl8dSZkWhDS8VY=; b=hBIpDWVOUJgkcPjTAQA/AV0zD/Lla/RdebXOxe0eCcajLKU0EnH4WpHELsb9u2gt9znPaO aca+ifiL0GeEHBA1w0hzlfGzWfkjK06Br4q36aD8DiUs4Pb9JaSXWESn7SzTATG8B4huhq IUTHEFrgdAyP3xEeGre9fCf7OgQoTpU= X-MC-Unique: MBNE9bX9OGmrU-NQx1T1QQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 13/23] qemuDomainAttachDeviceConfig: Remove pointless assignment Date: Wed, 4 Aug 2021 13:02:33 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1628075034576100013 Content-Type: text/plain; charset="utf-8" 'dev->data.rng' is NULLed by VIR_APPEND_ELEMENT Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e53f167575..a7d76dd00f 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7319,8 +7319,6 @@ qemuDomainAttachDeviceConfig(virDomainDef *vmdef, } VIR_APPEND_ELEMENT(vmdef->rngs, vmdef->nrngs, dev->data.rng); - dev->data.rng =3D NULL; - break; case VIR_DOMAIN_DEVICE_MEMORY: --=20 2.31.1