From nobody Fri Dec 12 12:55:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1763971743; cv=none; d=zohomail.com; s=zohoarc; b=luj8d8R1+Ib2mOfGEw+WImB/c6N2tVR2F347uZDt9TssB6hrfHCxFoYmqo8LVsbvVO8Hv1AP1Oz7ITD8Z3FdaKh1vq8dITLwT1z6/YvgMpwlBf2zioZzbTU9M5uUlU7xL+m/ob0/rAXgYS1nyxKg4amgUCf1uPr3xG/jfEOapUE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763971743; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=PY5CYihQYopoLvkvRLGKcTPosGgv23QvvQ03jB5/gtA=; b=es3iyO8+p3/qSmIrjnqF2BtXo2eV+KFDF6KKQ8lI0BkfOOtYHnF5BCVSZ7NQMlOPBpUaLcPgO1rF20kJop7PIRN5uzXlkiY/SEXKV0csiwp2icJp1Q68rOy740UqnefHSqsY5EClu3ZqQad2W3dQpjkqqrOBw5+CTDRfCchAoAs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1763971743094153.3555208889885; Mon, 24 Nov 2025 00:09:03 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 5209844342; Mon, 24 Nov 2025 03:09:02 -0500 (EST) Received: from [172.19.199.65] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 8614944473; Mon, 24 Nov 2025 03:08:16 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 2F6D841B58; Mon, 24 Nov 2025 03:07:34 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 7C01F41C75 for ; Mon, 24 Nov 2025 03:07:32 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-110-2Sh0lhEGPouxYxlo8GBn4A-1; Mon, 24 Nov 2025 03:07:29 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1CDAC1954204 for ; Mon, 24 Nov 2025 08:07:29 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.10]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6170730044E8 for ; Mon, 24 Nov 2025 08:07:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763971652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PY5CYihQYopoLvkvRLGKcTPosGgv23QvvQ03jB5/gtA=; b=TnrM3G3Ta/izeh1EGi7c5kVqc/K+azYy7JjxdRbm+SHVXvWNXz88bxkqDSBfK5S1IhE7lg MCw91JzPSWi6IocBU8naweGArOBMb1KEmCbSGHG5n/ltnlVCxfyYXPW15d2uMfcezmyiWK zgmmjvahSBDalhO/fCAvCNOYu+Afs3U= X-MC-Unique: 2Sh0lhEGPouxYxlo8GBn4A-1 X-Mimecast-MFC-AGG-ID: 2Sh0lhEGPouxYxlo8GBn4A_1763971649 To: devel@lists.libvirt.org Subject: [PATCH] spec: Fix 'obsoletes' for 'libvirt-daemon-driver-storage-zfs' Date: Mon, 24 Nov 2025 09:07:27 +0100 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yaIfelDKuSTEVoWyLlSpdTK1vD1a1GC6DQdps1IYxLo_1763971649 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: UIZQQ2LPDUWXVYG6CNIGW676EA36ZEDV X-Message-ID-Hash: UIZQQ2LPDUWXVYG6CNIGW676EA36ZEDV X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1763971744452019200 Content-Type: text/plain; charset="utf-8" From: Peter Krempa On Fedora 43 and newer the 'fuse-zfs' package was removed. Commit bd30147e740 added an 'Obsoletes' directive so that the storage driver core package will update properly but hardcoded the obsoleted version as 11.4 (when the change was comitted) similarly to the old sheepdog/rbd packages. Unfortunately that doesn't work if the sub-package removal happened based on an external dependancy, rather than complete removal of said module in libvirt. If users have e.g. virt-preview repos enabled they'll get libvirt-11.9 currently installed, but the obsoleted version is just 11.4, thus upgrades to Fedora 43 with virt-preview are broken. Fix this by obsoleting everything up to the current build. Fixes: bd30147e740d49fdb5844160e480ca34611f75e5 Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 8314fbeb34..f1bfd5e652 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -668,7 +668,7 @@ Obsoletes: libvirt-daemon-driver-storage-rbd < 5.2.0 %endif Obsoletes: libvirt-daemon-driver-storage-sheepdog < 8.8.0 %if !%{with_storage_zfs} -Obsoletes: libvirt-daemon-driver-storage-zfs < 11.4.0 +Obsoletes: libvirt-daemon-driver-storage-zfs <=3D %{version}-%{release} %endif %description daemon-driver-storage-core --=20 2.51.1