From nobody Sun Feb 8 21:11:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1642772050; cv=none; d=zohomail.com; s=zohoarc; b=AfKM+UqflL+sVfDCEIRbzdg5sv+I+mtVg6oMisNg+LjSJfklbv75Rm14NiXbQt5MS80RLXvnG9Dl12jCusz3OIraQLFaO2hRrnDELS4n750PdsDX8mzt+4lUDHE3amMkIfJjP7Q1b5w4Ub+MGSu2BW1ant91ijepXxTLTfIL0s4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642772050; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/qj7ZS5omz8JG4tzABl5pAPTeswEKKnHNSaQJl9x8Y4=; b=b/kWIhILV14F2diJIZJ275lIsVz/uPWTNbvS4tfQTd37NcneOJ6iBf0lGLEQrTwq9Ez2EYK6inPLSzOu0v62CQT7tsT+AoAV+lVOfzyTxNvfAY4nYTtK/tZzk1Z/nshwgzMGox40Qg85Lzl1j3RbhtD8FHL9Q3owIUp9ELgcOQM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1642772050443521.6131303814477; Fri, 21 Jan 2022 05:34:10 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-351-0g9zEOlnMCakMOaC031fSQ-1; Fri, 21 Jan 2022 08:34:06 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EFC1D1091DA1; Fri, 21 Jan 2022 13:34:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CB40727BD1; Fri, 21 Jan 2022 13:34:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8A4844A700; Fri, 21 Jan 2022 13:34:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20LDSPtd011932 for ; Fri, 21 Jan 2022 08:28:25 -0500 Received: by smtp.corp.redhat.com (Postfix) id AF8BA1090022; Fri, 21 Jan 2022 13:28:25 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3A71D108F850 for ; Fri, 21 Jan 2022 13:28:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642772049; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/qj7ZS5omz8JG4tzABl5pAPTeswEKKnHNSaQJl9x8Y4=; b=WjmHOmUfQxKmQUDwoUKdXRqLiHdOiOqQix3vFpkPTnRTjQB8z2SRERcV0wKawgAJKjPzCT T59pSRGw6bXL7WN62LCIcKhqybB8vGvdZU/c9b1LcuImC2n1GN6+Lbw17+3WCkVITtFVGl P4qGYrEGz4RhHMkpowiN+R2Yzik/4Ao= X-MC-Unique: 0g9zEOlnMCakMOaC031fSQ-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 01/12] virxml: Extend virXMLPropU{Int, LongLong}() error message Date: Fri, 21 Jan 2022 14:28:08 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1642772051682100001 Content-Type: text/plain; charset="utf-8" In case virXMLPropUInt() or virXMLPropULongLong() meets an attribute with a negative integer the following error message is printed: Invalid value ...: Expected integer value This message is not as good as it could be. Let users know it's a non-negative integer we are expecting. Signed-off-by: Michal Privoznik --- src/util/virxml.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virxml.c b/src/util/virxml.c index 4b09374107..bb1ae3e305 100644 --- a/src/util/virxml.c +++ b/src/util/virxml.c @@ -679,7 +679,7 @@ virXMLPropUInt(xmlNodePtr node, =20 if (ret < 0) { virReportError(VIR_ERR_XML_ERROR, - _("Invalid value for attribute '%s' in element '%s'= : '%s'. Expected integer value"), + _("Invalid value for attribute '%s' in element '%s'= : '%s'. Expected non-negative integer value"), name, node->name, tmp); return -1; } @@ -738,7 +738,7 @@ virXMLPropULongLong(xmlNodePtr node, =20 if (ret < 0) { virReportError(VIR_ERR_XML_ERROR, - _("Invalid value for attribute '%s' in element '%s'= : '%s'. Expected integer value"), + _("Invalid value for attribute '%s' in element '%s'= : '%s'. Expected non-negative integer value"), name, node->name, tmp); return -1; } --=20 2.34.1