From nobody Fri Nov 14 05:58:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 172864438119666.01533546262397; Fri, 11 Oct 2024 03:59:41 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id BD4E312B7; Fri, 11 Oct 2024 06:59:39 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 540011291; Fri, 11 Oct 2024 06:59:19 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id E4CF2C9A; Fri, 11 Oct 2024 06:59:15 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4B80A124F for ; Fri, 11 Oct 2024 06:59:15 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-u_xpyC_1P5aVm-NJLXflJg-1; Fri, 11 Oct 2024 06:59:13 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CD3AF1955BCB for ; Fri, 11 Oct 2024 10:59:12 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.226.0]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DC4931955F54 for ; Fri, 11 Oct 2024 10:59:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728644355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=baBHuhBrcsI8HhVDXoqz36uPq6baH3s34/nHWeWXJuQ=; b=HvYeYgpIkDIV2RVS+PK3IQGo5lY3I/fGsOJ7Lhey6D8Qs1m62aoD9ghSovwElo6mIzOVLk ko6whri9LZxEtyMlNQm6OQ1qx156H9TnRrJm7vh8gHq52SMp1FOIeGi+86C4psdlX24xN2 RLHbjrXJlSiWSNtAdSHmanZf2VkluL8= X-MC-Unique: u_xpyC_1P5aVm-NJLXflJg-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH] Remove pointless bool conversions Date: Fri, 11 Oct 2024 12:59:02 +0200 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: WKLHBFLVDTWA6D6AFKELX5CH2BO2CINS X-Message-ID-Hash: WKLHBFLVDTWA6D6AFKELX5CH2BO2CINS X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1728644381769116600 Content-Type: text/plain; charset="utf-8" Signed-off-by: J=C3=A1n Tomko Reviewed-by: Jiri Denemark --- src/libxl/libxl_domain.c | 2 +- src/lxc/lxc_process.c | 2 +- src/nwfilter/nwfilter_dhcpsnoop.c | 8 ++++---- src/qemu/qemu_process.c | 2 +- tools/virsh-snapshot.c | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 0f129ec69c..c0122eb295 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -855,7 +855,7 @@ libxlDomainCleanup(libxlDriverPrivate *driver, priv->deathW =3D NULL; } =20 - if (!!g_atomic_int_dec_and_test(&driver->nactive) && driver->inhibitCa= llback) + if (g_atomic_int_dec_and_test(&driver->nactive) && driver->inhibitCall= back) driver->inhibitCallback(false, driver->inhibitOpaque); =20 /* Release auto-allocated graphics ports */ diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index 205ab96ebb..dc6f4fc03c 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -203,7 +203,7 @@ static void virLXCProcessCleanup(virLXCDriver *driver, vm->pid =3D 0; vm->def->id =3D -1; =20 - if (!!g_atomic_int_dec_and_test(&driver->nactive) && driver->inhibitCa= llback) + if (g_atomic_int_dec_and_test(&driver->nactive) && driver->inhibitCall= back) driver->inhibitCallback(false, driver->inhibitOpaque); =20 virLXCDomainReAttachHostDevices(driver, vm->def); diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c b/src/nwfilter/nwfilter_dhcp= snoop.c index 26072ec26e..e65dbb93d9 100644 --- a/src/nwfilter/nwfilter_dhcpsnoop.c +++ b/src/nwfilter/nwfilter_dhcpsnoop.c @@ -588,7 +588,7 @@ virNWFilterSnoopReqPut(virNWFilterSnoopReq *req) if (!req) return; =20 - if (!!g_atomic_int_dec_and_test(&req->refctr)) { + if (g_atomic_int_dec_and_test(&req->refctr)) { /* * delete the request: * - if we don't find req on the global list anymore @@ -743,7 +743,7 @@ virNWFilterSnoopReqLeaseDel(virNWFilterSnoopReq *req, skip_instantiate: g_free(ipl); =20 - ignore_value(!!g_atomic_int_dec_and_test(&virNWFilterSnoopState.nLease= s)); + ignore_value(g_atomic_int_dec_and_test(&virNWFilterSnoopState.nLeases)= ); return ret; } =20 @@ -1004,7 +1004,7 @@ static void virNWFilterDHCPDecodeWorker(void *jobdata= , void *opaque) _("Instantiation of rules failed on interface '%1$s= '"), req->binding->portdevname); } - ignore_value(!!g_atomic_int_dec_and_test(job->qCtr)); + ignore_value(g_atomic_int_dec_and_test(job->qCtr)); } =20 /* @@ -1388,7 +1388,7 @@ virNWFilterDHCPSnoopThread(void *req0) pcap_close(pcapConf[i].handle); } =20 - ignore_value(!!g_atomic_int_dec_and_test(&virNWFilterSnoopState.nThrea= ds)); + ignore_value(g_atomic_int_dec_and_test(&virNWFilterSnoopState.nThreads= )); =20 return; } diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index a00066e88e..f85e164c10 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8743,7 +8743,7 @@ void qemuProcessStop(virQEMUDriver *driver, if (priv->eventThread) g_object_unref(g_steal_pointer(&priv->eventThread)); =20 - if (!!g_atomic_int_dec_and_test(&driver->nactive) && driver->inhibitCa= llback) + if (g_atomic_int_dec_and_test(&driver->nactive) && driver->inhibitCall= back) driver->inhibitCallback(false, driver->inhibitOpaque); =20 /* Clear network bandwidth */ diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index 8b6a950a01..e0be8e7582 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -780,8 +780,8 @@ virshSnapshotFilter(vshControl *ctl, virDomainSnapshotP= tr snapshot, return -1; } if (STREQ(state, "disk-snapshot")) { - return !!((flags & VIR_DOMAIN_SNAPSHOT_LIST_DISK_ONLY) && - (flags & VIR_DOMAIN_SNAPSHOT_LIST_EXTERNAL)); + return (flags & VIR_DOMAIN_SNAPSHOT_LIST_DISK_ONLY) && + (flags & VIR_DOMAIN_SNAPSHOT_LIST_EXTERNAL); } =20 if (!(flags & VIR_DOMAIN_SNAPSHOT_LIST_INTERNAL)) --=20 2.47.0