From nobody Mon Feb 2 09:06:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1767944101; cv=none; d=zohomail.com; s=zohoarc; b=dk30kJYq1XnOvBHiC4Un/00GY8p2da0tdqyO8oRYJ8ZducEv8NjoJur6kujXGD+PKxqe/gRXP5oFOKhnjH5a5fMLyz6vdBSoAjJd5/8cQH44Iolt7RZbLWt54PWDzmlP+GPRxL1ee0hY/l0EBItho38YOGor4q7MSJB4IkhbIzI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1767944101; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=qszc3CaHFtMaA1yt6I518S9jBx8LR9M1vWKLslpNSuA=; b=QmAdGIYwVNC1WMNpTo7/og1WiaffmntrzCaFE9x+JQO6Bn/qfATVfmoCuvxkhO/++oB/klTKvM/YGWUA3pt+5xsAsDqWVlkX8TEvK7C3EQdHChc31pqrfVa5JHWwHVkhn70HJdUT3aJO7pyHehZyLCwT52nhXpQXvNtABTc//Ec= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1767944101175655.5299490715429; Thu, 8 Jan 2026 23:35:01 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 335BF43F7C; Fri, 9 Jan 2026 02:35:00 -0500 (EST) Received: from [172.19.199.83] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 6827243EB0; Fri, 9 Jan 2026 02:34:11 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id DF7E943EAA; Fri, 9 Jan 2026 02:34:01 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 21EC343EAE for ; Fri, 9 Jan 2026 02:34:01 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-395--p6SP8RHPgCHgQpixZ-IeQ-1; Fri, 09 Jan 2026 02:33:59 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5B4D219560B7 for ; Fri, 9 Jan 2026 07:33:58 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AE21C30002D1 for ; Fri, 9 Jan 2026 07:33:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767944040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qszc3CaHFtMaA1yt6I518S9jBx8LR9M1vWKLslpNSuA=; b=ItE5ejKssNcptu0g2qsoE385LUVtS3t60RcbVgYBgHnr13ncMzIhQZQDGtqgOxEXyVgzjY 7hGPeHM6eBRuIaakPrgDqioj52gCcvlU5BJn2DGWifg+oHKsGmx6A8T5dTWv4YGWZvgeVU gKOI7+ao6Uiv1VhU1ECE1hLJlh8+1Bg= X-MC-Unique: -p6SP8RHPgCHgQpixZ-IeQ-1 X-Mimecast-MFC-AGG-ID: -p6SP8RHPgCHgQpixZ-IeQ_1767944038 To: devel@lists.libvirt.org Subject: [PATCH 1/3] hyperv: Drop const for resourceType in hypervDomainAttachSerial() Date: Fri, 9 Jan 2026 08:33:50 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PdRAYCIg42L6XZJeS-rECrJIL2IatMCid46kGYWUlMo_1767944038 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: O5SDYWY4C5JH6LWIP36WVYBTG5AJ3PYO X-Message-ID-Hash: O5SDYWY4C5JH6LWIP36WVYBTG5AJ3PYO X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1767944103420158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik The 'resourceType' variable inside of hypervDomainAttachSerial() is declared as both g_autofree and const. This makes no sense. Since the variable is g_strdup_printf()-ed into a couple of lines later, it's not const. Drop that part of variable declaration. Signed-off-by: Michal Privoznik --- src/hyperv/hyperv_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 0c17ef16ec..8dd56f39dc 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@ -974,7 +974,7 @@ hypervDomainAttachSerial(virDomainPtr domain, virDomain= ChrDef *serial) Msvm_ResourceAllocationSettingData *entry =3D NULL; g_autoptr(GHashTable) serialResource =3D NULL; const char *connectionValue =3D NULL; - g_autofree const char *resourceType =3D NULL; + g_autofree char *resourceType =3D NULL; =20 virUUIDFormat(domain->uuid, uuid_string); =20 --=20 2.52.0