From nobody Sat Feb 7 05:49:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1591868639; cv=none; d=zohomail.com; s=zohoarc; b=CykpCqiHGbAUA9SlBifmVzsnewquEYjs/KPAhX7N40BgygYBpbUjNjw6sieEemfvR0z7P9VQ3iQVXS+OOhNEjx82X9hZfgbPxAtp6w6U7YStXh6MnnfK7XnjSvBuE5a5ZqVuH1Ptci2U8YkR+O8yBMYFphwvfknX2azN/h0SKAU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591868639; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VRxr7pPTa2YD1HZEHDrR9CDCdZ4C7O+W5hloNf4ompE=; b=ESqTH1KB1tdNUHbyU7/0+BCfprWdIiQ2UmRmbmqM6FSAd3bCYwB6qFKkVCvFeyAyv3ez9OHz7gwLQo0fRO8KlJNqegv5Pla3ND9VgDL/A+Jo7jmO16xKvIbX9h3QU2IW2GmWulqBefB6w+rGAYO9N6mnhTC5eZeLBVolv/urYpk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1591868639035391.9585804695881; Thu, 11 Jun 2020 02:43:59 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-155-S-cpF3SPP4-ILo-j1w3__g-1; Thu, 11 Jun 2020 05:43:55 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9F4941007271; Thu, 11 Jun 2020 09:43:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5FD7B5C3F8; Thu, 11 Jun 2020 09:43:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0CBDC1809547; Thu, 11 Jun 2020 09:43:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05B9hk52030240 for ; Thu, 11 Jun 2020 05:43:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id 395D17C3B7; Thu, 11 Jun 2020 09:43:46 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.40.208.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id A2DCA78914 for ; Thu, 11 Jun 2020 09:43:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591868637; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=VRxr7pPTa2YD1HZEHDrR9CDCdZ4C7O+W5hloNf4ompE=; b=gqYREbyIZ2PNoHUA7qrNNBJNasGgwCJkVvgtSpIWU9CfPyOVjYq6+Rkh4CTeI80tjp2YNA hWxM5UCgw7uqW9SpxUUVOrS/msHHwE9LbdJMXxrrAw8oC4qrKaREmPgMBDgNDMY5OV4uEf hYdsNqh/P0AtAojykjV8aD3K05KeND4= X-MC-Unique: S-cpF3SPP4-ILo-j1w3__g-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 2/7] testVirFindSCSIHostByPCI: Remove unused 'path_addr' Date: Thu, 11 Jun 2020 11:43:34 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The path is formatted but then just freed without any use. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- tests/scsihosttest.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tests/scsihosttest.c b/tests/scsihosttest.c index b58318d295..4b2779eabf 100644 --- a/tests/scsihosttest.c +++ b/tests/scsihosttest.c @@ -202,12 +202,9 @@ testVirFindSCSIHostByPCI(const void *data G_GNUC_UNUSE= D) unsigned int unique_id2 =3D 2; const char *pci_addr1 =3D "0000:00:1f.1"; const char *pci_addr2 =3D "0000:00:1f.2"; - char *path_addr =3D NULL; char *ret_host =3D NULL; int ret =3D -1; - path_addr =3D g_strdup_printf("%s/%s", abs_srcdir, "sysfs/class/scsi_h= ost"); - if (!(ret_host =3D virSCSIHostFindByPCI(TEST_SCSIHOST_CLASS_PATH, pci_addr1, unique_id1)) || STRNEQ(ret_host, "host0")) @@ -236,7 +233,6 @@ testVirFindSCSIHostByPCI(const void *data G_GNUC_UNUSED) cleanup: VIR_FREE(ret_host); - VIR_FREE(path_addr); return ret; } --=20 2.26.2