From nobody Thu Apr 25 22:53:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1574778720; cv=none; d=zohomail.com; s=zohoarc; b=m/J6LKQQfuPEn3OIteCKW8UZVpXQt1E7Et4wdcZ/cgcoInWMY/m+IQMXpckXELXJ5hNPNF7/hRo8X16ZtWoIZVKI+svS3b40oxVXOAzCXyeo+vsuo0UtdP7VBAWLAkUDYPmQHWEOqvevbC6ldWt4OtoERho7oAvABYyDBNZmKxU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1574778720; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=EiDhwRzBvab69O3xJMNJZQmkfy5Ahq+u1cq5zeAyMfg=; b=d2JaVz9Xm/l0ai7tfEIPnksHg7K26l9Wz8rOeKOgnOcRzgK6gWfH4lfKVPkt1J/0zRLLvmgnvJ151o0KSZzLsmJ9X5dbqS/ot5y+R0TjvTBz29sM8NIQyVK+2ybK9gGqskFqlAVwoyTjR4l6Tp4xZygELCmGFoU6VUaY8b4LbAs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1574778720186728.8605144029838; Tue, 26 Nov 2019 06:32:00 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-148-hyJI6tEWMpa6HPaoVOS8OQ-1; Tue, 26 Nov 2019 09:31:56 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 13D208D2DC7; Tue, 26 Nov 2019 14:31:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E3D5C608E2; Tue, 26 Nov 2019 14:31:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A7DB71832E25; Tue, 26 Nov 2019 14:31:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xAQEVi8r008732 for ; Tue, 26 Nov 2019 09:31:44 -0500 Received: by smtp.corp.redhat.com (Postfix) id 0F29C600CA; Tue, 26 Nov 2019 14:31:44 +0000 (UTC) Received: from moe.redhat.com (unknown [10.43.2.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5B76A600C8 for ; Tue, 26 Nov 2019 14:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574778719; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=EiDhwRzBvab69O3xJMNJZQmkfy5Ahq+u1cq5zeAyMfg=; b=dQKkvkR21RqPO0gmlY4/rPIPn5766c7+QV5VEXBSNlFOfxA8PbPIYUKQZOSzgUOFyP+o+1 DaYd9HoBbfZZ2R/2TBjWIhwHwVF8u0bX3alPLgmcXkKtwXj/3y3A4dBZOENKmsREwjFjcP ASdrFzzlWo8I991Y5p/rzYpZ7gYAvyo= From: Michal Privoznik To: libvir-list@redhat.com Date: Tue, 26 Nov 2019 15:31:37 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] all: don't wait for driver lock during startup X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: hyJI6tEWMpa6HPaoVOS8OQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" There are two daemons that wait for acquiring their pid files: virtnetworkd and virtstoraged. This is undesirable as the idea is to quit early if unable to acquire the pid file. This was missed in v5.6.0-rc1~207. Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: J=C3=A1n Tomko --- src/network/bridge_driver.c | 2 +- src/storage/storage_driver.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 07dba8cfe4..e360645969 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -761,7 +761,7 @@ networkStateInitialize(bool privileged, =20 if ((network_driver->lockFD =3D virPidFileAcquire(network_driver->stateDir, "driver", - true, getpid())) < 0) + false, getpid())) < 0) goto error; =20 /* if this fails now, it will be retried later with dnsmasqCapsRefresh= () */ diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index d8355d3c3c..580a5e6f15 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -296,7 +296,7 @@ storageStateInitialize(bool privileged, =20 if ((driver->lockFD =3D virPidFileAcquire(driver->stateDir, "driver", - true, getpid())) < 0) + false, getpid())) < 0) goto error; =20 if (virStoragePoolObjLoadAllState(driver->pools, --=20 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list