From nobody Sun Feb 8 21:48:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576658262; cv=none; d=zohomail.com; s=zohoarc; b=mUG7gaYGRGKS285d13NQThU2exmgx/I73bomrxJubBBq7vY4B52tWB5yg7Pq9nXG1C7OMPcUvQ1+3p/+XkKnzwoXe/G/IUwT2OmoVnKhvEdyyNoeBohuIEXBB27iRVyukYNxz7RXbOZJlU2cIe0eAaL/1i55rHYb9Fdex+ssdGI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576658262; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yO32G3NXME1RWL8VZijTi9oKetAYA5qwGtfIvm0IH0c=; b=h+oxCTwNsMCjEgqh4reOYEk9acwNIitxZ6Si9aS0n1dzmYcebX55O+8j+pZD4VbHdIjJIbdw7L49Y43Rx4tZQeF1PAWqc5TLBTyMSxJz/RJcpKp/194gNpyK8mABxH+3zg7HPAOqRiJZoMWxQElCPeOlaVvneW8qqYwt2tckbDg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1576658262985154.72895812084573; Wed, 18 Dec 2019 00:37:42 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-294-i2p8FlqKOASy0030nxIlIA-1; Wed, 18 Dec 2019 03:37:40 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 27B7C100550E; Wed, 18 Dec 2019 08:37:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 00BE05D9E5; Wed, 18 Dec 2019 08:37:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B1126827D0; Wed, 18 Dec 2019 08:37:34 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id xBI8bFuf026772 for ; Wed, 18 Dec 2019 03:37:15 -0500 Received: by smtp.corp.redhat.com (Postfix) id E478660C81; Wed, 18 Dec 2019 08:37:15 +0000 (UTC) Received: from localhost.localdomain (ovpn-204-155.brq.redhat.com [10.40.204.155]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6500B60C18 for ; Wed, 18 Dec 2019 08:37:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576658261; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=yO32G3NXME1RWL8VZijTi9oKetAYA5qwGtfIvm0IH0c=; b=g2kMNXC8VA3WtqZH1qsUga19GicmsCb6jj1NMk9mIpUSojUaxiswNhwm5bQgE2FWPq7AMV z2EaoKQMFa0c748f4boHjRJIuIG3jhqlz5LutqM08MEFsYIy+wv5hCch0cq05siNlPynEB nJNZ5FWvNfG29oEVOFcPYOnJF2mNwy0= From: Michal Privoznik To: libvir-list@redhat.com Date: Wed, 18 Dec 2019 09:37:06 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/5] virCapabilitiesHostNUMAUnref: Accept NULL X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: i2p8FlqKOASy0030nxIlIA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Fortunately, this is not causing any problems now because glib does this check for us when calling this function via attribute cleanup. But in future commit we will explicitly call this function over a struct member that might be NULL. Signed-off-by: Michal Privoznik --- src/conf/capabilities.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c index 4fac59e6f7..a782d92956 100644 --- a/src/conf/capabilities.c +++ b/src/conf/capabilities.c @@ -184,6 +184,9 @@ virCapabilitiesFreeStoragePool(virCapsStoragePoolPtr po= ol) void virCapabilitiesHostNUMAUnref(virCapsHostNUMAPtr caps) { + if (!caps) + return; + if (g_atomic_int_dec_and_test(&caps->refs)) { g_ptr_array_unref(caps->cells); =20 --=20 2.24.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list