From nobody Sun Feb 8 23:26:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1642528504; cv=none; d=zohomail.com; s=zohoarc; b=a0Oa3Fv+twpU5yqpY/+6/pqLl/X+N9xAat3XIDJ4YIMxMNd+H5V2yLuQAirQ5YBBMXEjvR9guqMzdKUr9LjIRi1lqOqMsoGpFedwI3XoQSerQ7Jc13qWl69cIWtKLWRQtwQoxXcMdTFgaFg57oCn2eAI8++YD87s7AdW+09A9YU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642528504; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5i0zLX6o8Jg8rDh5SfOBooxSqKMNiU8Gy0/Tc2wO+r4=; b=mPYZ98AwgXVRxqVXYgU5JXHWPvgDsM8aEQ+fOHIlXMuqJLgqWbfzI2NKikm6u9gmDwEsUL7GmP5JIEZbfpgbmJoBGn8MbUgf+ABeTnDMrqiyVAM/z2eeCCWtl6VAcHCEWrz7UTlga8oPAbgJAAHSfbCvkumunORqbdvKT15edic= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1642528504876873.4889868672785; Tue, 18 Jan 2022 09:55:04 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-483--pql-aZ5MYqsSIh570DVYQ-1; Tue, 18 Jan 2022 12:54:54 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 19EFC84DA4E; Tue, 18 Jan 2022 17:48:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E5CE37A552; Tue, 18 Jan 2022 17:48:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 841CC4A70A; Tue, 18 Jan 2022 17:48:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20IG5ODj030692 for ; Tue, 18 Jan 2022 11:05:24 -0500 Received: by smtp.corp.redhat.com (Postfix) id D0854B18AD; Tue, 18 Jan 2022 16:05:24 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 28CA0B18A7 for ; Tue, 18 Jan 2022 16:05:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642528503; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=5i0zLX6o8Jg8rDh5SfOBooxSqKMNiU8Gy0/Tc2wO+r4=; b=hQ7RZEGwZIvA1LzJ0MAnA1jNh+mHocRveAvnozstM/Cpo6tUYXr7S8v5Ew6pa7IF6TR6Hr CgyFJM+pvO+yK52OxVsY6DqSR+ioByagB5BsOZczsk0By8iLvm22qk8qgLWdeSaBe2+T7R PqLEm9QECqVXiIaCkaW3Gwdg7k9GaQk= X-MC-Unique: -pql-aZ5MYqsSIh570DVYQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 5/5] qemuValidateDomainDeviceDefVideo: Reject non-default video head count for devices not supporting it Date: Tue, 18 Jan 2022 17:04:56 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1642528505993100001 Content-Type: text/plain; charset="utf-8" Only QXL and virtio-vga actually propagate the 'heads' attribute as 'max_outputs' to the commandline of qemu. Reject the setting when non-default value is used for any other video type. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=3D2036300 Signed-off-by: Peter Krempa --- src/qemu/qemu_validate.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 5b2af94890..4fb4a8a536 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -2480,6 +2480,13 @@ qemuValidateDomainDeviceDefVideo(const virDomainVide= oDef *video, virDomainVideoTypeToString(video->type)); return -1; } + + if (video->heads !=3D 1) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("video type '%s' doesn't support multiple 'he= ads'"), + virDomainVideoTypeToString(video->type)); + return -1; + } } if (video->accel && video->accel->accel2d =3D=3D VIR_TRISTATE_SWITCH_O= N) { --=20 2.34.1