From nobody Wed May 15 11:31:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1609848220; cv=none; d=zohomail.com; s=zohoarc; b=K0+UpLBmGOJZHVFQdx762KePKopDplKRzg1vQ4Nrs5SHSxXY0wv6QxfaPpyjelWY9diOnNLcbarY/RNGGUmchcT01tpFGiiXm0j0y5h6CLAOnwb5SIq6Dl92XZjMY96aEl6X8bWbTd0geEGJqBfed4oNdYRDxGSIIue7YezXNjs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609848220; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=0joBjmZX9wy+HwQLquYCQDTz/8gz8jLeuj05OtV7Izs=; b=AtYGhP8kDc5s6aTuL2pRi3jCeTVYeCM3pCYktk7EouiYVS5GCXf39OuhQeBljd8e0LKfp718Ps5SSZECX+af0sfc1KF9BuybLW495Lu7x0jkL+tVInxq5gfa1EFzGIT5LP+weF6czAEJIUAY51+0W/m4T9y+qOhtMtw10pKmD4w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1609848220651630.3114802186801; Tue, 5 Jan 2021 04:03:40 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194-PrXc65mwOmKH3Zkg4kCdXA-1; Tue, 05 Jan 2021 07:03:37 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3EDEA107ACE4; Tue, 5 Jan 2021 12:03:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CCB436086F; Tue, 5 Jan 2021 12:03:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 105B64A7C6; Tue, 5 Jan 2021 12:03:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 105C3TKm027920 for ; Tue, 5 Jan 2021 07:03:29 -0500 Received: by smtp.corp.redhat.com (Postfix) id 8FEF45D6CF; Tue, 5 Jan 2021 12:03:29 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 112BC5D735 for ; Tue, 5 Jan 2021 12:03:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609848219; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=0joBjmZX9wy+HwQLquYCQDTz/8gz8jLeuj05OtV7Izs=; b=cre3Nx4OP1gmcjXykKXU3O24bE545jXxDXrUI+dk3jhUmam86wmmBYJiOxcERy50aQN3ca NesA8dxNYZAMuvil3RM95AjRWeS9K/Ra3ZDtIgWJBLtdPfVbTvby6XRmBmgxgrGruKtEdk 1ZT1txk8iJtAksQEuMOE/8azbI6xjrk= X-MC-Unique: PrXc65mwOmKH3Zkg4kCdXA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] networkGetDHCPLeases: Don't assign @ipdef_tmp twice Date: Tue, 5 Jan 2021 13:03:23 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" When rewriting the function, I've mistakenly declared a variable and assigned it to itself. Let's initialize the variable properly. Fixes: 5fb6d98c881c42ab41ca72060217b846949a438f Signed-off-by: Michal Privoznik --- Pushed as trivial. src/network/bridge_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 22d7d330a3..a7c5aade14 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -4155,7 +4155,7 @@ networkGetDHCPLeases(virNetworkPtr net, =20 /* Obtain prefix */ for (j =3D 0; j < def->nips; j++) { - virNetworkIPDefPtr ipdef_tmp =3D ipdef_tmp =3D &def->ips[j= ]; + virNetworkIPDefPtr ipdef_tmp =3D &def->ips[j]; =20 if (ipv6 && VIR_SOCKET_ADDR_IS_FAMILY(&ipdef_tmp->address, AF_INET6)) { --=20 2.26.2