From nobody Sun Feb 8 18:44:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1667896237; cv=none; d=zohomail.com; s=zohoarc; b=FEBX4b9wemAeib+y042unZXOobXxczhV5oZsgcSMk344zJ8NBEwWCMdPRJzmn3o1z0bGppt8PAawoXOV8a+PtUAahBFfUyTDYTi7kY+GGPM297guxD9b5YLAMNtguX+tEqc5SMI64IXP40HXIuHs8od3oHMWTr118dbiMhSq308= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1667896237; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GrHE48+bAvwCfnmmQuN48uE5oFYkcM8JPKAWvb9hrjo=; b=V+zNNnWVuMzi6e961A3pAVZVPAU+qifPPfXmW0TPhuqkpqiAEQugFcgwUhf1AMNadiz9Ogf/2VFFnUfIav7SD6zeZgv4UTLXqregEDbBwhzQX6HRivcvjRuCkzsqnaT2bnCLVGKPh0L6AA+GQ6IRsWMSlCfs7ZY5iTjHuJrJnDQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1667896237376138.89081161403794; Tue, 8 Nov 2022 00:30:37 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-609-AW2Xs9MePiOPQm4pFvT0fw-1; Tue, 08 Nov 2022 03:30:28 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CF1F5857D1A; Tue, 8 Nov 2022 08:30:22 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id BBDE34B3FC8; Tue, 8 Nov 2022 08:30:22 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8989A1946A52; Tue, 8 Nov 2022 08:30:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 988D019465B1 for ; Tue, 8 Nov 2022 08:30:17 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 8459110197; Tue, 8 Nov 2022 08:30:17 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2874235429 for ; Tue, 8 Nov 2022 08:30:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667896236; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=GrHE48+bAvwCfnmmQuN48uE5oFYkcM8JPKAWvb9hrjo=; b=iIBIeOhkUdIN0F4mvQ+HCl60LvZOYK+5Y8TJrQ3aEDgLANeBQIk2yJS9aIHtOK0pC74f/3 a5yfR3Yoh9URcZXs8upgRt5E+hmakr3PqUBhQ4Bg7+fpJqTW+yvmX80aw1MCaKFUtU/C4Y Fl7ykPYNsXlM9YSA8l2TPxsn+NyGgb4= X-MC-Unique: AW2Xs9MePiOPQm4pFvT0fw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 40/48] qemu: Assume QEMU_CAPS_VIRTIO_BLK_NUM_QUEUES Date: Tue, 8 Nov 2022 09:29:42 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1667896238908100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Introduced in QEMU's commit of v2.7.0-rc0~83^2 the .num-queues attribute of virtio-blk device is always available for all QEMU versions we support (4.2.0, currently). Therefore, we can assume the capability is always set and thus doesn't need to be checked for. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_validate.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 243ec29c71..4a01fe4d14 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -2977,13 +2977,6 @@ qemuValidateDomainDeviceDefDiskFrontend(const virDom= ainDiskDef *disk, break; =20 case VIR_DOMAIN_DISK_BUS_VIRTIO: - if (disk->queues && - !virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_BLK_NUM_QUEUES)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("num-queues property isn't supported by this " - "QEMU binary")); - return -1; - } if (disk->queue_size > 0 && !virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_BLK_QUEUE_SIZE)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", --=20 2.37.4