From nobody Sun Feb 8 19:39:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1636993626; cv=none; d=zohomail.com; s=zohoarc; b=QCCS1xRUA+PP1IoXh+zMbtt51XITFxXh+3w5SwxQ4Io1obGfm0JsREDTmYR3rSIRmNzqJEcR7MdrbvWzn+/dgIFj1Rz49yLJe/bb2ZselIu78YyunmFqIqM2kt7eMzkLdYAHadnx6gQTaMjMwsOA+1PfMUySvt5kn6r7UOr5rR0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636993626; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2fB8vypwdnPBSrJFoGROTwIVS6S83vW0Am+QISxsFNc=; b=fIBQkWAffqymFkJ5CBHsqEyzDxlkrIXvxTmzCDlzIVZHsj/A0wXa+UHGY3zfjYUaFnaopkuKpQXCpOW7Z8a2/ZJIyGFqgrT4LHYZ0wilC7ilZPQsiszLnX/LSCBQ+wzhp0KpUSNBRedaC0NdRjBTa5Mq8i2IWhbvyzR9ADSvux0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1636993626279856.9758009209341; Mon, 15 Nov 2021 08:27:06 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-469-_mXOpHcmMKedSJS4W3ZymQ-1; Mon, 15 Nov 2021 11:24:11 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E316519253F4; Mon, 15 Nov 2021 16:24:04 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 674235C1A1; Mon, 15 Nov 2021 16:24:04 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 35B0E1832DDA; Mon, 15 Nov 2021 16:24:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1AFGNCdr028254 for ; Mon, 15 Nov 2021 11:23:12 -0500 Received: by smtp.corp.redhat.com (Postfix) id DA37E197FC; Mon, 15 Nov 2021 16:23:12 +0000 (UTC) Received: from antique-work.redhat.com (unknown [10.40.194.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5613119EF9 for ; Mon, 15 Nov 2021 16:23:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636993452; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=2fB8vypwdnPBSrJFoGROTwIVS6S83vW0Am+QISxsFNc=; b=E3hhERlaqI/SM+FCiSoWoU2Ii77Gfc4JtAXDy7YZH/dnjBDxwcTsjPzH01Ut2zhx1R7swk TU4AZHOUohSOuI+6CNKFQ6mtuOm8sfDo5KnYZ9mo4MneK/jzPdIQNupqA824ygBYj/5EfL V/oS2u+/QOj3u2CyLpT5TU11sAnaTvI= X-MC-Unique: _mXOpHcmMKedSJS4W3ZymQ-1 From: Pavel Hrdina To: libvir-list@redhat.com Subject: [libvirt PATCH 07/11] test: snapshot revert: always emulate VM process stop Date: Mon, 15 Nov 2021 17:22:50 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1636993628201100001 Content-Type: text/plain; charset="utf-8" Reflect the same change in test driver as in QEMU driver because the compatibility check code isn't perfect. Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/test/test_driver.c | 29 +++++++---------------------- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2fa78a15d6..0da8a2ea0f 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -9077,28 +9077,13 @@ testDomainRevertToSnapshot(virDomainSnapshotPtr sna= pshot, =20 if (virDomainObjIsActive(vm)) { /* Transitions 5, 6, 8, 9 */ - /* Check for ABI compatibility. */ - if (!virDomainDefCheckABIStability(vm->def, config, - privconn->xmlopt)) { - virErrorPtr err =3D virGetLastError(); - - if (!(flags & VIR_DOMAIN_SNAPSHOT_REVERT_FORCE)) { - /* Re-spawn error using correct category. */ - if (err->code =3D=3D VIR_ERR_CONFIG_UNSUPPORTED) - virReportError(VIR_ERR_SNAPSHOT_REVERT_RISKY, "%s", - err->str2); - goto cleanup; - } - - virResetError(err); - testDomainShutdownState(snapshot->domain, vm, - VIR_DOMAIN_SHUTOFF_FROM_SNAPSHOT); - event =3D virDomainEventLifecycleNewFromObj(vm, - VIR_DOMAIN_EVENT_STOPPED, - VIR_DOMAIN_EVENT_STOPPED_FROM_SNAPSHOT); - virObjectEventStateQueue(privconn->eventState, event); - goto load; - } + testDomainShutdownState(snapshot->domain, vm, + VIR_DOMAIN_SHUTOFF_FROM_SNAPSHOT); + event =3D virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_STO= PPED, + VIR_DOMAIN_EVENT_STO= PPED_FROM_SNAPSHOT); + virObjectEventStateQueue(privconn->eventState, event); + goto load; =20 if (virDomainObjGetState(vm, NULL) =3D=3D VIR_DOMAIN_RUNNING) { /* Transitions 5, 6 */ --=20 2.31.1