From nobody Mon Feb 9 11:47:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679392824; cv=none; d=zohomail.com; s=zohoarc; b=HYC2vsEb1iQesfgzijddPl7PkkuX6walpW7usHLPg6tKmHz9UTal9tzG4Wfoe8lnjq5ueZQ4ji7MUKo2Qw7zVVwz9k2RONrjkwIyGqYuD0Ecuo9nymyv24TYip6s6n0pVf0Padzof7nUOYEU7X18slP2r0KRxqU1JJTFBEPF7Sc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679392824; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=q8uZrA69besqGXvcNomdExNYDULwf1/MwC1dh7LPSrw=; b=aEscU8spBG6fI4mQsF/DgbgElpaBOia7XSzk4kH6OjMIiHt0tWiVzusZy/BfGli3uyLkpbCUTU2LULzx6rzaxd3mhqmT87gYWsz5TwPZS5c2pyOMSJyIO8QIjFaj3FWh2PCMe8bf0A+bFE4ovMVnTE+UW5viCl7Zkh1nfbbXGQM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1679392824678517.5103054426334; Tue, 21 Mar 2023 03:00:24 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-310-DIajYCnCPhSu75sgKY8fbA-1; Tue, 21 Mar 2023 06:00:22 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 327F7101A550; Tue, 21 Mar 2023 10:00:20 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9355D40C20FA; Tue, 21 Mar 2023 10:00:19 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7882919465A2; Tue, 21 Mar 2023 10:00:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B85A01946594 for ; Tue, 21 Mar 2023 10:00:18 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 9945C40C83B6; Tue, 21 Mar 2023 10:00:18 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4038A40C83A9 for ; Tue, 21 Mar 2023 10:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679392823; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=q8uZrA69besqGXvcNomdExNYDULwf1/MwC1dh7LPSrw=; b=IpjokgnzM+lXVNqR3tlDvDXiS4pu4Foa8E0tLQ/m0ehWXN2DEhzPXG2w4tsffk+IUS5bDD oiASYSZaHhdzfnH1jLwYQNVSh/Hj/UJVD4YcvsnlbvYk1hSzix68FvWlpswfwlZrmuM2FX ySmwZylbsgoZVTqL9/IezTNl2G3LVH0= X-MC-Unique: DIajYCnCPhSu75sgKY8fbA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v2] meson: Stop detecting -Wl,--version-script= Date: Tue, 21 Mar 2023 11:00:16 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679392826905100001 Content-Type: text/plain; charset="utf-8"; x-default="true" With its version 16.0, the LLVM's linker turned on --no-undefined-version by default [1]. This breaks how we detect --version-script=3D detection, because at the compile time there's no library built yet that we can use to make --version-script=3D happy. Unfortunately, meson does not provide a way to detect this either [2]. But there's not much sense in detecting the argument either. We already special case some systems (windows, darwin) and do the check for others, which are expected to support versioned symbols, because of ELF. Worst case scenario - the error is reported during compile time rather than configure time. 1: https://reviews.llvm.org/D135402 2: https://github.com/mesonbuild/meson/issues/3047 Resolves: https://bugs.gentoo.org/902211 Signed-off-by: Michal Privoznik Reviewed-by: Daniel P. Berrang=C3=A9 --- v2 of: https://listman.redhat.com/archives/libvir-list/2023-March/238923.html diff to v1: - Instead of fixing the detection, drop it completely. meson.build | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/meson.build b/meson.build index c35823a79a..a0682e8d0b 100644 --- a/meson.build +++ b/meson.build @@ -534,12 +534,7 @@ elif host_machine.system() =3D=3D 'darwin' # macOS libraries don't support symbol versioning version_script_flags =3D '' else - test_file =3D '@0@/src/libvirt_qemu.syms'.format(meson.project_source_ro= ot()) - if cc.has_link_argument('-Wl,--version-script=3D@0@'.format(test_file)) - version_script_flags =3D '-Wl,--version-script=3D' - else - error('No supported version script link argument found.') - endif + version_script_flags =3D '-Wl,--version-script=3D' endif =20 libvirt_flat_namespace =3D [] --=20 2.39.2