From nobody Sun Feb 8 18:09:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1635945321; cv=none; d=zohomail.com; s=zohoarc; b=eWOcugokEMBOvdE+XbLSHi9Y40yFxsYebMiwx1vxzNZxbEx2DG7F3MEAtiUVljR7+yz5f811OK0eldCUOJ1L+n6s00SqnLYaeVoDFaD1Q9FQ5PBOXzN23n8/dpfBuT78WbAgcLskRRcUOgNFFiZhWwn5pZt5bkFz+JttmQVUunA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635945321; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/Lu1IurT+rtnbonP60Yby4vLQKKLuc2hB1/rrSpxY/w=; b=XcuY4txR0RemfWGSAmWSZlFBj0woFvnv8tHG+Y11Ya9qXbah2j/F6qupybXmUCw6GntfiYdjH5gMCB3tdz39p/l7AGfi6OxTKz2YmuBw9cAE4tOT437d7VWR36i9FlhFGkV8AC7D8Itld4SjxlYCUGhdGKYPNkQKY4aia/DHqm4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1635945321206803.4872208151571; Wed, 3 Nov 2021 06:15:21 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-37-cvZMijpxMnqBddERS4g9WQ-1; Wed, 03 Nov 2021 09:15:18 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 67DC58042E0; Wed, 3 Nov 2021 13:15:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B06B6784E; Wed, 3 Nov 2021 13:15:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 19BBA1818480; Wed, 3 Nov 2021 13:15:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1A3D9N62024969 for ; Wed, 3 Nov 2021 09:09:23 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5F28970886; Wed, 3 Nov 2021 13:09:23 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE3047086D for ; Wed, 3 Nov 2021 13:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635945320; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/Lu1IurT+rtnbonP60Yby4vLQKKLuc2hB1/rrSpxY/w=; b=S12sJcgJhKgnj3jgeL1nxksbjyzUCSW52yClu6cihbNjKd2RqGFsqtG1DQbvP00/xBNddg vAvi6xxBg9TnNheALv5SKHURUU+NHoF3VjI5EGrulfBMS94s7EKayL0kGkboWa6n+UNTVg 4qtIC7J/880NMiRVf0XQULmlRLAul6Y= X-MC-Unique: cvZMijpxMnqBddERS4g9WQ-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 1/3] remote: warn on low SSF Date: Wed, 3 Nov 2021 14:09:14 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1635945323381100001 Prepare for deprecating old kerberos ciphers by warning users with a SSF lower than 112. Signed-off-by: J=C3=A1n Tomko --- src/remote/remote_driver.c | 5 +++++ src/remote/remote_driver.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 719fcf4297..c0bb44b2cd 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -4186,6 +4186,11 @@ remoteAuthSASL(virConnectPtr conn, struct private_da= ta *priv, _("negotiation SSF %d was not strong enough"), = ssf); goto cleanup; } + if (ssf < SSF_WARNING_LEVEL) { + VIR_WARN("negotiation SSF %d lower than %d will be deprecated.= " + "Please upgrade your ciphers.", + ssf, SSF_WARNING_LEVEL); + } priv->is_secure =3D 1; } =20 diff --git a/src/remote/remote_driver.h b/src/remote/remote_driver.h index 1fab5a6cc4..5e9b04da63 100644 --- a/src/remote/remote_driver.h +++ b/src/remote/remote_driver.h @@ -39,3 +39,5 @@ unsigned long remoteVersion(void); #define LIBVIRT_CLIENTCERT LIBVIRT_PKI_DIR "/libvirt/clientcert.pem" #define LIBVIRT_SERVERKEY LIBVIRT_PKI_DIR "/libvirt/private/serverkey.pem" #define LIBVIRT_SERVERCERT LIBVIRT_PKI_DIR "/libvirt/servercert.pem" + +#define SSF_WARNING_LEVEL 112 --=20 2.31.1