From nobody Sun Feb 8 12:58:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561473211; cv=none; d=zoho.com; s=zohoarc; b=HOG693/P4dWqwX8Jp27YM1aSfYUGI9lJboJ+ubYtp0fbbFc2miPuWZ32moh6YanPdTTaoCyreZcI+p2P+ACPgXWjnmnWKVWMf9sm0Bj8GK6eMiUW6IAFpneHyxugvf54yZVqs+xLhMOUlG9nJ4aZ6BDFMQEeep1Hy4rn8bOg+rc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561473211; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=YOpSAcFSBSAl6RKLTOfOTPwHoYRFxgGkJoinZtv/fps=; b=Q/qlvCM1A0MjduSY1AI0ZDPd6tOWl5yCjX2UUiMiF24K07sfWS089e6Gf7CFe+yNUaeaGBXreCsOXfWmGcHiGkv1xaF5PxDjOTKVFKi0fLBosYh/RkESDuk49nNQCNc16GD/G7kveI7u6TQbVfrC9jjOs4GLdJZuKEL5mLB3988= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 15614732117891017.695358872322; Tue, 25 Jun 2019 07:33:31 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 920E130F1BC4; Tue, 25 Jun 2019 14:33:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1EF1019936; Tue, 25 Jun 2019 14:33:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F1A9F1806B19; Tue, 25 Jun 2019 14:33:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5PEUllA005477 for ; Tue, 25 Jun 2019 10:30:47 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5528919732; Tue, 25 Jun 2019 14:30:47 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id D2F87196E5 for ; Tue, 25 Jun 2019 14:30:46 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Tue, 25 Jun 2019 16:30:31 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 2/4] qemu: command: Use 'actualType' when deciding whether to use disk format X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Tue, 25 Jun 2019 14:33:30 +0000 (UTC) Content-Type: text/plain; charset="utf-8" qemuBuildDriveSourceStr omits the disk format string when we are emulating a 'fat' filesystem froma directory. The logic should decide based on the 'actualType' as a disk type=3Dpool may be converted to a directory. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index b767a1e15f..c04bba4f02 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1730,7 +1730,7 @@ qemuBuildDriveSourceStr(virDomainDiskDefPtr disk, } if (disk->src->format > 0 && - disk->src->type !=3D VIR_STORAGE_TYPE_DIR) { + actualType !=3D VIR_STORAGE_TYPE_DIR) { const char *qemuformat =3D virStorageFileFormatTypeToString(disk->= src->format); if (rawluks) qemuformat =3D "luks"; --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list