From nobody Sun Feb 8 22:35:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582637170; cv=none; d=zohomail.com; s=zohoarc; b=RXkDJyk5CxGrkNwaBfr12Nx74ToWpsOij9p83IjoJAaaRjvlqGvoHwSbnG8Ovcej2o/rv5W9enxLwpygqvTHthnxOt1B38tGoP7owDLQrHsn4VdSdVVRAQDNo30RCZdajtb1RwR8jxtcjQnNPGmF/ckiiTBizGZEljTGJRUi2JY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582637170; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FkhRO6B/VBtKvIaIueI9l7/Bcgy17Nfm5P+d9F4ThJg=; b=O0VMH2faSeJ+iCgkQjZb1GOOPnmkSDBCjT/ah891z6F7pqiPNd+PqA8YKCqHaOLE3wDJeHnQb2KRJFAgT3FAzOF8L0H4jny/LrMFj8ZDxaQpQ2F/Z7n28JgURuG4YEFoO17LEZ6jsD81GSsAXiwDRD2c474v9ikeBoxXuhs6//k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 158263717018486.22823244433778; Tue, 25 Feb 2020 05:26:10 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-353-TRIyLUyVOb2P93TBbRDySA-1; Tue, 25 Feb 2020 08:26:03 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F38EF800D54; Tue, 25 Feb 2020 13:25:52 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C58365D9CD; Tue, 25 Feb 2020 13:25:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7F3661832962; Tue, 25 Feb 2020 13:25:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 01PDPovH008822 for ; Tue, 25 Feb 2020 08:25:50 -0500 Received: by smtp.corp.redhat.com (Postfix) id 64F1888859; Tue, 25 Feb 2020 13:25:50 +0000 (UTC) Received: from angien.redhat.com (unknown [10.43.2.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE5566031E for ; Tue, 25 Feb 2020 13:25:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582637168; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=FkhRO6B/VBtKvIaIueI9l7/Bcgy17Nfm5P+d9F4ThJg=; b=PnSbMMjyWDGMRqva/IwmcKjKu7pblfcc2vofA67r8GfwqXAnXTd/2P032GkteenVhamX0C SqzZ/g1bEupD9J5H4aAajZFRxXBt3cFAtgApWhREz9dv5VyKNrjEWZ5xM1NvOIU1TiU/7t IQrVXD4m4t4xfTYKOzQeAAu8+uUWf9s= X-MC-Unique: TRIyLUyVOb2P93TBbRDySA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH v2 1/3] qemu: domain: Convert detected 'iso' image format into 'raw' Date: Tue, 25 Feb 2020 14:25:43 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" While our code can detect ISO as a separate format, qemu does not use it as such and just passes it through as raw. Add conversion for detected parts of the backing chain so that the validation code does not reject it right away. Signed-off-by: Peter Krempa Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_domain.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 446a517df9..a28b51c10e 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -11493,6 +11493,10 @@ qemuDomainDetermineDiskChain(virQEMUDriverPtr driv= er, return -1; for (n =3D src->backingStore; virStorageSourceIsBacking(n); n =3D n->b= ackingStore) { + /* convert detected ISO format to 'raw' as qemu would not understa= nd it */ + if (n->format =3D=3D VIR_STORAGE_FILE_ISO) + n->format =3D VIR_STORAGE_FILE_RAW; + if (qemuDomainValidateStorageSource(n, priv->qemuCaps) < 0) return -1; --=20 2.24.1