From nobody Mon Feb 9 18:18:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1638891392; cv=none; d=zohomail.com; s=zohoarc; b=JvU3wsqrkw+mZ395jjVGVgRz/NPXJR/R7avWcOk5XUIgLWkM2nulBaF8/FmCDavmkzrUHnONkdWTJOYi30UidqUzomRBdlK7lZt1XeLWpF9pvwRHwPsDoVI/bhtN38drwd7WDljPO/z2eyL0e+06DIrQcnqCYlDX184UfC85uiI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1638891392; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=10X1nTCVYp+mbpjBQqJGYYVnlFxOkEupxpVKE5ImSUY=; b=bns+LpJTCG5VxNQ3LSVm/PIh6WekLzH/KpC5YGcZQxJ7znZH62dr9IB6hG4LJYiIzONg8r+0RNmaN1S81FD+IIx3FUGIf0WRdb1sZQ4KN4L009/ZrN/Hyh3xNe7XIJAyZE/Xe3FsVY1G7rsxYkwttLJGdz5BR851gzwQNMq8TI8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1638891392485974.7487348124865; Tue, 7 Dec 2021 07:36:32 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-526-E1iO4QfRMxyvkkZluFEAcg-1; Tue, 07 Dec 2021 10:36:29 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9C556801AC5; Tue, 7 Dec 2021 15:36:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D6E317D61; Tue, 7 Dec 2021 15:36:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 20C0A4A7C8; Tue, 7 Dec 2021 15:36:19 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B7FaIYZ024084 for ; Tue, 7 Dec 2021 10:36:18 -0500 Received: by smtp.corp.redhat.com (Postfix) id 221CD4ABA6; Tue, 7 Dec 2021 15:36:18 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9FFEE13A58 for ; Tue, 7 Dec 2021 15:35:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638891391; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=10X1nTCVYp+mbpjBQqJGYYVnlFxOkEupxpVKE5ImSUY=; b=SJ4C1IDvCynhxFfW9k1O7ngfz4dYW4aQBDCHm1v0teaYtxUC19yLnNZPstHo3XpE2Ks71w 2sQyatljJWhPBELLcehdoXIY6KGj0/Pc1JarA4VTVr3LuO6lJrc/wV1cyGkqRiBfXrtrwR 7Smn3z7sXkAHiUGhf94Bu5ryc8aRTog= X-MC-Unique: E1iO4QfRMxyvkkZluFEAcg-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 3/3] remote_driver: Implement virStreamInData() callback Date: Tue, 7 Dec 2021 16:34:42 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1638891393767100001 Content-Type: text/plain; charset="utf-8" When using the monolithic daemon the driver for virStream is always virFDStreamDrv and thus calling virStreamInData() results in calling virFDStreamInData(). But things are different with split daemon, especially when a client connects to one of hypervisor daemons (e.g. virtqemud) and then lets the daemon connect to the storage daemon for vol-upload/vol-download. Here, the hypervisor daemon acts like both client and server. This is reflected by stream->driver pointing to remoteStreamDrv, which doesn't have streamInData callback implemented and thus vol-upload/vol-download with sparse flag fails. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=3D2026537 Signed-off-by: Michal Privoznik Reviewed-by: Martin Kletzander --- src/remote/remote_driver.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 235c406a5a..5b179a927d 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -5599,6 +5599,31 @@ remoteStreamRecvHole(virStreamPtr st, } =20 =20 +static int +remoteStreamInData(virStreamPtr st, + int *data, + long long *length) +{ + struct private_data *priv =3D st->conn->privateData; + virNetClientStream *privst =3D st->privateData; + int rv; + + VIR_DEBUG("st=3D%p data=3D%p length=3D%p", + st, data, length); + + remoteDriverLock(priv); + priv->localUses++; + remoteDriverUnlock(priv); + + rv =3D virNetClientStreamInData(privst, data, length); + + remoteDriverLock(priv); + priv->localUses--; + remoteDriverUnlock(priv); + return rv; +} + + struct remoteStreamCallbackData { virStreamPtr st; virStreamEventCallback cb; @@ -5745,6 +5770,7 @@ static virStreamDriver remoteStreamDrv =3D { .streamSend =3D remoteStreamSend, .streamSendHole =3D remoteStreamSendHole, .streamRecvHole =3D remoteStreamRecvHole, + .streamInData =3D remoteStreamInData, .streamFinish =3D remoteStreamFinish, .streamAbort =3D remoteStreamAbort, .streamEventAddCallback =3D remoteStreamEventAddCallback, --=20 2.32.0