From nobody Mon Feb 9 16:53:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1569513085; cv=none; d=zoho.com; s=zohoarc; b=A4EvI/9tvRx2P5LdoMhsOTQ/O3+BM+OWo20Rlqu1q+AKfissr91H8L3w/u7gaYUIWMS+ceR4n6cN08d5M9bDlFLiY2yxKU9/AfkD2OSXbdn0ubCdZn3PTKmWZZPISH5CO8uEEXDu1NlSK6cSS9357ATr8x8ruc/0vZeeG9HpMfI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569513085; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=cSScP1c02heigBfmfbpr+P1/o7FcREok9oF1jpXxJJA=; b=XE0iBLHTJ8iXDIbEC1bEbe5990cceNpO3xzI4i/o5WKZvoK0KwlOPTbC8Nk5tT8+3YxCyUgzYTKVTojBgnXDvjVK5zYbdXaZ8U65uezopvhBYggfDT5KxkMhoWqCnY9+J1LnckjiBWE3c9w1EA6NGgCR3IppQ1MNL5+sqHIM/54= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1569513085206927.4135815345898; Thu, 26 Sep 2019 08:51:25 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8BDD2190C01F; Thu, 26 Sep 2019 15:51:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 57FCB1C948; Thu, 26 Sep 2019 15:51:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0B3DC1803B37; Thu, 26 Sep 2019 15:51:23 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x8QFpKm6000781 for ; Thu, 26 Sep 2019 11:51:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id CC42C60C80; Thu, 26 Sep 2019 15:51:20 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id 546FF60C5D for ; Thu, 26 Sep 2019 15:51:19 +0000 (UTC) From: Peter Krempa To: libvir-list@redhat.com Date: Thu, 26 Sep 2019 17:51:06 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/8] qemu: checkpoint: Remove open-ended TODOs X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.70]); Thu, 26 Sep 2019 15:51:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Once somebody is motivated enough to add the support for the quiesce flag or offline checkpoint deletion they are welcome to do so but we don't need to have a reminder. Signed-off-by: Peter Krempa --- src/qemu/qemu_checkpoint.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c index 4430f69911..59f700e1d3 100644 --- a/src/qemu/qemu_checkpoint.c +++ b/src/qemu/qemu_checkpoint.c @@ -370,7 +370,6 @@ qemuCheckpointCreateXML(virDomainPtr domain, VIR_AUTOUNREF(virDomainCheckpointDefPtr) def =3D NULL; virCheckFlags(VIR_DOMAIN_CHECKPOINT_CREATE_REDEFINE, NULL); - /* TODO: VIR_DOMAIN_CHECKPOINT_CREATE_QUIESCE */ if (redefine) { parse_flags |=3D VIR_DOMAIN_CHECKPOINT_PARSE_REDEFINE; @@ -570,8 +569,6 @@ qemuCheckpointDelete(virDomainObjPtr vm, return -1; if (!metadata_only) { - /* Until qemu-img supports offline bitmap deletion, we are stuck - * with requiring a running guest */ if (!virDomainObjIsActive(vm)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", _("cannot delete checkpoint for inactive domain= ")); --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list