From nobody Sat Feb 7 04:40:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620315192; cv=none; d=zohomail.com; s=zohoarc; b=Vj2LiUpJ34L7MIXBdGkmW0FxfbK2VeX03i/2S58WSpYbYWb/rEt7OrzTJ9b3cfA2jNb+QoEnK6kw4yXs1LukRqbnhXwS4rzSU/ScXbXsvRXECXllJGVeG8h8o3eInHjXoEGSfjm5J5q1eEYI8mlS2RJ9V5acxgiV+yRKE3Ujyno= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620315192; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ftq+qlQLMwAxZHGyyUsCcZNTO+KsFRfTG4atD8tB0Jc=; b=IiU+8ossbkMcAh0wlg3ES7W+wnLwCigqCfstSt3CTOHxL3NoqnITwOD5HV2QeBC3tAcmcXbdOyfNHojo+Jn6F27euDu7CO/XH9zSnqiBZTlMBvGVvBrdVX09iu+Y9FmWwu3rbw+CIzAJyuB8j/iN5Ql6XteplDebUMwLkt3HxgU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1620315192318768.8528121149051; Thu, 6 May 2021 08:33:12 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-479-6RUla8qtMwiPlK7cC9og8g-1; Thu, 06 May 2021 11:31:43 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B688D107ACF2; Thu, 6 May 2021 15:31:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 97222690EF; Thu, 6 May 2021 15:31:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 510955535E; Thu, 6 May 2021 15:31:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 146FVPrR011478 for ; Thu, 6 May 2021 11:31:25 -0400 Received: by smtp.corp.redhat.com (Postfix) id EA78010027A5; Thu, 6 May 2021 15:31:25 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C0281079149 for ; Thu, 6 May 2021 15:31:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620315190; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ftq+qlQLMwAxZHGyyUsCcZNTO+KsFRfTG4atD8tB0Jc=; b=FPkwX1clYJkQ+QCt534LKpfXo32pA7I9jDnmqsS2I5OPrep7EPZn7+Xqt4qSvLm9T+cGtC Leo3GDaVfSpkgaS7hguIJMYChTJFVD7gOjeXfIViGZH4stzPpRY92WwN61C7nTNSbaG/A5 las0rbSUSg2+x8LqSdj0ADzxYOPgX2Y= X-MC-Unique: 6RUla8qtMwiPlK7cC9og8g-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 14/17] virDomainVideoDefParseXML: Fix parsing of 'backend' Date: Thu, 6 May 2021 17:31:06 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Commit 8391cfbc2dbc converted the code to use virXMLPropEnum unfaithfully ommitting the check where 'backend' must be non-zero when parsed from the user. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d36ff536f4..bddc5eee26 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14257,7 +14257,7 @@ virDomainVideoDefParseXML(virDomainXMLOption *xmlop= t, if ((driver =3D virXPathNode("./driver", ctxt))) { if (virXMLPropEnum(driver, "name", virDomainVideoBackendTypeFromString, - VIR_XML_PROP_NONE, &def->backend) < 0) + VIR_XML_PROP_NONZERO, &def->backend) < 0) return NULL; if (virDomainVirtioOptionsParseXML(driver, &def->virtio) < 0) return NULL; --=20 2.30.2