From nobody Sun Feb 8 16:53:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626864426; cv=none; d=zohomail.com; s=zohoarc; b=TSaXiafS95IqBp14FpgwDeinndFM6lajDH39O7Wg5LlBLyxKlcBEv9K67qcFvJKMF3nDF3I65vdo7MWvQxher29pVWx6IWp/khrFtTRyWLUXKcOLPFSzpM8t46EDd9OXaaXx/kcfciET2NbMdYOLt61yNko3aRtEs4XnwawQdCw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626864426; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VY2BVDaBbQWQw9U0FNcDB7lEPvOnQMvmvahnyXZsTkI=; b=Pr9NPp0kP3L5nsj9QhOu+9DSA0/+2taSnULvXf3TTSsLJdpciqWhgol4AdY6kLfotcsoSEdE4OjzUeVlnl1Ih3/BtfaIQGrU6/OIs/dZ+tYzXA8wbZDcArmfqoyZX4muu26ElCcZZ21muxTlsZUykywCBu28Ct5FzJHktoj+SAw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626864426405136.92135647501505; Wed, 21 Jul 2021 03:47:06 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-255-s_hjKSnYNP-3-ASNGYi45A-1; Wed, 21 Jul 2021 06:46:03 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0AD32100E430; Wed, 21 Jul 2021 10:45:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D735D1970E; Wed, 21 Jul 2021 10:45:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A4BE650038; Wed, 21 Jul 2021 10:45:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16LAhaNu001248 for ; Wed, 21 Jul 2021 06:43:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8C08919D9B; Wed, 21 Jul 2021 10:43:36 +0000 (UTC) Received: from andariel.local (unknown [10.40.193.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE02419C79 for ; Wed, 21 Jul 2021 10:43:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626864425; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=VY2BVDaBbQWQw9U0FNcDB7lEPvOnQMvmvahnyXZsTkI=; b=c1cMBraDZ0w0SxSbm3LjSLcXtbvGlaJ3ldMbso/VCM/DZFZg3Orh6pRltglxwGUdUURBQf eU1woImvOmMNjh1mfUxymAG/wQfwmGEYyrWMt0vjQ03kpqLjvqqgGUutHOcDYW6oXOt5nd kIj5Q8aJL51F/6V/nU6cuhfIl/vuMhw= X-MC-Unique: s_hjKSnYNP-3-ASNGYi45A-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 31/33] qemu: Remove return value from qemuMonitorDomainGuestCrashloadedCallback Date: Wed, 21 Jul 2021 12:42:43 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626864427180100004 Content-Type: text/plain; charset="utf-8" Change the callback prototype and fix the callback registered in the process code. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.h | 6 +++--- src/qemu/qemu_process.c | 4 +--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 071a40de44..c3a463aa51 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -324,9 +324,9 @@ typedef void (*qemuMonitorDomainRdmaGidStatusChangedCal= lback)(qemuMonitor *mon, unsigned lon= g long interface_id, void *opaque= ); -typedef int (*qemuMonitorDomainGuestCrashloadedCallback)(qemuMonitor *mon, - virDomainObj *vm, - void *opaque); +typedef void (*qemuMonitorDomainGuestCrashloadedCallback)(qemuMonitor *mon, + virDomainObj *vm, + void *opaque); typedef enum { QEMU_MONITOR_MEMORY_FAILURE_RECIPIENT_HYPERVISOR, diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index c31dbb5513..eee65a71b2 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1792,7 +1792,7 @@ qemuProcessHandleRdmaGidStatusChanged(qemuMonitor *mo= n G_GNUC_UNUSED, } -static int +static void qemuProcessHandleGuestCrashloaded(qemuMonitor *mon G_GNUC_UNUSED, virDomainObj *vm, void *opaque) @@ -1812,8 +1812,6 @@ qemuProcessHandleGuestCrashloaded(qemuMonitor *mon G_= GNUC_UNUSED, } virObjectUnlock(vm); - - return 0; } --=20 2.31.1