From nobody Mon Feb 9 01:00:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1566852331; cv=none; d=zoho.com; s=zohoarc; b=Ed4bCOEmxBs2uvGbrnoLFaehYBvlQYqXsZlSj9XIi/NWA7gZalZUY/3eKxIbLnSHtgnbLFpxMOOebs4mNrJqO/KFaecG/QbA837oTv64o5xGyFMfVCjB5M5XQ3AzGvZaSkE6AeWv/LLE54Jz1N+AnIriq8Lqs5/z29udY6idDn8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566852331; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=IeefUUwYkSLSknznjpA7WngnAzRNta8UunSxETIM0yw=; b=MVO1/gn7Nal166ZF0TajBK3e9yMcEVULPMbPGaZGEoRnMKnKgeiwb87fph25wVPKzzL+sRcOGBGZoro189bFhpWA61Q1H/aRVYMONR6/kHfooc2am6FaIxpZ2Y3v5PmqLkbCC+J39i+igw7wd6zMyHfRUioo5KN0t0nzK6cHHIA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1566852331194783.7865293681648; Mon, 26 Aug 2019 13:45:31 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2882E109EFD1; Mon, 26 Aug 2019 20:45:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 004945C207; Mon, 26 Aug 2019 20:45:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B8F2A180BA9D; Mon, 26 Aug 2019 20:45:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x7QKjTTE020251 for ; Mon, 26 Aug 2019 16:45:29 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4781C60F88; Mon, 26 Aug 2019 20:45:29 +0000 (UTC) Received: from icr.brq.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C519660F86 for ; Mon, 26 Aug 2019 20:45:26 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Mon, 26 Aug 2019 22:44:56 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 7/7] qemuBuildMemoryCellBackendStr: remove useless ret variable X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.65]); Mon, 26 Aug 2019 20:45:30 +0000 (UTC) Signed-off-by: J=C3=A1n Tomko --- src/qemu/qemu_command.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 528e11d5a0..18b3914ca9 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3588,14 +3588,13 @@ qemuBuildMemoryCellBackendStr(virDomainDefPtr def, { VIR_AUTOPTR(virJSONValue) props =3D NULL; VIR_AUTOFREE(char *) alias =3D NULL; - int ret =3D -1; int rc; virDomainMemoryDef mem =3D { 0 }; unsigned long long memsize =3D virDomainNumaGetNodeMemorySize(def->num= a, cell); =20 if (virAsprintf(&alias, "ram-node%zu", cell) < 0) - goto cleanup; + return -1; =20 mem.size =3D memsize; mem.targetNode =3D cell; @@ -3603,16 +3602,12 @@ qemuBuildMemoryCellBackendStr(virDomainDefPtr def, =20 if ((rc =3D qemuBuildMemoryBackendProps(&props, alias, cfg, priv, def, &mem, false)) < 0) - goto cleanup; + return -1; =20 if (virQEMUBuildObjectCommandlineFromJSON(buf, props) < 0) - goto cleanup; - - ret =3D rc; - - cleanup: + return -1; =20 - return ret; + return rc; } =20 =20 --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list