From nobody Sun Feb 8 18:44:54 2026 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 169954328940012.164679619714775; Thu, 9 Nov 2023 07:21:29 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 1C0531B36; Thu, 9 Nov 2023 10:21:28 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 62B891B34; Thu, 9 Nov 2023 09:55:09 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id B2F0C1B0D; Thu, 9 Nov 2023 09:54:56 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 594041A27 for ; Thu, 9 Nov 2023 09:52:25 -0500 (EST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-513-UxivnhYvNMqQfueR9bGezQ-1; Thu, 09 Nov 2023 09:52:23 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1136818A04DB for ; Thu, 9 Nov 2023 14:52:22 +0000 (UTC) Received: from speedmetal.lan (unknown [10.45.242.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D76A40C6EBB for ; Thu, 9 Nov 2023 14:52:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: UxivnhYvNMqQfueR9bGezQ-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 1/6] qemumigrationcookiexmltest: Don't crash when parsing of status XML fails Date: Thu, 9 Nov 2023 15:52:14 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: J47XRZF24CLUDD6AC7NZ5GIBYWV3I34A X-Message-ID-Hash: J47XRZF24CLUDD6AC7NZ5GIBYWV3I34A X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1699543290043100001 Some sub-tests dereference 'data->vm' even when it is NULL. Signed-off-by: Peter Krempa --- tests/qemumigrationcookiexmltest.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/tests/qemumigrationcookiexmltest.c b/tests/qemumigrationcookie= xmltest.c index 74302dc55f..5270e3a7e7 100644 --- a/tests/qemumigrationcookiexmltest.c +++ b/tests/qemumigrationcookiexmltest.c @@ -137,9 +137,17 @@ static int testQemuMigrationCookieParse(const void *opaque) { struct testQemuMigrationCookieData *data =3D (struct testQemuMigration= CookieData *) opaque; - qemuDomainObjPrivate *priv =3D data->vm->privateData; + qemuDomainObjPrivate *priv; g_auto(virBuffer) actual =3D VIR_BUFFER_INITIALIZER; + /* if the VM object parsing step failed there's nothing this test can = do */ + if (!data->vm) { + VIR_TEST_DEBUG("\nmissing VM object\n"); + return -1; + } + + priv =3D data->vm->privateData; + if (!(data->cookie =3D qemuMigrationCookieParse(&driver, data->vm, data->vm->def, @@ -314,6 +322,12 @@ testQemuMigrationCookieBlockDirtyBitmaps(const void *o= paque) return -1; } + /* if the VM object parsing step failed there's nothing this test can = do */ + if (!data->vm) { + VIR_TEST_DEBUG("\nmissing VM object\n"); + return -1; + } + if (qemuMigrationCookieBlockDirtyBitmapsMatchDisks(data->vm->def, data->cookie->block= DirtyBitmaps) < 0) return -1; --=20 2.41.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org