From nobody Fri Oct 18 08:48:38 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1706635320385643.6638618321525; Tue, 30 Jan 2024 09:22:00 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 31DE61C28; Tue, 30 Jan 2024 12:21:59 -0500 (EST) Received: from lists.libvirt.org.85.43.8.in-addr.arpa (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id C0F3A1D5B; Tue, 30 Jan 2024 12:09:17 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 597831D44; Tue, 30 Jan 2024 12:08:53 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 5FEFC1C98 for ; Tue, 30 Jan 2024 12:08:21 -0500 (EST) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-W9DnaLzmMEaQcupciUVs2A-1; Tue, 30 Jan 2024 12:08:19 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4B697380670B for ; Tue, 30 Jan 2024 17:08:19 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id A50B22166B31 for ; Tue, 30 Jan 2024 17:08:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: W9DnaLzmMEaQcupciUVs2A-1 From: Peter Krempa To: devel@lists.libvirt.org Subject: [PATCH 08/31] tests: virpcivpdtest: Remove 'testVirPCIVPDReadVPDBytes' case Date: Tue, 30 Jan 2024 18:07:46 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: GGVDI6QFOZCJSWWWHKV7N3YSCLBURXIJ X-Message-ID-Hash: GGVDI6QFOZCJSWWWHKV7N3YSCLBURXIJ X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1706635321315100001 The case checks only the 'virPCIVPDReadVPDBytes' which is also tested multiple times via 'virPCIVPDParse' as it's used to read the data, thus having a special case for this is pointless. Signed-off-by: Peter Krempa --- tests/virpcivpdtest.c | 41 ----------------------------------------- 1 file changed, 41 deletions(-) diff --git a/tests/virpcivpdtest.c b/tests/virpcivpdtest.c index ae5772d3f5..aadd1b222b 100644 --- a/tests/virpcivpdtest.c +++ b/tests/virpcivpdtest.c @@ -429,45 +429,6 @@ testPCIVPDGetFieldValueFormat(const void *data G_GNUC_= UNUSED) 'Y', 'E', 0x00, \ 'R', 'W', 0x02, 0x00, 0x00 -static int -testVirPCIVPDReadVPDBytes(const void *opaque G_GNUC_UNUSED) -{ - VIR_AUTOCLOSE fd =3D -1; - g_autofree uint8_t *buf =3D NULL; - uint8_t csum =3D 0; - size_t readBytes =3D 0; - size_t dataLen =3D 0; - - /* An example of a valid VPD record with one VPD-R resource and 2 fiel= ds. */ - uint8_t fullVPDExample[] =3D { - VPD_STRING_RESOURCE_EXAMPLE_HEADER, VPD_STRING_RESOURCE_EXAMPLE_DA= TA, - VPD_R_FIELDS_EXAMPLE_HEADER, VPD_R_FIELDS_EXAMPLE_DATA, - PCI_VPD_RESOURCE_END_VAL - }; - dataLen =3D G_N_ELEMENTS(fullVPDExample) - 2; - buf =3D g_malloc0(dataLen); - - if ((fd =3D virCreateAnonymousFile(fullVPDExample, dataLen)) < 0) - return -1; - - readBytes =3D virPCIVPDReadVPDBytes(fd, buf, dataLen, 0, &csum); - - if (readBytes !=3D dataLen) { - virReportError(VIR_ERR_INTERNAL_ERROR, - "The number of bytes read %zu is lower than expecte= d %zu ", - readBytes, dataLen); - return -1; - } - - if (csum) { - virReportError(VIR_ERR_INTERNAL_ERROR, - "The sum of all VPD bytes up to and including the c= hecksum byte" - "is equal to zero: 0x%02x", csum); - return -1; - } - return 0; -} - static int testVirPCIVPDParseVPDStringResource(const void *opaque G_GNUC_UNUSED) { @@ -1003,8 +964,6 @@ mymain(void) if (virTestRun("Determining a field value format by a key ", testPCIVPDGetFieldValueFormat, NULL) < 0) ret =3D -1; - if (virTestRun("Reading VPD bytes ", testVirPCIVPDReadVPDBytes, NULL) = < 0) - ret =3D -1; if (virTestRun("Parsing VPD string resources ", testVirPCIVPDParseVPDS= tringResource, NULL) < 0) ret =3D -1; if (virTestRun("Parsing a VPD resource with a zero-length RW ", --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org