From nobody Tue Feb 10 07:40:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612600503; cv=none; d=zohomail.com; s=zohoarc; b=YDva7j5AnR/yzgPfAzi1X/8kSe1jg5mqy7nfw4HZ8aKxuMz9F/rShZ1S3Wm/ogfVFEybRX2OrEVshIDb2PrpnY2DzHOgUq42cDxPwbYCSr5eVHTeGQ9x18aEy8YnY/RgkejT/CBytoiDsp4ekdj4tX4TFLlisfZLGNT9xAisqCk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612600503; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Lh5F4HJ3rrtTRO88dwbVdVAiSG2Bv0JK03NO/oZWEOU=; b=E7hGhe9c2Cto22hhTM1zFCcQySUn92LoHUvwEP5Ds6vSo/O2wN5RLjSHFIgNEmngzMMQ/DRC/XxhoPfYHQV+n0SUdz5Uqh94H8ywYV/2XqnEjNe4FZcI2afsGU9Q7pPdzlLbXEJPZAqpeHY9acSGdUvaNLsFd+vYSW9XNTr2GM0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 161260050385491.60516884745277; Sat, 6 Feb 2021 00:35:03 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-153-3Tu6kvpqN9aHwG2b1sX8pw-1; Sat, 06 Feb 2021 03:33:49 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 15025100CCCF; Sat, 6 Feb 2021 08:33:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E1E806F447; Sat, 6 Feb 2021 08:33:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A827018089D4; Sat, 6 Feb 2021 08:33:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1168XQUm004760 for ; Sat, 6 Feb 2021 03:33:26 -0500 Received: by smtp.corp.redhat.com (Postfix) id 3EE9360C78; Sat, 6 Feb 2021 08:33:26 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 76AB360C77 for ; Sat, 6 Feb 2021 08:33:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612600502; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Lh5F4HJ3rrtTRO88dwbVdVAiSG2Bv0JK03NO/oZWEOU=; b=huEbUgBQZqLYsTZtAuSLwrZjSfRqU7AW5AFFgPIwOBv+QB1f8zzLTPLjfO9HPXm9Ak6BS+ 6blNx/lSBF6LwKZ2mqcNc7qYwwLZYfuFqv7AIAXa92RcCmseQaot/XvIRnov2mPGu6gtCi QaLQAAIiXlFn1Ha5xsVp0kc2rsuwTTc= X-MC-Unique: 3Tu6kvpqN9aHwG2b1sX8pw-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 10/40] qemuInteropFetchConfigs: Don't use 'virStringListAdd' to construct list Date: Sat, 6 Feb 2021 09:32:32 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" 'virHashGetItems' already returns the number of entries which will be considered for addition to the list so we can allocate it to the upper bound upfront rather than growing it in a loop. This avoids the quadratic complexity of 'virStringListAdd'. Signed-off-by: Peter Krempa --- src/qemu/qemu_interop_config.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_interop_config.c b/src/qemu/qemu_interop_config.c index bcaddda446..9733df7194 100644 --- a/src/qemu/qemu_interop_config.c +++ b/src/qemu/qemu_interop_config.c @@ -94,7 +94,9 @@ qemuInteropFetchConfigs(const char *name, g_autofree char *sysLocation =3D virFileBuildPath(QEMU_SYSTEM_LOCATION= , name, NULL); g_autofree char *etcLocation =3D virFileBuildPath(QEMU_ETC_LOCATION, n= ame, NULL); g_autofree virHashKeyValuePairPtr pairs =3D NULL; + size_t npairs; virHashKeyValuePairPtr tmp =3D NULL; + size_t nconfigs =3D 0; *configs =3D NULL; @@ -132,11 +134,13 @@ qemuInteropFetchConfigs(const char *name, * where each filename (as key) has the highest priority full pathname * associated with it. */ - if (virHashSize(files) =3D=3D 0) + if (!(pairs =3D virHashGetItems(files, &npairs, true))) + return -1; + + if (npairs =3D=3D 0) return 0; - if (!(pairs =3D virHashGetItems(files, NULL, true))) - return -1; + *configs =3D g_new0(char *, npairs + 1); for (tmp =3D pairs; tmp->key; tmp++) { const char *path =3D tmp->value; @@ -158,8 +162,7 @@ qemuInteropFetchConfigs(const char *name, continue; } - if (virStringListAdd(configs, path) < 0) - return -1; + (*configs)[nconfigs++] =3D g_strdup(path); } return 0; --=20 2.29.2