From nobody Mon Feb 9 06:05:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602074174; cv=none; d=zohomail.com; s=zohoarc; b=GjeumJuDOp4fxB5qgf1duCEHWNzlCx5KKTM1lc6B3UZFur7bo9+4y0uSypI0S0YS5QsVLamWaDavD9Zmplz7wxpmQXr/byzHGQRMJFETye2VB26V+snGibk6rCWaNJCYIDMfDttK0S6vonwPcOqcGW1qad1PCi3rvoIeTHR/EhI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602074174; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=N2XRHhKpYc/TDKwToWVaDhpobAUxK0IFWfPKRJBnbQ8=; b=WvbCBSii9BqVi7hJdE5vN8o/DY16UqyONOZZiQqnHOwhTpFvyNs7bo+tlU1v38CZU3qCGQcaHKCmC22sJ5kvG3d7LBtWynJu+38XOd4xApr8/+6CIRhp1CG0UAYqkvaaD67klTAK6xjxnNZEcWmUVnyNVrw0hqp54Q/Nf3iGBSM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1602074174155409.91752211727214; Wed, 7 Oct 2020 05:36:14 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-341-_X1bWYe1NfOVVHWiihvWsA-1; Wed, 07 Oct 2020 08:36:09 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6B7EC8064D9; Wed, 7 Oct 2020 12:36:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4836E5D9DD; Wed, 7 Oct 2020 12:36:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 13C178C7AA; Wed, 7 Oct 2020 12:36:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 097CZjo9012454 for ; Wed, 7 Oct 2020 08:35:45 -0400 Received: by smtp.corp.redhat.com (Postfix) id E4997702E7; Wed, 7 Oct 2020 12:35:45 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CEFF76642 for ; Wed, 7 Oct 2020 12:35:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602074172; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=N2XRHhKpYc/TDKwToWVaDhpobAUxK0IFWfPKRJBnbQ8=; b=OkMiTSsHz0AbEvXNu405Amr/pM567OJqUXL9QHTy1w6C1DE5ce7IvvgVkT+1cQNpeu/b6L fc7Wvmobf5/AYTT43jpsM0t+iJxGpnASyODyfdI4GTjdEjM6z3FSzlNdLtHVTQynjpgngp p6Gqd3Cn9aQuXL9gzoMFDv2oGvNfN/M= X-MC-Unique: _X1bWYe1NfOVVHWiihvWsA-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCHv2 08/16] qemu: agent: simplify access to ifaces_ret Date: Wed, 7 Oct 2020 14:35:29 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) We have a local 'iface' variable that contains the same value eventually. Initialize it early instead of indexing two more times. Signed-off-by: J=C3=A1n Tomko Reviewed-by: Jonathon Jongsma --- src/qemu/qemu_agent.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index a09fb4da2a..721ff55fff 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -2176,15 +2176,13 @@ qemuAgentGetInterfaces(qemuAgentPtr agent, if (VIR_EXPAND_N(ifaces_ret, ifaces_count, 1) < 0) goto error; =20 - ifaces_ret[ifaces_count - 1] =3D g_new0(virDomainInterface, 1); + iface =3D g_new0(virDomainInterface, 1); + ifaces_ret[ifaces_count - 1] =3D iface; =20 - if (virHashAddEntry(ifaces_store, ifname_s, - ifaces_ret[ifaces_count - 1]) < 0) + if (virHashAddEntry(ifaces_store, ifname_s, iface) < 0) goto error; =20 - iface =3D ifaces_ret[ifaces_count - 1]; iface->naddrs =3D 0; - iface->name =3D g_strdup(ifname_s); =20 hwaddr =3D virJSONValueObjectGetString(tmp_iface, "hardware-ad= dress"); --=20 2.26.2