From nobody Sun Feb 8 21:11:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612285017; cv=none; d=zohomail.com; s=zohoarc; b=JYe4BmYuqll6g/mnJJBqgbUWhK/hHDTEvvKeAUAN7GjRstw5/vS0/GAP6SHP9kRFw+dDUyvD8N6dtM3K/4ntT+65G00VXkrQoOwNkFgOWUjKrPCJHyHgbkaLLMwsKVRNlYJf+V40EIfz+Sg4CbCCLK2PgpSWvLPeB1jV1GyeQxQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612285017; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QaJL6dIU2D2mq00uPDASaW69HcspYQ3BwdEuptxgZoo=; b=IHRpinrnrCf3gc7z0gqfRqOievi3ArHDFQbg8PHnB6Hrw4DBGat3FEVG8TiRVfKGydHin0fgoiAKXpjpRdXksF3B8XbPPCB+0qAFDkWIKZ2x+bXlHVRKHwNmsxS05LRwCWVg5SJMGv+JM7vG2Pba9Qpde1RJipputmFJeQVSjYA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1612285017892423.418643777645; Tue, 2 Feb 2021 08:56:57 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-149-RfAgSsenNc6N6YR--yBI5w-1; Tue, 02 Feb 2021 11:56:54 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 62A968712E3; Tue, 2 Feb 2021 16:56:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3DDE15D722; Tue, 2 Feb 2021 16:56:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0627918089C9; Tue, 2 Feb 2021 16:56:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 112GukKu015058 for ; Tue, 2 Feb 2021 11:56:46 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5C1806EF41; Tue, 2 Feb 2021 16:56:46 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 466316E510 for ; Tue, 2 Feb 2021 16:56:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612285016; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=QaJL6dIU2D2mq00uPDASaW69HcspYQ3BwdEuptxgZoo=; b=ajgJ41NCx/SLVnqOtiOVUfSb6L6cmKuHqjJaBhE02Ud0D5UyYQPLxFLLRYkHz+Pv0+qFWo fVw09hyXPg+avOuYVN2DyBg+2OSbmcJgSjbt++M202CGkzj8G7rKDkRqlM70NW0+CxCNuB i3hNzvz5otuUW+tqILA7BvEj4LejcKE= X-MC-Unique: RfAgSsenNc6N6YR--yBI5w-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH v2 12/27] virsh: cmdSecretGetValue: Use virSecureErase instead of VIR_DISPOSE_N Date: Tue, 2 Feb 2021 17:55:49 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Switch the secret value to 'g_autofree' for handling of the memory and clear it out using virSecureErase. Signed-off-by: Peter Krempa Reviewed-by: Daniel P. Berrang=C3=A9 --- tools/virsh-secret.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c index e413af893f..de32f25d64 100644 --- a/tools/virsh-secret.c +++ b/tools/virsh-secret.c @@ -303,7 +303,7 @@ cmdSecretGetValue(vshControl *ctl, const vshCmd *cmd) { g_autoptr(virshSecret) secret =3D NULL; VIR_AUTODISPOSE_STR base64 =3D NULL; - unsigned char *value; + g_autofree unsigned char *value =3D NULL; size_t value_size; bool plain =3D vshCommandOptBool(cmd, "plain"); @@ -315,7 +315,7 @@ cmdSecretGetValue(vshControl *ctl, const vshCmd *cmd) if (plain) { if (fwrite(value, 1, value_size, stdout) !=3D value_size) { - VIR_DISPOSE_N(value, value_size); + virSecureErase(value, value_size); vshError(ctl, "failed to write secret"); return false; } @@ -325,7 +325,7 @@ cmdSecretGetValue(vshControl *ctl, const vshCmd *cmd) vshPrint(ctl, "%s", base64); } - VIR_DISPOSE_N(value, value_size); + virSecureErase(value, value_size); return true; } --=20 2.29.2