From nobody Sun Dec 14 06:38:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1751547114; cv=none; d=zohomail.com; s=zohoarc; b=bcUneeQesmv8MMjcSADI6LXB/YUT4CjMfrmwJfch9QgWHsCToXde1qKdbA7jPA6UBFyQ4/TJF28o/kS1cmz+X9JB1OkTIBoXpJM0+HNgyMN7HCz57XAsXbFjgNm5fhf6HWcvdDP+VKoC32XmL8qBvD0NFOUilT2WYUCsMWRq+gg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751547114; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=bNcJ+KtUo5sg6sYIe6yYtDndwHAeJ6jQ91WpqFrNIbI=; b=L8I2/r6HJFG0cS36yZ5Skw5MNoctG1Dt4fmPyz7wgYItPRVO7h8waoVrEg3WKeJojNaoZ940gNXzk2MJqNYvF69y/QO/UgKug8AgAxpCV0TeuaA0LbXhPmdYduA+teRGvFaULGdsso33KpM43hsVCmZ9HK02SXC43Aq+JXTeavE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 175154711463381.27837404795957; Thu, 3 Jul 2025 05:51:54 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id B661413DF; Thu, 3 Jul 2025 08:51:53 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id C04FD12BE; Thu, 3 Jul 2025 08:50:44 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id B120BCD0; Thu, 3 Jul 2025 08:50:41 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3927FA79 for ; Thu, 3 Jul 2025 08:50:41 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-hAOlH7JyNSuSTcmyR0T0fg-1; Thu, 03 Jul 2025 08:50:39 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E13C518089B5 for ; Thu, 3 Jul 2025 12:50:38 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.45.242.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 20B15195608F for ; Thu, 3 Jul 2025 12:50:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751547040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nkKwubg0XDOP9Kdxtpr12OLhPvxAm2ftOOUBlsNaZNA=; b=a5iSyivzsuXZcP1gxxJVAjj++SxbHUyNuupphCXa0TrE/UzB+/iRmj0YogjSPnBGK1qsi5 m5qPMtoNYAMrQZ7AiLCsrMmkZIvWgPAlWBN6Vgv0iT79n1GLNaDAcq98nLqtMus2a/sVD3 kUxziFAklYnA+Ji9GiWV2f+tTwZGmWY= X-MC-Unique: hAOlH7JyNSuSTcmyR0T0fg-1 X-Mimecast-MFC-AGG-ID: hAOlH7JyNSuSTcmyR0T0fg_1751547039 To: devel@lists.libvirt.org Subject: [PATCH 02/10] cgroup: Unexport 'virDomainCgroupInitCgroup' Date: Thu, 3 Jul 2025 14:50:25 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: IHqr-oxejIHOMObbjlrZG9xrI8fs9RstzK5RJ8PgedE_1751547039 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: DJCSSYOZWUINW3Y74ZLDCFOFT2AQWRAY X-Message-ID-Hash: DJCSSYOZWUINW3Y74ZLDCFOFT2AQWRAY X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1751547115896116600 Content-Type: text/plain; charset="utf-8" From: Peter Krempa The function is called just from one place within the module where it's defined. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina --- src/hypervisor/domain_cgroup.c | 2 +- src/hypervisor/domain_cgroup.h | 10 ---------- src/libvirt_private.syms | 1 - 3 files changed, 1 insertion(+), 12 deletions(-) diff --git a/src/hypervisor/domain_cgroup.c b/src/hypervisor/domain_cgroup.c index fda495faf5..fecc0f7966 100644 --- a/src/hypervisor/domain_cgroup.c +++ b/src/hypervisor/domain_cgroup.c @@ -342,7 +342,7 @@ virDomainCgroupSetupCpuCgroup(virDomainObj *vm, } -int +static int virDomainCgroupInitCgroup(const char *prefix, virDomainObj *vm, size_t nnicindexes, diff --git a/src/hypervisor/domain_cgroup.h b/src/hypervisor/domain_cgroup.h index f8d261a080..6e5c98004e 100644 --- a/src/hypervisor/domain_cgroup.h +++ b/src/hypervisor/domain_cgroup.h @@ -52,16 +52,6 @@ virDomainCgroupSetupCpusetCgroup(virCgroup *cgroup); int virDomainCgroupSetupCpuCgroup(virDomainObj *vm, virCgroup *cgroup); -int -virDomainCgroupInitCgroup(const char *prefix, - virDomainObj *vm, - size_t nnicindexes, - int *nicindexes, - virCgroup **cgroup, - int cgroupControllers, - unsigned int maxThreadsPerProc, - bool privileged, - char *machineName); void virDomainCgroupRestoreCgroupState(virDomainObj *vm, virCgroup *cgroup); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index a8ebf9efd8..8f1489ecc8 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1641,7 +1641,6 @@ virSetConnectStorage; virDomainCgroupConnectCgroup; virDomainCgroupEmulatorAllNodesAllow; virDomainCgroupEmulatorAllNodesRestore; -virDomainCgroupInitCgroup; virDomainCgroupRemoveCgroup; virDomainCgroupSetMemoryLimitParameters; virDomainCgroupSetupBlkio; --=20 2.49.0