From nobody Fri Dec 12 14:06:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1764251989; cv=none; d=zohomail.com; s=zohoarc; b=jtqFWWfWuAbrvhVjM2iTlT32sxhIzw0IIiWLcBWOyn4DTBV+HOUikd+yCpFMkjtVzegc68kMFGrGQEVQluZMh8ybLyrU313/3tPi2ipwkxOQssVCVYjzT8in6R64YdIuMRHO1fotmtxRIxB3ng0spwQkCL+P1kYJMAWunYCq0u0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764251989; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=NVPft1uBDxOYYtrO8a6RbDmMpcTVzR2eHFqE5VgoPy4=; b=Q4nAxnhwVYzjvWqQlNc+uW14CmfKDlOiKjjxQF32OID7bFjl853/gtV4vAsvRShlF308ylyGVgO4UEsVFczpixWYQqKwJtok1y+PuoTiDWwOhOMuJzxJRiUOUBt7BDwNQkuV6oHesU9rxBwTB+hdi82I9DWcW6GQRXt8RXZWz6A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1764251989904758.5312414700727; Thu, 27 Nov 2025 05:59:49 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id EB3A444B9C; Thu, 27 Nov 2025 08:59:44 -0500 (EST) Received: from [172.19.199.74] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 630BF44CEE; Thu, 27 Nov 2025 08:54:21 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 3C77D418FA; Thu, 27 Nov 2025 08:52:38 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 6437244B18 for ; Thu, 27 Nov 2025 08:51:11 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-250-7xBhDOGrOFOO8hy60au-Xw-1; Thu, 27 Nov 2025 08:51:09 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 15E591800372 for ; Thu, 27 Nov 2025 13:51:09 +0000 (UTC) Received: from moe (unknown [10.43.3.236]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 60B071800451 for ; Thu, 27 Nov 2025 13:51:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764251471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NVPft1uBDxOYYtrO8a6RbDmMpcTVzR2eHFqE5VgoPy4=; b=JhvVvZ6d1bFg76a+Y5cfaRKZQU2LqhdWwtN5ncAVQR21+/VJbZVOcGysaYaBqX7IPDCrLV 6MWSC2gHIrUGG9vIpQTYwEEObxaZszq0x4m0IOmPXsG4Ics7JWqkKW9nok3eEkDJW/PHpq YnB4ZV38OajtjFg4y2v7QtEljdnI7yo= X-MC-Unique: 7xBhDOGrOFOO8hy60au-Xw-1 X-Mimecast-MFC-AGG-ID: 7xBhDOGrOFOO8hy60au-Xw_1764251469 To: devel@lists.libvirt.org Subject: [PATCH 2/8] virstringtest: Introduce a test for virSkipSpacesBackwards() Date: Thu, 27 Nov 2025 14:50:57 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: G_4GBBS1HMqc1TuIX6YhWldi8QAnUbN2Lps7x_JsjAI_1764251469 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 53A6XEL5X7JBIDQRHZRZH222NKFZKLTR X-Message-ID-Hash: 53A6XEL5X7JBIDQRHZRZH222NKFZKLTR X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Michal Privoznik via Devel Reply-To: Michal Privoznik X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1764251991971019200 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Michal Privoznik The signature and implementation of virSkipSpacesBackwards() is soon about to change. Introduce a test case to make sure its behaviour stays the same. Signed-off-by: Michal Privoznik --- tests/virstringtest.c | 48 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/tests/virstringtest.c b/tests/virstringtest.c index f4976890db..a9c8e621ce 100644 --- a/tests/virstringtest.c +++ b/tests/virstringtest.c @@ -111,6 +111,51 @@ testStringSortCompare(const void *opaque G_GNUC_UNUSED) } =20 =20 +#define TEST_STR "This is a static string with spaces" +#define TEST_SPACES " " + +static int +testSkipSpacesBackwards(const void *opaque G_GNUC_UNUSED) +{ + const char *str =3D TEST_STR TEST_SPACES; + char *eol =3D NULL; + + virSkipSpacesBackwards(str, &eol); + + if (STRNEQ(str, TEST_STR TEST_SPACES)) { + fprintf(stderr, "expected '" TEST_STR TEST_SPACES "' got '%s'\n", = str); + return -1; + } + + while (g_ascii_isspace(*eol)) + eol++; + + if (*eol !=3D '\0') { + fprintf(stderr, "expected empty string, got '%s'\n", eol); + return -1; + } + + eol =3D (char *)str + strlen(TEST_STR); + + virSkipSpacesBackwards(str, &eol); + + if (STRNEQ(str, TEST_STR TEST_SPACES)) { + fprintf(stderr, "expected '" TEST_STR TEST_SPACES "' got '%s'\n", = str); + return -1; + } + + if (STRNEQ(eol, TEST_SPACES)) { + fprintf(stderr, "expected empty string, got '%s'\n", eol); + return -1; + } + + return 0; +} + +#undef TEST_SPACES +#undef TEST_STR + + struct stringSearchData { const char *str; const char *regexp; @@ -463,6 +508,9 @@ mymain(void) if (virTestRun("virStringSortCompare", testStringSortCompare, NULL) < = 0) ret =3D -1; =20 + if (virTestRun("virSkipSpacesBackwards", testSkipSpacesBackwards, NULL= ) < 0) + ret =3D -1; + #define TEST_SEARCH(s, r, x, n, m, e) \ do { \ struct stringSearchData data =3D { \ --=20 2.51.2