From nobody Wed Jan 15 10:46:10 2025 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1704470349943245.73863850295413; Fri, 5 Jan 2024 07:59:09 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id BEF9E1862; Fri, 5 Jan 2024 10:59:08 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 6FFE71A3F; Fri, 5 Jan 2024 10:54:29 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 8C25E19A9; Fri, 5 Jan 2024 10:54:16 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D5A821994 for ; Fri, 5 Jan 2024 10:53:54 -0500 (EST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-445-QLhCjvsQMUSPV_IY-6v8cg-1; Fri, 05 Jan 2024 10:53:48 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DEC8185A589 for ; Fri, 5 Jan 2024 15:53:47 +0000 (UTC) Received: from orkuz (unknown [10.45.224.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id A2D591C060B2 for ; Fri, 5 Jan 2024 15:53:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: QLhCjvsQMUSPV_IY-6v8cg-1 From: Jiri Denemark To: devel@lists.libvirt.org Subject: [libvirt PATCH 2/3] virsh migrate: Add --postcopy-preempt option Date: Fri, 5 Jan 2024 16:53:38 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: LKVHYU4LUJKIAQR44K3G5VE5VHIC2ZRM X-Message-ID-Hash: LKVHYU4LUJKIAQR44K3G5VE5VHIC2ZRM X-MailFrom: jdenemar@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1704470350548100001 This new option will enable VIR_MIGRATE_POSTCOPY_PREEMPT flag. Signed-off-by: Jiri Denemark --- docs/manpages/virsh.rst | 9 ++++++--- tools/virsh-domain.c | 6 ++++++ 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index ed1027e133..4d55665ac1 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -3373,9 +3373,9 @@ migrate [--persistent] [--undefinesource] [--suspend] [--copy-storage-all] [--copy-storage-inc] [--change-protection] [--unsafe] [--verbose] [--rdma-pin-all] [--abort-on-error] [--postcopy] - [--postcopy-after-precopy] [--postcopy-resume] [--zerocopy] - domain desturi [migrateuri] [graphicsuri] [listen-address] [dname] - [--timeout seconds [--timeout-suspend | --timeout-postcopy]] + [--postcopy-after-precopy] [--postcopy-resume] [--postcopy-preempt] + [--zerocopy] domain desturi [migrateuri] [graphicsuri] [listen-addre= ss] + [dname] [--timeout seconds [--timeout-suspend | --timeout-postcopy]] [--xml file] [--migrate-disks disk-list] [--disks-port port] [--compressed] [--comp-methods method-list] [--comp-mt-level] [--comp-mt-threads] [--comp-mt-dthreads] @@ -3428,6 +3428,9 @@ Once migration is running, the user may switch to pos= t-copy using the ``migrate-postcopy`` command sent from another virsh instance or use *--postcopy-after-precopy* along with *--postcopy* to let libvirt automatically switch to post-copy after the first pass of pre-copy is fini= shed. +The *--postcopy-preempt* option can be used to speed up handling page faul= ts on +the destination host caused by accessing a memory page that was not migrat= ed yet +by letting such pages preempt migration of other memory pages. The maximum bandwidth consumed during the post-copy phase may be limited u= sing *--postcopy-bandwidth*. The maximum bandwidth consumed during the pre-copy= phase may be limited using *--bandwidth*. In case connection between the hosts b= reaks diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 58d5a4ab57..25b41cab22 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -11014,6 +11014,10 @@ static const vshCmdOptDef opts_migrate[] =3D { .type =3D VSH_OT_BOOL, .help =3D N_("resume failed post-copy migration") }, + {.name =3D "postcopy-preempt", + .type =3D VSH_OT_BOOL, + .help =3D N_("let post-copy requests preempt normal migration stream") + }, {.name =3D "zerocopy", .type =3D VSH_OT_BOOL, .help =3D N_("use zero-copy mechanism for migrating memory pages") @@ -11182,6 +11186,7 @@ doMigrate(void *opaque) { "abort-on-error", VIR_MIGRATE_ABORT_ON_ERROR }, { "postcopy", VIR_MIGRATE_POSTCOPY }, { "postcopy-resume", VIR_MIGRATE_POSTCOPY_RESUME }, + { "postcopy-preempt", VIR_MIGRATE_POSTCOPY_PREEMPT }, { "zerocopy", VIR_MIGRATE_ZEROCOPY }, { "tls", VIR_MIGRATE_TLS }, { "parallel", VIR_MIGRATE_PARALLEL }, @@ -11530,6 +11535,7 @@ cmdMigrate(vshControl *ctl, const vshCmd *cmd) VSH_EXCLUSIVE_OPTIONS("copy-storage-all", "copy-storage-inc"); VSH_REQUIRE_OPTION("postcopy-after-precopy", "postcopy"); VSH_REQUIRE_OPTION("postcopy-resume", "postcopy"); + VSH_REQUIRE_OPTION("postcopy-preempt", "postcopy"); VSH_REQUIRE_OPTION("timeout-postcopy", "postcopy"); VSH_REQUIRE_OPTION("persistent-xml", "persistent"); VSH_REQUIRE_OPTION("tls-destination", "tls"); --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org