From nobody Sun Feb 8 22:21:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1565709888; cv=none; d=zoho.com; s=zohoarc; b=Ubr6VfDZS06jBdtHqlVJ8xc5OWd+lITqojnBCuEXz+mxMkgMl7F8+s8t0Cy3gdBdEQmZxUCM3cuAiaQzdzDg3nmDfhNqsJwsVasFY2PJfrGXHyOUTLbpiIAZ2P1Ba6e1GwdknjejvaRlp6RwLdL6BIJel/K1bJVycO8QaMpa5Xo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565709888; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=aVP7v1fofeD8lWGNQ9eD0soVQTb3pd2kxik5Y8nyq4s=; b=nV4hRVfzAu9C/jgsdDwH1WJ6nON7UFNv/mwEDUREEkLfuDqflEkrw9jyGw2xGzD88Nq704du45o5qBY+Wl1XHCEpU0QZEdpaW7QDUY7jvMSuyHK8fTRpfGohM2b09ksnAqAZj4pstEx5x44hLsFiCrQ1RfCR08H47/Oo3INXszU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 156570988896021.409329267290786; Tue, 13 Aug 2019 08:24:48 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8F750806CF; Tue, 13 Aug 2019 15:24:47 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6BEEB6E6FB; Tue, 13 Aug 2019 15:24:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2DD05180BA9C; Tue, 13 Aug 2019 15:24:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x7DFOWol009116 for ; Tue, 13 Aug 2019 11:24:32 -0400 Received: by smtp.corp.redhat.com (Postfix) id 58C8982486; Tue, 13 Aug 2019 15:24:32 +0000 (UTC) Received: from icr.brq.redhat.com (unknown [10.43.2.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id D84F837DE for ; Tue, 13 Aug 2019 15:24:31 +0000 (UTC) From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Date: Tue, 13 Aug 2019 17:24:25 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/3] util: do not repeat the pm-is-supported string X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 13 Aug 2019 15:24:48 +0000 (UTC) Use a 'binary' variable to hold it. Signed-off-by: J=C3=A1n Tomko --- src/util/virnodesuspend.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/util/virnodesuspend.c b/src/util/virnodesuspend.c index af0ed615e1..62e62bb171 100644 --- a/src/util/virnodesuspend.c +++ b/src/util/virnodesuspend.c @@ -239,22 +239,23 @@ static int virNodeSuspendSupportsTargetPMUtils(unsigned int target, bool *supported) { VIR_AUTOPTR(virCommand) cmd =3D NULL; + const char *binary =3D "pm-is-supported"; int status; =20 *supported =3D false; =20 switch (target) { case VIR_NODE_SUSPEND_TARGET_MEM: - cmd =3D virCommandNewArgList("pm-is-supported", "--suspend", NULL); + cmd =3D virCommandNewArgList(binary, "--suspend", NULL); break; case VIR_NODE_SUSPEND_TARGET_DISK: - cmd =3D virCommandNewArgList("pm-is-supported", "--hibernate", NUL= L); + cmd =3D virCommandNewArgList(binary, "--hibernate", NULL); break; case VIR_NODE_SUSPEND_TARGET_HYBRID: - cmd =3D virCommandNewArgList("pm-is-supported", "--suspend-hybrid"= , NULL); + cmd =3D virCommandNewArgList(binary, "--suspend-hybrid", NULL); break; default: - return ret; + return -1; } =20 if (virCommandRun(cmd, &status) < 0) --=20 2.19.2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list