From nobody Mon Feb 9 00:56:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1667896280; cv=none; d=zohomail.com; s=zohoarc; b=gsMUXs4JsIhFB+SQYH7gZMb9JU71vYiH2NIClzf6C9Gt5k8Xv4fTXVpLSaxLwmFjs/4mExwrnePPHeOlWh4wMtOr/CU4fT9XHpvEIFPDfDBPIUny7M1pFGZDHZn0J0qcjNFNu360Mwn9tJTl2lpvcNYqMFUBToY1B37UfQPqMSI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1667896280; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9yUizZmo/uEGhv5BWZ9vvZtqlVR/X36NAeuHcOR4c2E=; b=LkVdf+f0f+aJnQJjh77eVsUzwzFaIZj+AXqabBK+HMOaYF8F3oKY1JZTWP07tl0B0OtAOCoYXP2E8DQzcnMM82w+mAuApFsPHYtd27OFo4ehOq3KLe7IEYsmQFZ6uZlkc1jILShTVJrwpLgAl6edeZ/KDWH+4swf8eX2/sNa5XY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1667896280154442.2005588978358; Tue, 8 Nov 2022 00:31:20 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-493-tZzH2bZ6OBCNvxysxxQI8w-1; Tue, 08 Nov 2022 03:30:22 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5F8368027EC; Tue, 8 Nov 2022 08:30:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C25340C947B; Tue, 8 Nov 2022 08:30:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 220A21946587; Tue, 8 Nov 2022 08:30:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1C6F31946594 for ; Tue, 8 Nov 2022 08:30:10 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 020DB4C816; Tue, 8 Nov 2022 08:30:10 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 994C610197 for ; Tue, 8 Nov 2022 08:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667896279; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9yUizZmo/uEGhv5BWZ9vvZtqlVR/X36NAeuHcOR4c2E=; b=ZH6IXNq9MVHSIIG4uur9qG2GMpHJ/TmZmlSUg1cODvcQEyaA7S6mqqj91pfUCBbVAazRz7 MUsrRW8T2CxpZa6hEJ0fkAsDfsYa8Qaj8DH6NGPKFzHlTjE8aUMosD7CZLSyoHtzA/V2ce 32pUSY/0UwW4w/74VkhcNGqCIEVBAHY= X-MC-Unique: tZzH2bZ6OBCNvxysxxQI8w-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 28/48] qemu: Assume QEMU_CAPS_VIRTIO_NET_TX_QUEUE_SIZE Date: Tue, 8 Nov 2022 09:29:30 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1667896281077100007 Content-Type: text/plain; charset="utf-8"; x-default="true" Introduced in QEMU's commit of v2.10.0-rc0~95^2~20 the .tx_queue_size attribute of virtio-net device is always available for all QEMU versions we support (4.2.0, currently). Therefore, we can assume the capability is always set and thus doesn't need to be checked for. Signed-off-by: Michal Privoznik Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_validate.c | 6 ------ tests/qemuxml2argvtest.c | 3 +-- tests/qemuxml2xmltest.c | 3 +-- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 74631378c6..88f2aa8c49 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -1874,12 +1874,6 @@ qemuValidateDomainDeviceDefNetwork(const virDomainNe= tDef *net, _("tx_queue_size has to be a power of two")= ); return -1; } - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_NET_TX_QUEUE_SI= ZE)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("virtio tx_queue_size option is not suppo= rted " - "with this QEMU binary")); - return -1; - } } =20 if (net->driver.virtio.rss && diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 98ba6633f8..029e60947f 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1465,8 +1465,7 @@ mymain(void) DO_TEST_NOCAPS("net-virtio-disable-offloads"); DO_TEST_NOCAPS("net-virtio-netdev"); DO_TEST_CAPS_ARCH_LATEST("net-virtio-ccw", "s390x"); - DO_TEST("net-virtio-rxtxqueuesize", - QEMU_CAPS_VIRTIO_NET_TX_QUEUE_SIZE); + DO_TEST_NOCAPS("net-virtio-rxtxqueuesize"); DO_TEST_PARSE_ERROR_NOCAPS("net-virtio-rxqueuesize-invalid-size"); DO_TEST("net-virtio-teaming", QEMU_CAPS_VIRTIO_NET_FAILOVER, diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 22397f209f..e8261b7e8c 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -467,8 +467,7 @@ mymain(void) DO_TEST_NOCAPS("net-eth-hostip"); DO_TEST_NOCAPS("net-eth-unmanaged-tap"); DO_TEST_NOCAPS("net-virtio-network-portgroup"); - DO_TEST("net-virtio-rxtxqueuesize", - QEMU_CAPS_VIRTIO_NET_TX_QUEUE_SIZE); + DO_TEST_NOCAPS("net-virtio-rxtxqueuesize"); DO_TEST("net-virtio-teaming", QEMU_CAPS_VIRTIO_NET_FAILOVER, QEMU_CAPS_DEVICE_VFIO_PCI); --=20 2.37.4