From nobody Sun Feb 8 12:32:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601967570; cv=none; d=zohomail.com; s=zohoarc; b=QDW27vRCHS8A/yV2RPN03tSlUyBdu26ReP15+hcB8rwebyEKTmqXZDsXQTtOg0gxCQptdtA+IGVJjGmxFRIMqPrJz+UPMZke2SCrhCzFB4VD0nfjwvumRAmdnVWzbpRhwQlj32I07i9OfQVtlhQ0UlW9yK6nEIyYkeNJwSyRAYc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601967570; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OrQrLLpD8XfNNPWaZ7v9yz/48oAtCok8wCORbDUz3FY=; b=HGt6+Sz31CiNGOvjWKvV9LZUrQ66XFH99yJfWkhOeqfFv6no28JfckoXaCHByfbM7WRbsRHM5B9o3Kw3/hWXgcf3RKLNQe9WNkAhujzcTZQkCuLXcl+s8F776tUQBm6tcsbrYC7oK+wFFKbGoB4iX5d/LnG/p9IioB+WIRXRFIw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1601967570465881.596293300454; Mon, 5 Oct 2020 23:59:30 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-546-8d6oprodMkCB1HDMexcm_g-1; Tue, 06 Oct 2020 02:59:24 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1938210866AF; Tue, 6 Oct 2020 06:59:17 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EADC960BFA; Tue, 6 Oct 2020 06:59:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B5FA5181A55A; Tue, 6 Oct 2020 06:59:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0966x1LP018633 for ; Tue, 6 Oct 2020 02:59:02 -0400 Received: by smtp.corp.redhat.com (Postfix) id EDD085C1BD; Tue, 6 Oct 2020 06:59:01 +0000 (UTC) Received: from hjs.redhat.com (unknown [10.43.2.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 75B905C1C4 for ; Tue, 6 Oct 2020 06:59:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601967567; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=OrQrLLpD8XfNNPWaZ7v9yz/48oAtCok8wCORbDUz3FY=; b=IO4yoHlJq9bQKSj5XeiCn9PNoTVrP95Z9mIMpwEOP/rJ2GjfbVvEceNu7zNwvTRdNqN9pw vzIs0PcG7zC2V6F34cdutVuXNC3qxOEdSxaQHmjtLdTVMOtmE5uOY9erXyd04zZD3swP5p l5/mgV6x4fJWW/AQMvH9aJAENCnEglA= X-MC-Unique: 8d6oprodMkCB1HDMexcm_g-1 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: libvir-list@redhat.com Subject: [libvirt PATCH 07/14] qemu: agent: use virHashNew Date: Tue, 6 Oct 2020 08:58:43 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) We're passing 'ifaces_count' to virHashCreate as the initial hash table size just after we've initialized it to zero. This translates to a default of 256 inside virHashCreateFull. Instead of this obfuscation, use virHashNew (default of 32), to make it obvious we don't care about the initial hash size. Also remove the error handling, since neither of the functions return any errors after switching to g_new0. Signed-off-by: J=C3=A1n Tomko --- src/qemu/qemu_agent.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 3b92b2ec33..d0319cc0c7 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -2129,10 +2129,7 @@ qemuAgentGetInterfaces(qemuAgentPtr agent, virHashTablePtr ifaces_store =3D NULL; =20 /* Hash table to handle the interface alias */ - if (!(ifaces_store =3D virHashCreate(ifaces_count, NULL))) { - virHashFree(ifaces_store); - return -1; - } + ifaces_store =3D virHashNew(NULL); =20 if (!(cmd =3D qemuAgentMakeCommand("guest-network-get-interfaces", NUL= L))) goto cleanup; --=20 2.26.2