From nobody Mon Feb 9 10:30:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612186763; cv=none; d=zohomail.com; s=zohoarc; b=ReIVx/GPH3tV+hJL8i5xhwBrq7kZF+TV6DIS9IMt9mVD78a8upaT1xdGmA0/pXI550EqQg6dLOu89JlaE3n9WLqkK6ukRjiTQi1pP1IoDDXqd7IX5vAme0uGR0r/+nDIlVFXFvRn1ibzaWlMqD+J35R2pLPfXItGYa/LmC7WFOo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612186763; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=p01/cN/wvri86QKZJ2uBPJH5wvDYqdfWyZhNhE/5AvQ=; b=G7Rl26ZhpwFEOtO/Xi8hPlzLZWGXEl+OfKFVS1oG0s+U0NX22yyrnj8KYTfgNLwfcKKy7ZPSkPHd6/XjWxHbF4sHCg8cPhhx8qb9TOYoXVFoPP3MwDr073FyzqVZuqnF3fQc0F+UlW8YjB4m84TmnwCHsKuTwMtVwjEGVjgLOrk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1612186763368635.5827678733549; Mon, 1 Feb 2021 05:39:23 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-198-AjcQ9VBZM-2oAUjP8CItRA-1; Mon, 01 Feb 2021 08:39:20 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B656CCC622; Mon, 1 Feb 2021 13:39:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B4835D735; Mon, 1 Feb 2021 13:39:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0F9491809C9F; Mon, 1 Feb 2021 13:39:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 111DdCxX023332 for ; Mon, 1 Feb 2021 08:39:12 -0500 Received: by smtp.corp.redhat.com (Postfix) id 43B3160C68; Mon, 1 Feb 2021 13:39:12 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 99AC460C66 for ; Mon, 1 Feb 2021 13:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612186762; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=p01/cN/wvri86QKZJ2uBPJH5wvDYqdfWyZhNhE/5AvQ=; b=dsxuebPPwm+9pccSECKHGgvo7h1q+elMBKn4D3Dw29xRi/KWv+bfwFZ9jY+gL/VWdGUhuS wkM/Fyv5PtWCz+YRIeOBWu3P5wzMolGW18goJT6tNl6DeAoQw7zSWt4wVzhE0yglMVZYkE EMLQU1WAErvAwSYTEwYOl27jsKD/W3o= X-MC-Unique: AjcQ9VBZM-2oAUjP8CItRA-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 01/14] hypervFreeInvokeParams: Don't use VIR_DISPOSE_N for freeing 'params' Date: Mon, 1 Feb 2021 14:38:53 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The struct doesn't contain any secrets to clear before freeing and even if it did VIR_DISPOSE_N wouldn't help as the struct contains only pointers thus the actual memory pointing to isn't sanitized. Just free the params array pointer and then the struct itself. Signed-off-by: Peter Krempa --- src/hyperv/hyperv_wmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index a28bb0e815..3bb75392a7 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src/hyperv/hyperv_wmi.c @@ -184,8 +184,8 @@ hypervFreeInvokeParams(hypervInvokeParamsListPtr params) } } - VIR_DISPOSE_N(params->params, params->nbAvailParams); - VIR_FREE(params); + g_free(params->params); + g_free(params); } --=20 2.29.2