From nobody Tue Sep 9 03:39:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (Bad Signature); dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1745495909563145.36300762230394; Thu, 24 Apr 2025 04:58:29 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 71638A1E; Thu, 24 Apr 2025 07:58:28 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 392F0A1B; Thu, 24 Apr 2025 07:58:05 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id C2E4FB0C; Thu, 24 Apr 2025 07:23:19 -0400 (EDT) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2045.outbound.protection.outlook.com [40.107.20.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AA068A7E for ; Thu, 24 Apr 2025 07:23:18 -0400 (EDT) Received: from AM8P189CA0003.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:218::8) by AM0PR10MB3204.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:18c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.25; Thu, 24 Apr 2025 11:23:14 +0000 Received: from AM3PEPF0000A794.eurprd04.prod.outlook.com (2603:10a6:20b:218:cafe::22) by AM8P189CA0003.outlook.office365.com (2603:10a6:20b:218::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8655.36 via Frontend Transport; Thu, 24 Apr 2025 11:23:14 +0000 Received: from eu1.smtp.exclaimer.net (104.40.229.156) by AM3PEPF0000A794.mail.protection.outlook.com (10.167.16.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.12 via Frontend Transport; Thu, 24 Apr 2025 11:22:59 +0000 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (104.47.11.104) by eu1.smtp.exclaimer.net (104.40.229.156) with Exclaimer Signature Manager ESMTP Proxy eu1.smtp.exclaimer.net (tlsversion=TLS12, tlscipher=TLS_DIFFIEHELLMAN_WITH_AES256_NONE); Thu, 24 Apr 2025 11:23:00 +0000 Received: from VE1PR10MB3901.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:800:164::18) by PAWPR10MB7198.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:2f1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.25; Thu, 24 Apr 2025 11:22:48 +0000 Received: from VE1PR10MB3901.EURPRD10.PROD.OUTLOOK.COM ([fe80::9be8:516d:147e:42e3]) by VE1PR10MB3901.EURPRD10.PROD.OUTLOOK.COM ([fe80::9be8:516d:147e:42e3%6]) with mapi id 15.20.8678.021; Thu, 24 Apr 2025 11:22:48 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, FORGED_SPF_HELO,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.4 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=nuDkWvmRI5VUSMYXnr0X9d1lnx7ejxcU6CI6VbNmCEmOtubOz7d4/c58BiKFPV7ZT37E8mXTLWbvD5qH0gUHaHBJk39JOgkgx9CutZ86avp8qYlFMwjKIkaES1MYKvT4ADNtMkknNAFy6IbMjqSh+Gm7V3XYHCOCdryYsEACN9TT19JEfwM6Pi0iYZupkSOelkGp9wD73qw0bWV2sCIYhLIGo16iY+aaKIpI5V1OFCNKBNvumUSbdfnU8Bgu2KW7AU8KdCCXKQWf+9FweXskH6Ayq2HX72AG7Gb630omTZ4MfIPAvSaWaQrU3Lh4jHQS6CkwSeBHb6XeZ4Kd+KaTpQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pS+jltNqQaSHN+5IJohIJZWe8ayRc+6Ha+XII+9aVcs=; b=QAdoaZw2OgAFQgRR/X+fDPG7sI5N86IdESt4oXH1rSMrwbA6lvAGsKpeGCAO+J55FDeFUv/b55BRcjxcTm5cV3VIasN0Dqi7jmTP90a3Xiu/2P3CQT/pNowjuLDT+cgOHL5BArCdSiQPxValV8TbBsEmA5ByJ4Qhr6HDmUmkVMO0z2Z/6ZweiDg8KxtS3C5FIss0IPhiG9HJji9S+NRzoTiqBG1J9roNj/tWKqga3H0bBzAgRY8oMgwk52/ym+D2/C1yaYSS+qbde6YbnnJe1l9Q9kIrl1BA3jm6uiv1EMWsfN9ho88/zjhds/9g3eoA5XX1TMo7aPZwQjaHB4Si3g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 104.40.229.156) smtp.rcpttodomain=lists.libvirt.org smtp.mailfrom=stackit.cloud; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=stackit.cloud; dkim=pass (signature was verified) header.d=stackit.cloud; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=stackit.cloud] dkim=[1,1,header.d=stackit.cloud] dmarc=[1,1,header.from=stackit.cloud]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stackit.cloud; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pS+jltNqQaSHN+5IJohIJZWe8ayRc+6Ha+XII+9aVcs=; b=AzWTUzobANQ6RsP32cppmrqB+11DO9TUCsvav+Jxwt1vS1QJN7EEY8VMMvCjRVqdOwh3jmpDZ84a3h/yO1+dUjQRZ+HUEThmncMrcX5Gn3vkgYP42KtiRci+0Y+5/EabgCKXiXp7L2jjxRRVZ07eRvaRHB55y1Bv1SlOKqj6Hnko1hlQ0Mx+qcrnSz3AtOxTYbGo56e3/8bXE4iX+qzrQ8LzFuRMRDliscm9vDbIRAharb0JbuNfGLwDg0mID9t1/ysn/K7KMq7yJrHYXINl33Dm+D6lbOkWDPspKECXcXwB460515TmMX1QKYaPOwwuuEOe79ANLspFWk2PgqV+Ng== X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 104.40.229.156) smtp.mailfrom=stackit.cloud; dkim=pass (signature was verified) header.d=stackit.cloud;dmarc=pass action=none header.from=stackit.cloud; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: Pass (protection.outlook.com: domain of stackit.cloud designates 104.40.229.156 as permitted sender) receiver=protection.outlook.com; client-ip=104.40.229.156; helo=eu1.smtp.exclaimer.net; pr=C X-ExclaimerHostedSignatures-MessageProcessed: true X-ExclaimerProxyLatency: 107152053 X-ExclaimerImprintLatency: 5390223 X-ExclaimerImprintAction: 03476720f9ec446ea5870e26bb067247 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KWIrf3Zp/qXjujJtilzKAU2nqwzkExV9GQvUcXF7YrpgOMWFqqwUXNgDRcvoxzahFp4CQ0HfZ42ZZVyYmmBBOz7hKEYrL5/PoSVnVHHMUS2pUBHcAXBiWuvtJbtcV29NrSaBqPvTnarZTtYnljj3c16QYpBxuBZO02z8yEAhaynSPRbgdRtpkRoYTvjlNaZ0lp47yI5u6ZR8m/pFtzbmyw24Og5H7pgk9sB9Dh73nNCS+B/IlCCiCVaXssVlNifsRgfw2NUF7HD7F/MVyTWeobrV8Soxx8aeNgqivfeQFMYxTMLfq2LQt556Zt6uJmPihDOAo1v0bEHJp1bc/CZlsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pS+jltNqQaSHN+5IJohIJZWe8ayRc+6Ha+XII+9aVcs=; b=NnJLvbLhJLkW/7RthdeGddsJBygwjXidNUhgjR9JCcu4T0IVA87eFwWYODFwehoelV6RMoOooLPOvcc8HN2WCaveyiR4lNCTo5blQu2CWnW1B2XDcOpUe6dH+2JOzRz2vCf/PHVn7QBJcpLh6LHVpKyRQixOnnW/g3jMevKLxept3RL2Pwj1XK3EVKzLPrVkZNLCCUagDp//uSP955gDOHBr8yvclFdMR/9CPZKOhHC316t2vWHNBoLrMpbrwCy9PeLVjTkVXxuYS0UFduQZ58pqPMX6bbUfT88/AIiwmAGurVGctnoGPRlVi6xN7gxhzdDpFta4JITNqOEWozSYnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=stackit.cloud; dmarc=pass action=none header.from=stackit.cloud; dkim=pass header.d=stackit.cloud; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stackit.cloud; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pS+jltNqQaSHN+5IJohIJZWe8ayRc+6Ha+XII+9aVcs=; b=AzWTUzobANQ6RsP32cppmrqB+11DO9TUCsvav+Jxwt1vS1QJN7EEY8VMMvCjRVqdOwh3jmpDZ84a3h/yO1+dUjQRZ+HUEThmncMrcX5Gn3vkgYP42KtiRci+0Y+5/EabgCKXiXp7L2jjxRRVZ07eRvaRHB55y1Bv1SlOKqj6Hnko1hlQ0Mx+qcrnSz3AtOxTYbGo56e3/8bXE4iX+qzrQ8LzFuRMRDliscm9vDbIRAharb0JbuNfGLwDg0mID9t1/ysn/K7KMq7yJrHYXINl33Dm+D6lbOkWDPspKECXcXwB460515TmMX1QKYaPOwwuuEOe79ANLspFWk2PgqV+Ng== Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=stackit.cloud; Date: Thu, 24 Apr 2025 13:22:46 +0200 To: devel@lists.libvirt.org Subject: [PATCH] virhostcpu: Fix potential use of unallocated memory Message-ID: Content-Disposition: inline X-please-dont-add-a-signature: thanks X-ClientProxiedBy: FR2P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::20) To VE1PR10MB3901.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:800:164::18) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VE1PR10MB3901:EE_|PAWPR10MB7198:EE_|AM3PEPF0000A794:EE_|AM0PR10MB3204:EE_ X-MS-Office365-Filtering-Correlation-Id: f96c137b-8ede-4188-2331-08dd83225f2b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info-Original: =?us-ascii?Q?YY1Sm9q8zi6MuiU+s2njqJr/k7W5LQzL+Mb1A+AY+h1Ly42VtmEluV6E6ASm?= =?us-ascii?Q?JD2TS8kcnaBlYRDVj5Pb9pdKuSMSYohrSttX8QSGGU3AdfOtG2hSuk1XyknF?= =?us-ascii?Q?+VUcCt5T+EmrirClX17Gh2V6m4pIQj9ys0sMMp5dgGW/R82fB28mSgOFfe7u?= =?us-ascii?Q?oxqdDTTqvrRm4Hrlwqg1uXa//7m18646IE+CG73KBr34bBiFYGWZQElybibe?= =?us-ascii?Q?CqhOn3RfcpwLftBy11DulqodobF5TYdlkw2jTcUARRuDaY0Cq3vtTJk+WzRK?= =?us-ascii?Q?jTR90ipHc1tESR/cZYlkbAFoPYm1q9oHzjsnBxUTtJ/Vl/IpW+o8if/8qrz7?= =?us-ascii?Q?u8GdrvherXiSF4+UPke019O8oJQrrKfa939s4hceg4VldVGUsLXUhfGB8j5+?= =?us-ascii?Q?QnXr2exV5etBPzuHw6/PxJnk22CxxHvOZystIB/NaEsLe57u/xW4aaS1gw8J?= =?us-ascii?Q?8u86ePXCjxvyfmq67KMaYDQysjLt6o65s46qXRY7NldkD7VZ0TJYVjPNIjbl?= =?us-ascii?Q?tCrHrxv+MYvzrJzIiCGx/94lLUCDCUymE7WMB+sSYSHosFqHo7Iprg/TF9qU?= =?us-ascii?Q?TfXuMp79HXgnw7kEdyfsYUgXHOckOWBPfEUCWXbP7O80UWM1WXhb/zmi1WZD?= =?us-ascii?Q?EafO58sMokVRfW6zrMss/RRB/WT/3z2CdtS14waAiJ2WHVRc1URPr5aAPLPB?= =?us-ascii?Q?rOyv6eLTYsQNLY7+5amPCId1CjHEruNUKhIpFh8Ya0HxDefdi9R7bNJFwWvh?= =?us-ascii?Q?q4jJwHTo21Hx5I+m+CKewbbsMvjMIYqb4yLpJIrTNCznH9alUx0xedAPdroK?= =?us-ascii?Q?wimJZ76bzeIBLNLVea6nDQX4poLjBS6FtVeJfex0x03Si6litNbjeHXgAJTD?= =?us-ascii?Q?q+Gx6q1v67YZo3yplywpNnBjSmZlBm8hZMz48T8Vmmsunhhu/j6/ew7bFRk7?= =?us-ascii?Q?iORGgm+YlL69jTJutomdiYeMZAQdNy5bog0UL77ZE6FwVWAkMW8WfP0ZGYTj?= =?us-ascii?Q?+T3uIeJEbWJIR+Yw9sLDk7/7YthXfVCEuNRimc0hNnQnwP1bssGRMqLGyxtu?= =?us-ascii?Q?kVfiE23/W8sW8jZOc1M5YOZl5AI4C99ZwgbsJ9C0eJcRr56wLrA9wFfFy6Tz?= =?us-ascii?Q?XOrv0y1AeLmQdLA7zuiYJcXOAqvNQs3i7FCy1eQTyVmgQUjELjmdTwaTDE3M?= =?us-ascii?Q?va2nJN1XFyJAhTT1a/hRE18ZyhYSM+MhQap5lhqw1bvUUZ3Bmyhq3SgJiwJI?= =?us-ascii?Q?pi+SUFt8oZdQUFBqSmGumzAhq+0M/l2R9d87GMdaKwQfwtn9iFxrKFfPyR6U?= =?us-ascii?Q?bJccA9W94+8iTDzks5tGpAD79THkOMc2lGS03YsHpaiHmFBZvjlb/nXn/LoC?= =?us-ascii?Q?vge4LGVxMHG9etq8uioR396Edgb4QjWfVxBx6h4Pk0wTAXRPxWs+0UYuAhQV?= =?us-ascii?Q?sdP+hqVSpj0=3D?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR10MB3901.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR10MB7198 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM3PEPF0000A794.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ad8b4dbf-ce7b-4e34-12f9-08dd832257e1 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|376014|35042699022|82310400026|14060799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?wMd0N3wXPkRVmH3jMjtjKrWs6zl7DUgawGUlfBJoDLNSPJlwtK20OxwO7MV4?= =?us-ascii?Q?wZErqpy2kipuN++FbycvYQos9mtvD0jBw77uL2VlH1TjDYzoovvh6QnNPTFE?= =?us-ascii?Q?EYEI3xOajVdsZBmZMRSb+qy0QE0FCuXTBX1Omd5+uLI1TLCfVN3m3ES/XSjL?= =?us-ascii?Q?mGwZnri1wmGdfDepCrMsBw9rWEtj66gFNL/DegLs9jhQHZsx1i0tPvm1UfHS?= =?us-ascii?Q?8yAmqNmZXMecyoZgW9G+bSB1FQo6ab1ZQWn0Qb0ttspxUwQBCCab9np/99hX?= =?us-ascii?Q?FYz9Ei51a5GfZO0OAle2ejm9xkJVVDOQDuBDafXyJYkgeJlQZQt5ZuuOtkwn?= =?us-ascii?Q?kbIKa8uwJThHBrJU+B6lJiKzdbRFL+preGNKP6W1LlYG2EXK8ACgAsgQzhsq?= =?us-ascii?Q?Zgvt7cau3JtLSNTbi1i9UbGYJD2jKABMM/zsqdiDfpCNHHU+iFLdhfwrlrHb?= =?us-ascii?Q?vVRtUXmu9vZrz7Eqq9wyCrzdw6K0Em61BvZgkGS9t8OGvk6uMwcJbjCm6jpI?= =?us-ascii?Q?ekyFKDOlPdxRoPZF7x75HJOOjtK2awJmRN5p+KYTM8iwDNxh/sEplfDpMs5t?= =?us-ascii?Q?Q2taWmHWRkTMac4YW0nUYYTZ5FTAk/UUsMSMc2QlKcsnLstlDLcJ0cwDxdle?= =?us-ascii?Q?JjQuD+Bb/PuLyjTRnBKWZlKX8ENlSlkiS4+yZedeDn9QAtrcRmGfP+eKrBze?= =?us-ascii?Q?r3cR1Md/jA1+ElrcWOxn0Tgry1rWGtE40XA6AiRPk1cSsdl1bHVb8n+2J9RZ?= =?us-ascii?Q?eZeHE0Qvi8pCj8GcrRMeOuyi1DmPYjYxN+p6Lpr+K21TI5zGuPHZOUWcxkd6?= =?us-ascii?Q?wNlyQgIv1qnvEtrmAcSpPa0CL88XerZla5Ii/euSsgAIzKk1vgIzM6sFM3BM?= =?us-ascii?Q?ct9JR2a7O6kZ7dfmF7mc/7vUvw7sTyzbiH6T3kmhvnP7qUnp1x1hhWTlirB7?= =?us-ascii?Q?7riDtGrhE1DgaLettM9eWWak9lxEqPC7iIsAZsvuhnkZj/I2GaXd89yWmXCt?= =?us-ascii?Q?+aovfKy0+umwvJPVKnkupdwpgHlHlDypRSG7tpMkY30PQ2d5Y368KHdh9gw9?= =?us-ascii?Q?DT97diou1pAQKmRKakRO5l5wPBDuk2U2rPWq1XGQIDvGMzdqum3j6OQCKv4Q?= =?us-ascii?Q?bFwhQP3Uy4QOttZrgeR4VRUT/iwFKHGQE5b7HM9p8MWddgLM7Ro9YfcC2XwX?= =?us-ascii?Q?L7ZIwpVjW1dKqwmxrH/FrVs+k2aEJf5Q84zt8FA6m788eSoYo+z3Ak0NkamY?= =?us-ascii?Q?lDhPRXaHahbnA5TbON12BVyYcymqmtjxYQIvY832wPYFzRCxcPz4rLwDYwAJ?= =?us-ascii?Q?GURLOnu0axJLFD8SSmjlSLEutFECQb2KQG3kEr691x7QlVZAMfQ1yLt/cuEI?= =?us-ascii?Q?7A9NMfb/ebBaqJn9Hk9Y1yOE0WcEtEsHe1fLuJo6KRVh4jGUJr5XJUb+Zfwh?= =?us-ascii?Q?pNgj8A6uAx2K7oJ1XRE27V/cwq3QytdmvXJZyL70fylaylpTJCQPd5fNLDfZ?= =?us-ascii?Q?KbEosTJxgd0cjSCAutpREWCikTgHoIX7OWyH?= X-Forefront-Antispam-Report: CIP:104.40.229.156;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:eu1.smtp.exclaimer.net;PTR:eu1.smtp.exclaimer.net;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(376014)(35042699022)(82310400026)(14060799003);DIR:OUT;SFP:1101; X-OriginatorOrg: stackit.cloud X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2025 11:22:59.9017 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f96c137b-8ede-4188-2331-08dd83225f2b X-MS-Exchange-CrossTenant-Id: d04f4717-5a6e-4b98-b3f9-6918e0385f4c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d04f4717-5a6e-4b98-b3f9-6918e0385f4c;Ip=[104.40.229.156];Helo=[eu1.smtp.exclaimer.net] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A794.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB3204 X-MailFrom: Felix.Huettner@stackit.cloud X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 Message-ID-Hash: QDISM3Q4DCMP3SRHTB5X5JKS5P22CB6H X-Message-ID-Hash: QDISM3Q4DCMP3SRHTB5X5JKS5P22CB6H X-Mailman-Approved-At: Thu, 24 Apr 2025 11:58:02 -0400 X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: From: Felix Huettner via Devel Reply-To: Felix Huettner X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1745495912862019100 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In case of a host that has a large number of cpus offline the count of host cpus and the last bit set in the virHostCPUGetOnlineBitmap might diverge significantly. This can e.g. be the case when disabeling smt via /sys/devices/system/cpu/smt/control. On the host this looks like: ``` $ cat /sys/devices/system/cpu/present 0-255 $ cat /sys/devices/system/cpu/online 0-127 ``` However in this case virBitmapToData previously only allocated 16 bytes for the output bitmap. This is becase the last set bit is on the 15th byte. Users of virHostCPUGetMap however rely on the "cpumap" containing enough space for all existing cpus (so they would expect 32 bytes in this case). E.g. cmdNodeCpuMap relies on this for its output. It will then actually read 32 bytes from the start of the "cpumap" address where in this case the last 16 of these bytes are uninitialized. This manifests itself in flapping outputs of "virsh nodecpumap --pretty" li= ke: ``` $ virsh nodecpumap --pretty CPUs present: 256 CPUs online: 128 CPU map: 0-127,192,194,202 $ virsh nodecpumap --pretty CPUs present: 256 CPUs online: 128 CPU map: 0-127,192,194,197 $ virsh nodecpumap --pretty CPUs present: 256 CPUs online: 128 CPU map: 0-127,192,194,196-197 ``` This in turn potentially causes users of this data to report wrong cpu counts. Note that this only seems to happen with at least 256 phyiscal cpus where at least 128 are offline. We fix this by preallocating the expected bitmap size. Signed-off-by: Felix Huettner --- src/util/virhostcpu.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c index 5dbcc8987c..626faa88cf 100644 --- a/src/util/virhostcpu.c +++ b/src/util/virhostcpu.c @@ -1091,22 +1091,26 @@ virHostCPUGetMap(unsigned char **cpumap, { g_autoptr(virBitmap) cpus =3D NULL; int ret =3D -1; - int dummy; =20 virCheckFlags(0, -1); =20 + ret =3D virHostCPUGetCount(); + if (!cpumap && !online) - return virHostCPUGetCount(); + return ret; =20 if (!(cpus =3D virHostCPUGetOnlineBitmap())) goto cleanup; =20 - if (cpumap) - virBitmapToData(cpus, cpumap, &dummy); + if (cpumap) { + int len =3D (ret + CHAR_BIT) / CHAR_BIT; + *cpumap =3D g_new0(unsigned char, len); + virBitmapToDataBuf(cpus, *cpumap, len); + } + if (online) *online =3D virBitmapCountBits(cpus); =20 - ret =3D virHostCPUGetCount(); =20 cleanup: if (ret < 0 && cpumap) base-commit: c5a73f75bc6cae4f466d0a6344d5b3277ac9c2f4 --=20 2.43.0