From nobody Sun Feb 8 19:56:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1628075032; cv=none; d=zohomail.com; s=zohoarc; b=LB3l0cWliHAdsgDD2+k17KmEevyHldUUh0Lp8+NQW9EX+ZqwHpoJXpOu6pawm4xJO2xvaY/P0JxiTTUPP7TkRdvV+EdUqqpaqKO7LBqUB6xPkb4Rl7gJ3EgGzZFQQWvo17ct/9GbFdBYyaQ12hybVdDHoIUiocxnMrBwPhnd/Z8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628075032; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=R0zq/JbRBRyEbSB2xW9OmhoAU/AKRzwh7PWpmHuOJck=; b=OlRBPS36zzKpvochXQuiIdKFGKbsACLR5JUBmI5YVgydL4fr8f8AXpWWO9DtwWCsviKnNgYoLzyltKfRhb2sQK2fbHcAX7X34DGRVCDHEI3XGFFsvwY/Go1V3PkQbr9E1S7nOSMd5jOLCIuvBR7f5aTzYJU7tExGEDPSviKRGsQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1628075032243372.88111130053176; Wed, 4 Aug 2021 04:03:52 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-272-1Ajis5ytOPi35sbGIYBU0Q-1; Wed, 04 Aug 2021 07:03:49 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EC2B7100671C; Wed, 4 Aug 2021 11:03:42 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CFFB519CBA; Wed, 4 Aug 2021 11:03:42 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 64DAF4A718; Wed, 4 Aug 2021 11:03:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 174B32IT014275 for ; Wed, 4 Aug 2021 07:03:02 -0400 Received: by smtp.corp.redhat.com (Postfix) id 85BC55D9DC; Wed, 4 Aug 2021 11:03:02 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id E402217B73 for ; Wed, 4 Aug 2021 11:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628075031; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=R0zq/JbRBRyEbSB2xW9OmhoAU/AKRzwh7PWpmHuOJck=; b=igA2ZjrSMjOvcp1WBkVTKHzu5TiX31wFUMVcb7j4DQxpkpdWaMQ9a9k4F51K7g4Oew9B2k iN4+God5Hs0JV7Bbo4m0tzTFUCuhECkc3PZed+dNuq3rBrbGIBj2OkBSFNm4TnbzJVXvdT iSHxtzIZ7cl1uhqDO+/uf+CFBOwLGGU= X-MC-Unique: 1Ajis5ytOPi35sbGIYBU0Q-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 12/23] virSecuritySELinuxContextListAppend: Remove unreachable cleanup Date: Wed, 4 Aug 2021 13:02:32 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1628075033594100011 Content-Type: text/plain; charset="utf-8" 'item' is always NULLed-out by VIR_APPEND_ELEMENT and 'ret' variable is always 0 when used so both can be removed. Signed-off-by: Peter Krempa --- src/security/security_selinux.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinu= x.c index 30fb6028aa..9ff35a7be5 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -114,7 +114,6 @@ virSecuritySELinuxContextListAppend(virSecuritySELinuxC= ontextList *list, bool remember, bool restore) { - int ret =3D -1; virSecuritySELinuxContextItem *item =3D NULL; item =3D g_new0(virSecuritySELinuxContextItem, 1); @@ -127,9 +126,7 @@ virSecuritySELinuxContextListAppend(virSecuritySELinuxC= ontextList *list, VIR_APPEND_ELEMENT(list->items, list->nItems, item); - ret =3D 0; - virSecuritySELinuxContextItemFree(item); - return ret; + return 0; } static void --=20 2.31.1