From nobody Sat Feb 7 08:13:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626864202; cv=none; d=zohomail.com; s=zohoarc; b=RPjd7yC6jUD90KYW6vtnBQ4UfWv3hixKq+NiWj/OaqzETUxnferyIZdANTWGlAjw7Iqc3/FGDJvJdB47+4Afhz4imBI3ZUaru8deqZC41uK7hLKtRsT1EeVHvDNkWIyLYLMIeKraaJGPsj7Ifhxw2trmmgWglhBx4XFDAPi4K6w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626864202; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Wjq/wOVxf2797Uj8Yr6HYeyPc45U8jwuKZzA3S+3kSg=; b=AfrYqjKf9hQK0foeyfg+r7vfBf+kGfAKn8a2CWALQrAtQv4rGPswz4nCb+lCcrgdBtIWy4gfznxqC/BNFj/fcXzGMwRRniHqSwmoZpq7QU3KOGJ2j83btj6snAl9uFuXuWmfbJibR9AN1+R/bl7SWbNVjZMRkOEnnWkF4v1Jz8k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626864202530426.68992758417744; Wed, 21 Jul 2021 03:43:22 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-174-ebPSqRO4NKKupq5snRv42w-1; Wed, 21 Jul 2021 06:43:19 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7CF87802575; Wed, 21 Jul 2021 10:43:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF29819D9B; Wed, 21 Jul 2021 10:43:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4B259181A1FE; Wed, 21 Jul 2021 10:43:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 16LAgpqk000832 for ; Wed, 21 Jul 2021 06:42:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id BFD6219D9B; Wed, 21 Jul 2021 10:42:51 +0000 (UTC) Received: from andariel.local (unknown [10.40.193.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2D76F19C79 for ; Wed, 21 Jul 2021 10:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626864201; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Wjq/wOVxf2797Uj8Yr6HYeyPc45U8jwuKZzA3S+3kSg=; b=jFkplem3m+jHGU0R0QO5BlaExtXDVCYAqeS9OYLBpCxwlEaLrr5rXbFdd8+zm3l4F9CYf/ w9PVDTgQ4y2kdPBgwnup8yGF0B7D1xIJbgDSB6x2cfuGBj7kSuD0HsfOnZvp3/suYvsVYG NY9EmVi3quXYIk24cC8b7JLGA9XEgBM= X-MC-Unique: ebPSqRO4NKKupq5snRv42w-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 01/33] qemu: monitor: Remove handlers for the 'POWERDOWN' event Date: Wed, 21 Jul 2021 12:42:13 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626864204274100001 Content-Type: text/plain; charset="utf-8" The qemu process code doesn't register a callback for it so we don't need to be handling it at all. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.c | 11 ----------- src/qemu/qemu_monitor.h | 5 ----- src/qemu/qemu_monitor_json.c | 7 ------- 3 files changed, 23 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index b06c842a7a..628b3fb71d 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -1195,17 +1195,6 @@ qemuMonitorEmitReset(qemuMonitor *mon) } -int -qemuMonitorEmitPowerdown(qemuMonitor *mon) -{ - int ret =3D -1; - VIR_DEBUG("mon=3D%p", mon); - - QEMU_MONITOR_CALLBACK(mon, ret, domainPowerdown, mon->vm); - return ret; -} - - int qemuMonitorEmitStop(qemuMonitor *mon) { diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 6a25def78b..265c25c521 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -169,9 +169,6 @@ typedef int (*qemuMonitorDomainShutdownCallback)(qemuMo= nitor *mon, typedef int (*qemuMonitorDomainResetCallback)(qemuMonitor *mon, virDomainObj *vm, void *opaque); -typedef int (*qemuMonitorDomainPowerdownCallback)(qemuMonitor *mon, - virDomainObj *vm, - void *opaque); typedef int (*qemuMonitorDomainStopCallback)(qemuMonitor *mon, virDomainObj *vm, void *opaque); @@ -372,7 +369,6 @@ struct _qemuMonitorCallbacks { qemuMonitorDomainEventCallback domainEvent; qemuMonitorDomainShutdownCallback domainShutdown; qemuMonitorDomainResetCallback domainReset; - qemuMonitorDomainPowerdownCallback domainPowerdown; qemuMonitorDomainStopCallback domainStop; qemuMonitorDomainResumeCallback domainResume; qemuMonitorDomainRTCChangeCallback domainRTCChange; @@ -447,7 +443,6 @@ int qemuMonitorEmitEvent(qemuMonitor *mon, const char *= event, const char *details); int qemuMonitorEmitShutdown(qemuMonitor *mon, virTristateBool guest); int qemuMonitorEmitReset(qemuMonitor *mon); -int qemuMonitorEmitPowerdown(qemuMonitor *mon); int qemuMonitorEmitStop(qemuMonitor *mon); int qemuMonitorEmitResume(qemuMonitor *mon); int qemuMonitorEmitRTCChange(qemuMonitor *mon, long long offset); diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 7e53e0ce84..ca2c3bb6cf 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -78,7 +78,6 @@ VIR_ENUM_IMPL(qemuMonitorJobStatus, static void qemuMonitorJSONHandleShutdown(qemuMonitor *mon, virJSONValue *= data); static void qemuMonitorJSONHandleReset(qemuMonitor *mon, virJSONValue *dat= a); -static void qemuMonitorJSONHandlePowerdown(qemuMonitor *mon, virJSONValue = *data); static void qemuMonitorJSONHandleStop(qemuMonitor *mon, virJSONValue *data= ); static void qemuMonitorJSONHandleResume(qemuMonitor *mon, virJSONValue *da= ta); static void qemuMonitorJSONHandleRTCChange(qemuMonitor *mon, virJSONValue = *data); @@ -137,7 +136,6 @@ static qemuEventHandler eventHandlers[] =3D { { "MIGRATION", qemuMonitorJSONHandleMigrationStatus, }, { "MIGRATION_PASS", qemuMonitorJSONHandleMigrationPass, }, { "NIC_RX_FILTER_CHANGED", qemuMonitorJSONHandleNicRxFilterChanged, }, - { "POWERDOWN", qemuMonitorJSONHandlePowerdown, }, { "PR_MANAGER_STATUS_CHANGED", qemuMonitorJSONHandlePRManagerStatusCha= nged, }, { "RDMA_GID_STATUS_CHANGED", qemuMonitorJSONHandleRdmaGidStatusChanged= , }, { "RESET", qemuMonitorJSONHandleReset, }, @@ -733,11 +731,6 @@ static void qemuMonitorJSONHandleReset(qemuMonitor *mo= n, virJSONValue *data G_GN qemuMonitorEmitReset(mon); } -static void qemuMonitorJSONHandlePowerdown(qemuMonitor *mon, virJSONValue = *data G_GNUC_UNUSED) -{ - qemuMonitorEmitPowerdown(mon); -} - static void qemuMonitorJSONHandleStop(qemuMonitor *mon, virJSONValue *data= G_GNUC_UNUSED) { qemuMonitorEmitStop(mon); --=20 2.31.1