From nobody Mon Feb 9 01:01:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1663577746; cv=none; d=zohomail.com; s=zohoarc; b=JhwY42AJlkTbfsOAy2lL3QUZd5MS5DCMOWBPORe16tZGrWTGv15HP/02SShtlzSvyiRCkdBW9AmdbC8cRrLoNI/h3TwHydjjNDsmsCP1ggdL4+rYNGW//PZx5beOazl8lCjmlqIO2I666A5RVFbwEdluXXZ/O7qWXXhCgCoHOV8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1663577746; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sv+y42MZKZFoh2g4rRu20atjDRmhZZSF9A+8vnsvk1M=; b=hHdL0q9HzC2ta7qPujRfJjSIao/P6M+grpW2pBQRD+9v52HoNsNSh0ulUqnApCZrwsfZQ2h51vEiU+yjQt+Vy4taMV1w9i8Qk6KfHwSk0c4cMHAvh0yz+y3SwD3qdd2m+grEhcO/7/xiLfv2M88LppZS289eI3018ku7FrNB4nA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 166357774665939.59226340228679; Mon, 19 Sep 2022 01:55:46 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-190-wWsEE_m9PNOz9csK2V8gBQ-1; Mon, 19 Sep 2022 04:55:39 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 73862100DEAB; Mon, 19 Sep 2022 08:55:37 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4F426112131E; Mon, 19 Sep 2022 08:55:37 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 10E071946A41; Mon, 19 Sep 2022 08:55:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C6DEC1946597 for ; Mon, 19 Sep 2022 08:55:35 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id BB20140C6EC3; Mon, 19 Sep 2022 08:55:35 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3892940C6EC2 for ; Mon, 19 Sep 2022 08:55:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663577745; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=sv+y42MZKZFoh2g4rRu20atjDRmhZZSF9A+8vnsvk1M=; b=SGV77pLVq5lc+YSOurbLMIIU/avXjQs/1GhGyWV3DVTdHQiuCNRE/SOBc9rO7x6MpdyWJJ HhQmohI3gvser6P6GUzZqs29JNs2cT65PAvusR8P9nZWkxxQ1osVGLzydHyFWZZghhlSyG ghKGEwn0OvVo+0RQC1QD3ZhJX43H2bM= X-MC-Unique: wWsEE_m9PNOz9csK2V8gBQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 13/37] util: xml: Adjust documentation of virXMLPropString Date: Mon, 19 Sep 2022 10:54:58 +0200 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1663577747086100005 Content-Type: text/plain; charset="utf-8" All callers treat NULL as if the string is not present in the XML. Adjust the description so that it's implied that it's not an error and thus also no error reporting is expected. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/util/virxml.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/virxml.c b/src/util/virxml.c index 04a8b29ba3..eac2d0a73f 100644 --- a/src/util/virxml.c +++ b/src/util/virxml.c @@ -443,7 +443,8 @@ virXMLCheckIllegalChars(const char *nodeName, * * Convenience function to return copy of an attribute value of a XML node. * - * Returns the property (attribute) value as string or NULL in case of fai= lure. + * Returns the property (attribute) value as string or NULL if the attribu= te + * is not present (no error is reported). * The caller is responsible for freeing the returned buffer. */ char * --=20 2.37.1