From nobody Fri Dec 19 04:18:14 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1741880007314132.47671891028892; Thu, 13 Mar 2025 08:33:27 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 44B4F2195; Thu, 13 Mar 2025 11:33:26 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id A6CB92188; Thu, 13 Mar 2025 11:32:31 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id A78991D8D; Thu, 13 Mar 2025 11:32:27 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 7497B2142 for ; Thu, 13 Mar 2025 11:32:20 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-658-tfcDG_afMt6Aozgb-lMh-A-1; Thu, 13 Mar 2025 11:32:17 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 93FDD1956055 for ; Thu, 13 Mar 2025 15:32:16 +0000 (UTC) Received: from hjs.brq.redhat.com (unknown [10.43.3.187]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0126E1801752 for ; Thu, 13 Mar 2025 15:32:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741879940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b3VfNxMEqydci3UhwqmEUJtXd6bkB1l6P5BLMq7WXT8=; b=X20xqjcGsHvTq4eJLGCmH+Jo+v37E2Zry/oKOgkwyQSqAiYSuXC8uavlrLMH6RSlgP5Aqz vaihThjjqCdu6XyXKzHwXpzXPP8cfIQFTUML7QYdLOqjgUkJpFSSF8FrkRiM34LepDrHMv sQGy8o7uHCQpNM4ByyMe71qEflZOJwI= X-MC-Unique: tfcDG_afMt6Aozgb-lMh-A-1 X-Mimecast-MFC-AGG-ID: tfcDG_afMt6Aozgb-lMh-A_1741879936 From: =?UTF-8?q?J=C3=A1n=20Tomko?= To: devel@lists.libvirt.org Subject: [libvirt PATCH 05/10] qemu: remove qemuCaps from qemuBuildTLSx509CommandLine Date: Thu, 13 Mar 2025 16:30:19 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2Nss6tOuUfyVBaEtt-wIrRuAX70GSOaa86LpJWoysxg_1741879936 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: VJJO623QKSOXJNRXFZTRFEYX4TNEL35W X-Message-ID-Hash: VJJO623QKSOXJNRXFZTRFEYX4TNEL35W X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1741880009650019100 Content-Type: text/plain; charset="utf-8" Also from qemuBuildGraphicsVNCCommandLine Signed-off-by: J=C3=A1n Tomko --- src/qemu/qemu_command.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 4f0a9a517c..ef1ba9269c 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1286,8 +1286,7 @@ qemuBuildTLSx509CommandLine(virCommand *cmd, bool isListen, bool verifypeer, const char *certEncSecretAlias, - const char *alias, - virQEMUCaps *qemuCaps G_GNUC_UNUSED) + const char *alias) { g_autoptr(virJSONValue) props =3D NULL; =20 @@ -1335,7 +1334,7 @@ qemuBuildChardevCommand(virCommand *cmd, dev->data.tcp.listen, chrSourcePriv->tlsVerify, tlsCertEncSecAlias, - objalias, qemuCaps) < 0) { + objalias) < 0) { return -1; } =20 @@ -8026,7 +8025,6 @@ static int qemuBuildGraphicsVNCCommandLine(virQEMUDriverConfig *cfg, const virDomainDef *def, virCommand *cmd, - virQEMUCaps *qemuCaps, virDomainGraphicsDef *graphics) { g_autofree char *audioid =3D qemuGetAudioIDString(def, graphics->data.= vnc.audioId); @@ -8107,8 +8105,7 @@ qemuBuildGraphicsVNCCommandLine(virQEMUDriverConfig *= cfg, true, cfg->vncTLSx509verify, secretAlias, - gfxPriv->tlsAlias, - qemuCaps) < 0) + gfxPriv->tlsAlias) < 0) return -1; =20 virBufferAsprintf(&opt, ",tls-creds=3D%s", gfxPriv->tlsAlias); @@ -8417,7 +8414,7 @@ qemuBuildGraphicsCommandLine(virQEMUDriverConfig *cfg, break; case VIR_DOMAIN_GRAPHICS_TYPE_VNC: if (qemuBuildGraphicsVNCCommandLine(cfg, def, cmd, - qemuCaps, graphics) < 0) + graphics) < 0) return -1; =20 break; --=20 2.48.1