From nobody Sun Feb 8 18:35:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1606129175; cv=none; d=zohomail.com; s=zohoarc; b=fC8JXhqxPHJmzgLMajBnGGvU6jznnVgA14K0qAPf5ibtfcdwA7+GAsu9k4DQbg/MronLt74b6EPpn7/XLdb2NdVw3zjg3lJZPIk8LZCqCKb4JdJB2M3+t9ZCPVGyp6KXQePzCidtKYXiaY19LqFcDTNK0hY8AaXYDO6TAGjYP4Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606129175; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fn6Aqat92yBMiIrOfCsljytfqMorcYPf4jKhrRGZcF8=; b=RW/0dX2h0tL5H7FUlIoyb36DQpAFzExzB/gM6MblHx34r8YZBRFCRmIkoCwIS28ZbV8I5NoRZJ0y9pvzx1Vy9Hx+D3xXGcK7mue8R2vtJaA4mKEm6ybdX5t4TB5hlPF0Bn3lFQ6AaehLbFrM+eeLDyhjcXIRj7RlAqNPPERl+5c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 160612917582378.58648355499122; Mon, 23 Nov 2020 02:59:35 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-13-OtU66nv9OWGLWWvlOdzKCQ-1; Mon, 23 Nov 2020 05:59:32 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0EBA39CC09; Mon, 23 Nov 2020 10:59:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D65325D9E3; Mon, 23 Nov 2020 10:59:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9CA7B180954D; Mon, 23 Nov 2020 10:59:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0ANAxMVF004018 for ; Mon, 23 Nov 2020 05:59:22 -0500 Received: by smtp.corp.redhat.com (Postfix) id 849C25D9E2; Mon, 23 Nov 2020 10:59:22 +0000 (UTC) Received: from speedmetal.lan (unknown [10.40.208.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id 924045D9CC for ; Mon, 23 Nov 2020 10:59:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606129174; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=fn6Aqat92yBMiIrOfCsljytfqMorcYPf4jKhrRGZcF8=; b=XJaN1CVQv3LPbZpY5Rb46EbFDmWre2RSH5NLBzQ7Cx3yPEbr56oUm8g5gEJR3fateVsiV4 L5NjCRzYXtR+cIgMn3gxgFk0tYYRScV+vd/ahJRVI3s4OYHzEN3qWWLXXkTJ5wuJvw4htH 2a1hCKzp75WDbN8MUOT0ePvoUa8p4D8= X-MC-Unique: OtU66nv9OWGLWWvlOdzKCQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/5] virCommandAddArg: Don't abort on invalid input Date: Mon, 23 Nov 2020 11:59:12 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Commit 912c6b22fc622cd7c7d29c7f8eaeb816b266daac added abort() when the 'val' parameter is NULL along with setting the error variable for the command. We don't want to abort in this case, just set the error. Signed-off-by: Peter Krempa --- src/util/vircommand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index 9a4f3d7f32..5117467c1d 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -1503,7 +1503,7 @@ virCommandAddArg(virCommandPtr cmd, const char *val) if (val =3D=3D NULL) { cmd->has_error =3D EINVAL; - abort(); + return; } arg =3D g_strdup(val); --=20 2.28.0