From nobody Mon Feb 9 09:08:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1675354251; cv=none; d=zohomail.com; s=zohoarc; b=fDZxRv4pAe1sNYtQQIFrqQxOox0vxLmDSZ2zPWDstgdfIWouP+jvSK5RPKw4grtgK0W8DGiigcTmQFpKf+HMa3t+kzcr+iEOOobF/rlaD570PbRzTwXzGHj6hv1XYQP1UdfyBMJ3PqHjW8EdyJeJAjCL3UYUiScjiYjqYk0f64g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1675354251; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fHQ2EZWXSFAzLEYqs+OKeIQlRhp523arn6IZLc36QCI=; b=aX+EE8pnh49Kuij2ZuVFDgbTU2knacvB4Ae/R36GtQQ3vCAiIYu9FsHRQkZw28DziBkxPNPYrwPIaOlhiHf/RbxYGtQAiG1GlBvoXrBO5SjRUUm6NLNAMgOcLJPNvv8ZGhTUOybinpBYTNaHqARDAAyXda/W2pWbgecNVFVes2k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1675354251463418.30621312899063; Thu, 2 Feb 2023 08:10:51 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-561-Jr67vhxcPR-Ya5jLkAf3JA-1; Thu, 02 Feb 2023 11:10:44 -0500 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4B6B318E004F; Thu, 2 Feb 2023 16:10:37 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 345FC492C3E; Thu, 2 Feb 2023 16:10:37 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 068F3194658C; Thu, 2 Feb 2023 16:10:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 74F5B1946586 for ; Thu, 2 Feb 2023 16:10:36 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 541CF404BEC1; Thu, 2 Feb 2023 16:10:36 +0000 (UTC) Received: from speedmetal.lan (ovpn-208-29.brq.redhat.com [10.40.208.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id C43C7404BEC0 for ; Thu, 2 Feb 2023 16:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675354250; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=fHQ2EZWXSFAzLEYqs+OKeIQlRhp523arn6IZLc36QCI=; b=RTRkdMYxp8CMA5yRjVhwJJYU3SqYJ5mr4R8gXk0vZR6pDbSXaf2i8DQMAHmCRNA9sV4xMm DJDP3hjEu6IiYbExwYlxu1polD9pka5pdCf0t4goJYc+u27l3dztNWXMFkXYDZWqD3yL3C +VJQNGQkbYxil6Nz/sU4T22e0KvUtzs= X-MC-Unique: Jr67vhxcPR-Ya5jLkAf3JA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Peter Krempa To: libvir-list@redhat.com Subject: [PATCH 1/5] virbitmap: Allow NULL bitmap in functions returning index of a set/clear bit Date: Thu, 2 Feb 2023 17:10:29 +0100 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1675354253069100001 Content-Type: text/plain; charset="utf-8" virBitmapNextSetBit/virBitmapLastSetBit/virBitmapNextClearBit can be used for iteration of a bitmap. Allow NULL bitmap so that iteration of a bitmap can be simplified in certain cases. Signed-off-by: Peter Krempa --- src/util/virbitmap.c | 9 +++++++++ src/util/virbitmap.h | 9 +++------ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index 5b9204cbd7..690ac592ba 100644 --- a/src/util/virbitmap.c +++ b/src/util/virbitmap.c @@ -824,6 +824,9 @@ virBitmapNextSetBit(virBitmap *bitmap, size_t nb; unsigned long bits; + if (!bitmap) + return -1; + if (pos < 0) pos =3D -1; @@ -863,6 +866,9 @@ virBitmapLastSetBit(virBitmap *bitmap) ssize_t sz; unsigned long bits; + if (!bitmap) + return -1; + /* If bitmap is empty then there is no set bit */ if (bitmap->map_len =3D=3D 0) return -1; @@ -916,6 +922,9 @@ virBitmapNextClearBit(virBitmap *bitmap, size_t nb; unsigned long bits; + if (!bitmap) + return -1; + if (pos < 0) pos =3D -1; diff --git a/src/util/virbitmap.h b/src/util/virbitmap.h index e2314904b0..9f954f5ee7 100644 --- a/src/util/virbitmap.h +++ b/src/util/virbitmap.h @@ -111,14 +111,11 @@ bool virBitmapIsAllSet(virBitmap *bitmap) bool virBitmapIsAllClear(virBitmap *bitmap) ATTRIBUTE_NONNULL(1); -ssize_t virBitmapNextSetBit(virBitmap *bitmap, ssize_t pos) - ATTRIBUTE_NONNULL(1); +ssize_t virBitmapNextSetBit(virBitmap *bitmap, ssize_t pos); -ssize_t virBitmapLastSetBit(virBitmap *bitmap) - ATTRIBUTE_NONNULL(1); +ssize_t virBitmapLastSetBit(virBitmap *bitmap); -ssize_t virBitmapNextClearBit(virBitmap *bitmap, ssize_t pos) - ATTRIBUTE_NONNULL(1); +ssize_t virBitmapNextClearBit(virBitmap *bitmap, ssize_t pos); size_t virBitmapCountBits(virBitmap *bitmap) ATTRIBUTE_NONNULL(1); --=20 2.39.1