From nobody Sun Feb 8 21:29:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1690900813; cv=none; d=zohomail.com; s=zohoarc; b=QMbqJPLtPwXxfcaq5wNbyrczXVgomOro6AHsJWIevBK/XVef0jdG5R56ljua5H/I97cyRAkasabQL8lHhskl4pcqZNsLQfdQyAM522YkRnsGKxFshlO2KScYJTYPUhDqsYuRfLd1ShYwFbIz8YPRgxmikqNquN3Qaaw8cviLKx4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690900813; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DEin028tRU5JTxsHBb27Z1cGpxwY2ONMJ49tqbE4AbA=; b=iimHuYTrBgf/9ThI4IP/tNidDIwmgIy6/kW44CPhMBvuNSyfVNkqnixhPqxWGQ4Yu7veVg5sm2ll9RFEQwY3Pq7ZDiBgDz3Uwa8t2w5X9K5apRWB5F/epqBJnuIR1gpBTcJxAynjopT/xvG4Y5twF6LRndGDiDaQ4mQ5g2KCnwE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 16909008134814.073523727351358; Tue, 1 Aug 2023 07:40:13 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-3-NpsQejMmNYWJE0pid78KwQ-1; Tue, 01 Aug 2023 10:40:01 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 73EA2856F67; Tue, 1 Aug 2023 14:39:51 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 054F3C57965; Tue, 1 Aug 2023 14:39:51 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CA6321946A79; Tue, 1 Aug 2023 14:39:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 21F7B1946A41 for ; Tue, 1 Aug 2023 14:33:48 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 047012017DC6; Tue, 1 Aug 2023 14:33:48 +0000 (UTC) Received: from localhost.localdomain (unknown [10.43.2.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9FC1D200A7CA for ; Tue, 1 Aug 2023 14:33:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690900812; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=DEin028tRU5JTxsHBb27Z1cGpxwY2ONMJ49tqbE4AbA=; b=Ur0oxll5Po0sYKDSemmxWxDnfRjToyB9DAbpYhklHKqdqFFvdGAVAjjc10Vrolwh0BZoZ9 AEareFKyqqTf3OAA3V6ZX9aDjrCeIixAM98eWODwdJJdJSR71C4ykblEVN0tvDGeTdH3Ig wbIX2cNTUBOzHsn2RbgWDXidyIkb8iw= X-MC-Unique: NpsQejMmNYWJE0pid78KwQ-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH 1/2] Revert "qemu_passt: Actually use @logfd" Date: Tue, 1 Aug 2023 16:33:42 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1690900814117100001 Content-Type: text/plain; charset="utf-8"; x-default="true" This reverts commit 83686f1eea1a001a37a92f2c054ffb2689c43a40. This is needed only so that the next revert is clean. Signed-off-by: Michal Privoznik --- src/qemu/qemu_passt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_passt.c b/src/qemu/qemu_passt.c index 3679bf75fc..25b22d8ad9 100644 --- a/src/qemu/qemu_passt.c +++ b/src/qemu/qemu_passt.c @@ -204,9 +204,9 @@ qemuPasstStart(virDomainObj *vm, /* The logFile location is not restricted to a per-domain director= y. It * can be anywhere. Pre-create it as passt may not have enough per= ms to * do so. */ - if ((logfd =3D qemuDomainOpenFile(cfg, vm->def, net->backend.logFi= le, - O_CREAT | O_TRUNC | O_APPEND | O_R= DWR, - &needUnlink)) < 0) { + if (qemuDomainOpenFile(cfg, vm->def, net->backend.logFile, + O_CREAT | O_TRUNC | O_APPEND | O_RDWR, + &needUnlink) < 0) { return -1; } =20 --=20 2.41.0