From nobody Mon Sep 21 12:48:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1784735104; cv=none; d=zohomail.com; s=zohoarc; b=E3JYIwIKGWjetwpwfasKwY9RO6bmcW5qaFnXRJAH2WMm6eSaYY55Opd6+DjCSrH+L5YBDdP4T5b+m6IL4iJFrTXlhatLFbgew4lLhc+LzwYICWK6qjaO2YTzvi8u/ZATJQKsv6cQCo6pnLk79hsTxXtO/zVu/kHc2cbrj0T9z10= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784735104; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=SN4N4jWixqyitJRr5XYa5NN61gOJmZX3UlE+SF4y8P4=; b=QlOD5LqJQCe8tCRadgu3bx4r+VsnzCK65OPkgJjzdf4cyf+1JzgrIa2T/oHUuaqgoN+Zd/yXo1+Hbzlm4jQlpTjeJnTSRZSqxYFe/3Yp+EB06TAR7VFXzWlRSrCElIFwLy2alm6wLYMWqyVqAbYsrIw+gDLIJyXIBydRdpeqXto= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1784735104031116.42148517899761; Wed, 22 Jul 2026 08:45:04 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id CE01641BC2; Wed, 22 Jul 2026 11:45:02 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 9E49E41C49; Wed, 22 Jul 2026 11:38:51 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5B24E4190F; Wed, 22 Jul 2026 11:38:29 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 72DB541908 for ; Wed, 22 Jul 2026 11:38:28 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-2-t4MLtX4IMteBfxc1j0icXQ-1; Wed, 22 Jul 2026 11:38:25 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C43F0182E6A5 for ; Wed, 22 Jul 2026 15:38:24 +0000 (UTC) Received: from speedmetal.lan (unknown [10.44.24.17]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1368242F for ; Wed, 22 Jul 2026 15:38:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784734708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SN4N4jWixqyitJRr5XYa5NN61gOJmZX3UlE+SF4y8P4=; b=LB3t8IOgkyG93KmBdRTw7HW/Ai55rFjwO0RDzjiycuZZqLT6wUWkkejhT+OUplfAIpcj2i LHGaXqtX3kCg7Ffga7iuxJfazTuhj37pr6lfatq7V49N3xvfNJN3XYXoTCEEgVvVsedk7k koBaRSx0C2bQZ85mGmeliUp3PBxxn2E= X-MC-Unique: t4MLtX4IMteBfxc1j0icXQ-1 X-Mimecast-MFC-AGG-ID: t4MLtX4IMteBfxc1j0icXQ_1784734704 To: devel@lists.libvirt.org Subject: [PATCH 03/13] qemu: monitor: Remove support for 'watchdog-set-action' Date: Wed, 22 Jul 2026 17:38:08 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CwyeyCscIdrjjOTsssTUm2h9gA7ymm_fwXuAs_PmMZs_1784734704 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: F4KIIV3R6KLI7ES7G3KCBN6UA5UOCUQJ X-Message-ID-Hash: F4KIIV3R6KLI7ES7G3KCBN6UA5UOCUQJ X-MailFrom: pkrempa@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Peter Krempa via Devel Reply-To: Peter Krempa X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1784735104842158500 Content-Type: text/plain; charset="utf-8" From: Peter Krempa We now use 'set-action' instead. Signed-off-by: Peter Krempa Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_monitor.c | 12 ------------ src/qemu/qemu_monitor.h | 4 ---- src/qemu/qemu_monitor_json.c | 22 ---------------------- src/qemu/qemu_monitor_json.h | 5 ----- 4 files changed, 43 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index d0acd31c05..59b3671de9 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -3965,18 +3965,6 @@ qemuMonitorMemoryDeviceSizeChangeFree(qemuMonitorMem= oryDeviceSizeChangePtr info) } -int -qemuMonitorSetWatchdogAction(qemuMonitor *mon, - const char *action) -{ - VIR_DEBUG("watchdogAction=3D%s", action); - - QEMU_CHECK_MONITOR(mon); - - return qemuMonitorJSONSetWatchdogAction(mon, action); -} - - /** * qemuMonitorBlockdevCreate: * @mon: monitor object diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index c2afb580e4..3298095e9c 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -1640,10 +1640,6 @@ qemuMonitorSetBlockThreshold(qemuMonitor *mon, const char *nodename, unsigned long long threshold); -int -qemuMonitorSetWatchdogAction(qemuMonitor *mon, - const char *action); - int qemuMonitorBlockdevCreate(qemuMonitor *mon, const char *jobname, diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 21f4d613b7..af9a77ed3b 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -7873,28 +7873,6 @@ qemuMonitorJSONSetBlockThreshold(qemuMonitor *mon, } -int -qemuMonitorJSONSetWatchdogAction(qemuMonitor *mon, - const char *action) -{ - g_autoptr(virJSONValue) cmd =3D NULL; - g_autoptr(virJSONValue) reply =3D NULL; - - if (!(cmd =3D qemuMonitorJSONMakeCommand("watchdog-set-action", - "s:action", action, - NULL))) - return -1; - - if (qemuMonitorJSONCommand(mon, cmd, &reply) < 0) - return -1; - - if (qemuMonitorJSONCheckError(cmd, reply) < 0) - return -1; - - return 0; -} - - int qemuMonitorJSONBlockdevCreate(qemuMonitor *mon, const char *jobname, diff --git a/src/qemu/qemu_monitor_json.h b/src/qemu/qemu_monitor_json.h index f4c093d717..3b7b04a11d 100644 --- a/src/qemu/qemu_monitor_json.h +++ b/src/qemu/qemu_monitor_json.h @@ -633,11 +633,6 @@ qemuMonitorJSONSetBlockThreshold(qemuMonitor *mon, unsigned long long threshold) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int -qemuMonitorJSONSetWatchdogAction(qemuMonitor *mon, - const char *action) - ATTRIBUTE_NONNULL(1); - int qemuMonitorJSONBlockdevCreate(qemuMonitor *mon, const char *jobname, --=20 2.55.0