From nobody Wed Mar 12 17:27:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1741250287722610.3022733839813; Thu, 6 Mar 2025 00:38:07 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id B334117FF; Thu, 6 Mar 2025 03:38:06 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 8D288177A; Thu, 6 Mar 2025 03:36:49 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 1596E176C; Thu, 6 Mar 2025 03:36:43 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 62ABC176F for ; Thu, 6 Mar 2025 03:36:34 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-3-y3XRy8YLPOutQ4mqadrqEQ-1; Thu, 06 Mar 2025 03:36:26 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1AB1A18001F6 for ; Thu, 6 Mar 2025 08:36:26 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.3.236]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6B724180AF71 for ; Thu, 6 Mar 2025 08:36:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741250194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bg2GyORSziyBNIC5Qat8ufIdYMfjM1aMv54Tj0yZHb8=; b=TnoFhgFbVsPCPGM7YAocjYz9FL+1hg8qTa/uJrpQpPaX9YDyswaa/i+mhbw0Zd7nXINq6y IHQ8g3HwCJFgMAwwuRvrYCREPlDVzCJe2F9g1G6s6pnLrMLK/yGXUhyLc5J5Hq6BYmKGv0 +MmXWEck0WK5Hz9J2ApbWVimt1FEfaI= X-MC-Unique: y3XRy8YLPOutQ4mqadrqEQ-1 X-Mimecast-MFC-AGG-ID: y3XRy8YLPOutQ4mqadrqEQ_1741250186 From: Michal Privoznik To: devel@lists.libvirt.org Subject: [PATCH 4/5] qemu_command: Generate cmd line for UEFI shim Date: Thu, 6 Mar 2025 09:36:17 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pjv475D3QmA143EIdQ0Qm-z9tOycARxsOhiBJ5Z2SvI_1741250186 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: BIE6Z6MAVKH5RR5CE6ZRYROEGBXHSJQS X-Message-ID-Hash: BIE6Z6MAVKH5RR5CE6ZRYROEGBXHSJQS X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1741250289221019100 Content-Type: text/plain; charset="utf-8"; x-default="true" Trivial. Resolves: https://issues.redhat.com/browse/RHEL-68043 Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 2 ++ .../launch-security-sev-direct.x86_64-latest.args | 1 + 2 files changed, 3 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 0ad73af335..c3d1d8dd70 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6026,6 +6026,8 @@ qemuBuildBootCommandLine(virCommand *cmd, virCommandAddArgList(cmd, "-initrd", def->os.initrd, NULL); if (def->os.cmdline) virCommandAddArgList(cmd, "-append", def->os.cmdline, NULL); + if (def->os.shim) + virCommandAddArgList(cmd, "-shim", def->os.shim, NULL); if (def->os.dtb) virCommandAddArgList(cmd, "-dtb", def->os.dtb, NULL); if (def->os.slic_table) { diff --git a/tests/qemuxmlconfdata/launch-security-sev-direct.x86_64-latest= .args b/tests/qemuxmlconfdata/launch-security-sev-direct.x86_64-latest.args index 09df8a7cb6..33f820f5ad 100644 --- a/tests/qemuxmlconfdata/launch-security-sev-direct.x86_64-latest.args +++ b/tests/qemuxmlconfdata/launch-security-sev-direct.x86_64-latest.args @@ -29,6 +29,7 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGue= st1/.config \ -kernel /vmlinuz \ -initrd /initrd \ -append runme \ +-shim /shim \ -device '{"driver":"piix3-usb-uhci","id":"usb","bus":"pci.0","addr":"0x1.0= x2"}' \ -blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest1","no= de-name":"libvirt-1-storage","read-only":false}' \ -device '{"driver":"ide-hd","bus":"ide.0","unit":0,"drive":"libvirt-1-stor= age","id":"ide0-0-0","bootindex":1}' \ --=20 2.45.3